Re: [Linuxptp-devel] [PATCH] Avoid switching PHC while free_running
Our use case is using the Slave Event Monitoring feature alongside free_running so to implement an external servo - on a BC with jbod. Alternatively, we saw that a similar commit (fd94d9af9f82e410574a05e672e3f92b7c165655) was merged recently to include a check for a negative phc_index. If it is preferred, we can adjust our commit to include a similar check (negative phc_index vs free_running) given that the use of a negative phc_index is the de-facto bug we are trying to fix. Thanks, Eyal. -Original Message- From: Richard Cochran Sent: Saturday, 13 May 2023 7:01 To: Eyal Itkin Cc: linuxptp-devel@lists.sourceforge.net Subject: Re: [Linuxptp-devel] [PATCH] Avoid switching PHC while free_running External email: Use caution opening links or attachments On Mon, May 01, 2023 at 02:17:21PM +0300, Eyal Itkin via Linuxptp-devel wrote: > A Boundary Clock might choose to switch a PHC when jbod is active, and > the transition will be based on the port's phc_index. However, while > free_running the phc_index is -1, thus causing a fault in the > transition. Seems like BC and free_running is a contradiction in terms. What is the use case? Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH] Avoid switching PHC while free_running
On Tue, May 16, 2023 at 01:34:56PM +, Eyal Itkin wrote: > Our use case is using the Slave Event Monitoring feature alongside > free_running so to implement an external servo - on a BC with jbod. I would encourage you to contribute the servo. After all, the code is modular with PI, linear regulator, etc... > Alternatively, we saw that a similar commit > (fd94d9af9f82e410574a05e672e3f92b7c165655) was merged recently to > include a check for a negative phc_index. If it is preferred, we can > adjust our commit to include a similar check (negative phc_index vs > free_running) given that the use of a negative phc_index is the > de-facto bug we are trying to fix. Sure. Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
Re: [Linuxptp-devel] [PATCH] Avoid switching PHC while free_running
On Mon, May 01, 2023 at 02:17:21PM +0300, Eyal Itkin via Linuxptp-devel wrote: > A Boundary Clock might choose to switch a PHC when jbod is active, > and the transition will be based on the port's phc_index. However, > while free_running the phc_index is -1, thus causing a fault in the > transition. Seems like BC and free_running is a contradiction in terms. What is the use case? Thanks, Richard ___ Linuxptp-devel mailing list Linuxptp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxptp-devel
