Re: [Linuxptp-devel] [PATCH V3 6/7] port: Provide methods to set and get the link status.

2016-10-19 Thread Richard Cochran
On Tue, Oct 18, 2016 at 08:59:17AM +0200, Miroslav Lichvar wrote: > Would it make sense to print the message only when the status has > changed? I'd rather leave them in. These are the events that the kernel is giving us, and I want to see what rtnl is doing, especially since I don't completely t

Re: [Linuxptp-devel] [PATCH V3 6/7] port: Provide methods to set and get the link status.

2016-10-18 Thread Miroslav Lichvar
On Sun, Oct 16, 2016 at 12:55:50PM +0200, Richard Cochran wrote: > +void port_link_status_set(struct port *p, int up) > +{ > + p->link_status = up ? 1 : 0; > + pr_notice("port %hu: link %s", portnum(p), up ? "up" : "down"); > +} In my testing I see duplicated messages "link up" and "link d