Re: [Linuxptp-devel] [PATCH pm 00/12] Performance Monitoring

2018-04-13 Thread Anders Selhammer 
Friday, April 13, 2018 7:16 AM

> I have two major issues with this series:
> 1. You collect statistics but never report it.

This set of patch was just for collecting and storage of the data. My intention 
was,
in a later set of patches, add possibility to collect this data. As it is now, 
there are no TLV
mentioned in the draft for this purpose. I mentioned that in my review comments 
of the draft.

But the idea was to add the collection and storage of the data. If feature is 
not enabled, no
recordlists will be filled or code executed. Just the counters will be 
collected. But that's just to 
clear when feature is enabled.

Other comments was TLV to enable/disable in runtime.

> 2. The implementation is overly complex.  I'll explain more in a reply
>  to patch #4.

Thanks, I will look at your comments on it

/Anders


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Re: [Linuxptp-devel] [PATCH pm 00/12] Performance Monitoring

2018-04-12 Thread Richard Cochran 
On Fri, Apr 06, 2018 at 12:34:31PM +0200, Anders Selhammer wrote:
> I stumbled over the suggested solution to monitor the performance
> of the network and of the network elements when I reviewed a draft
> for IEEE1588 v2.1.
> This set of patches implements the collection and local storage of
> the data needed for this performance measurement according to Annex M
> in the draft.

I have two major issues with this series:

1. You collect statistics but never report it.

2. The implementation is overly complex.  I'll explain more in a reply
   to patch #4.

Thanks,
Richard


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel