Re: [Linuxptp-devel] [PATCH v3 00/12] phc2sys: long-opts/cfg-file/tS

2018-04-13 Thread Richard Cochran
On Sat, Apr 07, 2018 at 10:35:04PM +0200, Peter Schneider wrote:
> This patch series changes phc2sys. It implements the possibility to use a
> configuration file, enables the usage of long options and allows
> configuring the transportSpecific value.
> In contrast to v2 of this patch series, all (possibly) used options make
> use of the config API.

Overall this is looking good.

Thanks,
Richard

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel


Re: [Linuxptp-devel] [PATCH v3 00/12] phc2sys: long-opts/cfg-file/tS

2018-04-09 Thread Keller, Jacob E


> -Original Message-
> From: Peter Schneider [mailto:pe...@psch.de]
> Sent: Saturday, April 07, 2018 1:35 PM
> To: linuxptp-devel@lists.sourceforge.net
> Subject: [Linuxptp-devel] [PATCH v3 00/12] phc2sys: long-opts/cfg-file/tS
> 
> This patch series changes phc2sys. It implements the possibility to use a
> configuration file, enables the usage of long options and allows
> configuring the transportSpecific value.
> In contrast to v2 of this patch series, all (possibly) used options make
> use of the config API.

This is great to see!!!

Thanks,
Jake

> 
> Peter Schneider (12):
>   phc2sys.c: Replaced usage of variable 'domain_number' with struct
> config item 'domainNumber'. Original variable still used for range
> checking. Removed (now obsolete) third parameter of init_pmc().
>   phc2sys.c: Replaced usage of variable 'print_level' with struct config
> item 'logging_level'. Original variable still used for range
> checking.
>   phc2sys.c: Replaced usage of variable 'message_tag' with struct config
> item 'message_tag'. Original variable removed.
>   phc2sys.c: Replaced usage of variable 'verbose' with struct config
> item 'verbose'. Original variable removed.
>   phc2sys.c: Replaced usage of variable 'use_syslog' with struct config
> item 'use_syslog'. Original variable removed.
>   phc2sys.c: Use struct config item 'clock_servo' for parameter
> handling. Copy this to node.servo_type afterwards.
>   phc2sys.c: Use struct config item 'kernel_leap' for parameter
> handling. Copy this to node.kernel_leap afterwards. Check for
> 'servo_type' == CLOCK_SERVO_NTPSHM.
>   phc2sys.c: Copy 'node.sanity_freq_limit' to struct config item
> 'sanity_freq_limit'. Check for 'servo_type' == CLOCK_SERVO_NTPSHM.
>   phc2sys.c: Implement configuration file handling
>   phc2sys.c: Implement handling of Long options
>   phc2sys.c: Implement using transportSpecific value
>   phc2sys.8: Doc long opts / cfgfile handling
> 
>  phc2sys.8 | 198
> +-
>  phc2sys.c |  88 +---
>  2 files changed, 261 insertions(+), 25 deletions(-)
> 
> --
> 2.14.3
> 
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Linuxptp-devel mailing list
> Linuxptp-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel