On Sat, Jul 15, 2017 at 09:33:03PM +0800, Hangbin Liu wrote:
> Add new element ts_iface in struct interface to track real ts interface.
> 
> Signed-off-by: Hangbin Liu <liuhang...@gmail.com>
> ---
>  config.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/config.h b/config.h
> index 1cc7051..f0ae3fe 100644
> --- a/config.h
> +++ b/config.h
> @@ -36,6 +36,7 @@
>  struct interface {
>       STAILQ_ENTRY(interface) list;
>       char name[MAX_IFNAME_SIZE + 1];
> +     char ts_iface[MAX_IFNAME_SIZE + 1];

This is poorly named.  We use the identifier 'iface' for pointers to
variables of type 'struct interface'.

Maybe use "ts_label" in order to avoid both the words "iface" and "name".

>       struct sk_ts_info ts_info;
>  };
>  
> -- 
> 2.5.5

Thanks,
Richard

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Linuxptp-devel mailing list
Linuxptp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxptp-devel

Reply via email to