Re: [Linuxptp-users] Regression - phc2sys fails with certain PHC char dev filenames

2021-11-12 Thread Ed Branch
On 11/12/21 11:09, Vladimir Oltean wrote: To be honest with you, I'm a bit concerned that it still won't work as intended even if I remove the error from posix_clock_add(). This is because find_dst_clock() from phc2sys finds clocks by phc_index. When you run phc2sys between this /dev/ptp_kvm and

Re: [Linuxptp-users] Regression - phc2sys fails with certain PHC char dev filenames

2021-11-12 Thread Vladimir Oltean
On Fri, Nov 12, 2021 at 10:45:53AM -0600, Ed Branch wrote: > On 11/12/21 10:36, Vladimir Oltean wrote: > > > > What is your use case for the char device symlinks exactly? The > > canonical way of finding the PTP char device corresponding to an > > interface is to use "ethtool -T eth0 | grep 'PTP H

Re: [Linuxptp-users] Regression - phc2sys fails with certain PHC char dev filenames

2021-11-12 Thread Ed Branch
On 11/12/21 10:36, Vladimir Oltean wrote: What is your use case for the char device symlinks exactly? The canonical way of finding the PTP char device corresponding to an interface is to use "ethtool -T eth0 | grep 'PTP Hardware Clock'". There is no network interface associated with this cloc

Re: [Linuxptp-users] Regression - phc2sys fails with certain PHC char dev filenames

2021-11-12 Thread Vladimir Oltean
On Fri, Nov 12, 2021 at 10:27:06AM -0600, Ed Branch wrote: > On 11/11/21 17:28, Ed Branch wrote: > > > > Thanks for the quick reply. Understood, digging this out properly (ie. > > finding the /sys/class/ptp/ptp*/dev file with a matching minor to that > > of the device node) would add a lot of comp

Re: [Linuxptp-users] Regression - phc2sys fails with certain PHC char dev filenames

2021-11-12 Thread Ed Branch
On 11/11/21 17:28, Ed Branch wrote: Thanks for the quick reply. Understood, digging this out properly (ie. finding the /sys/class/ptp/ptp*/dev file with a matching minor to that of the device node) would add a lot of complexity. However, looking at the alloc_chardev_region() call in the ptp d

Re: [Linuxptp-users] Regression - phc2sys fails with certain PHC char dev filenames

2021-11-11 Thread Keller, Jacob E
On 11/11/2021 2:34 PM, Vladimir Oltean wrote: > On Thu, Nov 11, 2021 at 03:55:29PM -0600, Ed Branch wrote: >> As of commit 380d023abb1fdce0dba9d58ca1abaf2e2de5488f PHC device nodes or >> symlinks named as "/dev/ptp*" where "*" is not a number cause phc2sys to >> fail with "failed to parse PHC index

Re: [Linuxptp-users] Regression - phc2sys fails with certain PHC char dev filenames

2021-11-11 Thread Ed Branch
On 11/11/21 16:34, Vladimir Oltean wrote: That would be me and my ts2phc patches. Sorry for that. Prior to that change, posix_clock_open() used to simply not populate *phc_index when passed a path to a PHC. I don't think there's any kernel API to deduce the PHC number using ioctls on the char dev

Re: [Linuxptp-users] Regression - phc2sys fails with certain PHC char dev filenames

2021-11-11 Thread Vladimir Oltean
On Thu, Nov 11, 2021 at 03:55:29PM -0600, Ed Branch wrote: > As of commit 380d023abb1fdce0dba9d58ca1abaf2e2de5488f PHC device nodes or > symlinks named as "/dev/ptp*" where "*" is not a number cause phc2sys to > fail with "failed to parse PHC index". Note however, if the filename does > not match t

[Linuxptp-users] Regression - phc2sys fails with certain PHC char dev filenames

2021-11-11 Thread Ed Branch
As of commit 380d023abb1fdce0dba9d58ca1abaf2e2de5488f PHC device nodes or symlinks named as "/dev/ptp*" where "*" is not a number cause phc2sys to fail with "failed to parse PHC index". Note however, if the filename does not match this pattern, it happily continues with no PHC index set. smime