Re: [Linuxptp-users] NULL pointer in port_delay_request

2018-04-27 Thread Richard Cochran
On Tue, Apr 24, 2018 at 05:13:11PM +0100, Richard Hill wrote: > > Or should the list never be empty at this point ? > > The list can't be empty. Here is why. I am so wrong. The list *can* be empty if the FD_ANNOUNCE_TIMER and the FD_DELAY_TIMER expire at the same time. In this case, the poll()

Re: [Linuxptp-users] NULL pointer in port_delay_request

2018-04-24 Thread Richard Cochran
On Tue, Apr 24, 2018 at 05:13:11PM +0100, Richard Hill wrote: > What might be relevant is the type of testing I was doing. This was > operating slaveOnly. Other Masters were appearing and disappearing quite > often. I had this NULL pointer twice over a full day. Okay, so we have an issue with sl

Re: [Linuxptp-users] NULL pointer in port_delay_request

2018-04-24 Thread Richard Hill
> > > I am getting a dst NULL pointer here (in port_delay_request) > > if (p->hybrid_e2e) { > struct ptp_message *dst = TAILQ_FIRST(&p->best->messages); > msg->address = dst->address; > msg->header.flagField[0] |= UNICAST; > } > This appears to be because the li

Re: [Linuxptp-users] NULL pointer in port_delay_request

2018-04-24 Thread Richard Cochran
On Tue, Apr 24, 2018 at 02:53:38PM +0100, Richard Hill wrote: > > > I am getting a dst NULL pointer here (in port_delay_request) > > if (p->hybrid_e2e) { > struct ptp_message *dst = TAILQ_FIRST(&p->best->messages); > msg->address = dst->address; > msg->header.flagFie

Re: [Linuxptp-users] NULL pointer in port_delay_request

2018-04-24 Thread Richard Hill
I am getting a dst NULL pointer here (in port_delay_request) if (p->hybrid_e2e) { struct ptp_message *dst = TAILQ_FIRST(&p->best->messages); msg->address = dst->address; msg->header.flagField[0] |= UNICAST; } (gdb) p dst $13 = (struct ptp_message *) 0