Re: [linuxtools-dev] Gerrit reviews,

2012-11-28 Thread sami wagiaalla
On 11/28/2012 04:43 AM, Aleksandar Kurtakov wrote: And please don't mix formatting changes with code changes as it becomes really hard to review what actually was changed. The only reason I did that was to avoid having more patches and creating a bigger series :). I actually believe that eac

Re: [linuxtools-dev] Gerrit reviews,

2012-11-28 Thread sami wagiaalla
Please try to not submit for review patch series - gerrit doesn't handle them gracefully and it makes it really hard to review stuff. The problem is Gerrit makes it more difficult for the submitter to separate the patches than for the reviewer to review them in a series; for a bunch of patc

Re: [linuxtools-dev] Gerrit reviews,

2012-11-28 Thread Aleksandar Kurtakov
And please don't mix formatting changes with code changes as it becomes really hard to review what actually was changed. P.S. From now on I'll probably reject such patches :). Alexander Kurtakov Red Hat Eclipse team - Original Message - > From: "Aleksandar Kurtakov" > To: "Linux Tools