[git:media_stage/master] media: i2c: mt9m114: Fix missing error unwind in probe()

2023-10-12 Thread Hans Verkuil
to error handling. Fix them. Fixes: 24d756e914fc ("media: i2c: Add driver for onsemi MT9M114 camera sensor") Signed-off-by: Laurent Pinchart Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/mt9m114.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---

[git:media_stage/master] media: dt-bindings: sony, imx415: Allow props from video-interface-devices

2023-10-12 Thread Hans Verkuil
copo Mondi Reviewed-by: Rob Herring Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Documentation/devicetree/bindings/media/i2c/sony,imx415.yaml | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) --- diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx415.y

[git:media_stage/master] media: dt-bindings: sony, imx214: Allow props from video-interface-devices

2023-10-12 Thread Hans Verkuil
-devices.yaml are allowed for the image sensor, make them accepted by changing "additionalProperties: false" to "unevaluatedProperties: false" at the schema top-level. Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Docu

[git:media_stage/master] media: ccs: Rework initialising sub-device state

2023-10-12 Thread Hans Verkuil
it covers of the initialisation. This fixes a bug where the driver configuration was incorrectly initialised. Fixes: d8bca3ed1d70 ("media: ccs: Use sub-device active state") Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/ccs/ccs-c

[git:media_stage/master] media: dt-bindings: Add TI J721E CSI2RX

2023-10-12 Thread Hans Verkuil
bus. The TI CSI2RX platform driver glues all the parts together. Signed-off-by: Pratyush Yadav Tested-by: Julien Massot Reviewed-by: Laurent Pinchart Reviewed-by: Rob Herring Signed-off-by: Jai Luthra Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil .../bindings/media/ti,j721e

[git:media_stage/master] media: dt-bindings: ovti, ov5640: Allow props from video-interface-devices

2023-10-12 Thread Hans Verkuil
p-level. Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) --- diff --git a/Documentation/devicetree/bindings/m

[git:media_stage/master] media: dt-bindings: ovti, ov02a10: Allow props from video-interface-devices

2023-10-12 Thread Hans Verkuil
a top-level. Signed-off-by: Jacopo Mondi Reviewed-by: Rob Herring Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) --- diff --git a/Documentation/devicetree/bin

[git:media_stage/master] media: sharp: fix sharp encoding

2023-10-11 Thread Hans Verkuil
/knowledge/ir/sharp.php Fixes: d35afc5fe097 ("[media] rc: ir-sharp-decoder: Add encode capability") Cc: sta...@vger.kernel.org Reported-by: Joe Ferner Closes: https://sourceforge.net/p/lirc/mailman/message/38604507/ Signed-off-by: Sean Young Signed-off-by: Hans Verkuil drivers/media/r

[git:media_stage/master] media: lirc: drop trailing space from scancode transmit

2023-10-11 Thread Hans Verkuil
without a trailing space. No problems have been observed so far, so this is just belt and braces. Fixes: 9b6192589be7 ("media: lirc: implement scancode sending") Cc: sta...@vger.kernel.org Signed-off-by: Sean Young Signed-off-by: Hans Verkuil drivers/media/rc/lirc_dev.c | 6 +- 1 file

[git:media_stage/master] media: i2c: tc358746: check fmt validity

2023-10-11 Thread Hans Verkuil
This is an automatic generated email to let you know that the following patch were queued: Subject: media: i2c: tc358746: check fmt validity Author: Hans Verkuil Date:Fri Oct 6 12:08:48 2023 +0200 Check if the format was really found. Fixes smatch warning: drivers/media/i2c/tc358746.c

[git:media_stage/master] staging: media: atomisp: drop check for reentrant .s_stream()

2023-10-11 Thread Hans Verkuil
This is an automatic generated email to let you know that the following patch were queued: Subject: staging: media: atomisp: drop check for reentrant .s_stream() Author: Hans Verkuil Date:Fri Oct 6 12:08:42 2023 +0200 The subdev .s_stream() operation shall not be called to start streaming

[git:media_stage/master] staging: media: atomisp: improve unwinding

2023-10-11 Thread Hans Verkuil
This is an automatic generated email to let you know that the following patch were queued: Subject: staging: media: atomisp: improve unwinding Author: Hans Verkuil Date:Fri Oct 6 12:08:44 2023 +0200 This fixes two smatch warnings: drivers/staging/media/atomisp/pci/atomisp_cmd.c:2779

[git:media_stage/fixes] media: i2c: ov8858: Don't set fwnode in the driver

2023-10-11 Thread Hans Verkuil
the driver a bit. Signed-off-by: Ondrej Jirman Reviewed-by: Jacopo Mondi Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/ov8858.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) --- diff --git a/drivers/media/i2c/ov8858.c b/drivers/media/i2c/ov8858.c

[git:media_stage/fixes] media: xilinx-vipp: Look for entities also in waiting_list

2023-10-11 Thread Hans Verkuil
by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/platform/xilinx/xilinx-vipp.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) --- diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c index 4285770fde18..99

[git:media_stage/fixes] media: ipu-bridge: Add missing acpi_dev_put() in ipu_bridge_get_ivsc_acpi_dev()

2023-10-11 Thread Hans Verkuil
call to acpi_dev_put(). Fixes: c66821f381ae ("media: pci: intel: Add IVSC support for IPU bridge driver") Signed-off-by: Geert Uytterhoeven Reviewed-by: Andy Shevchenko Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/pci/intel/ipu-bridge.c | 4 +++- 1 file change

[git:media_stage/fixes] media: subdev: Don't report V4L2_SUBDEV_CAP_STREAMS when the streams API is disabled

2023-10-11 Thread Hans Verkuil
-off-by: Hans de Goede Acked-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-subdev.c | 7 +++ 1 file changed, 7 insertions(+) --- diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index

[git:media_stage/master] media: i2c: Add driver for onsemi MT9M114 camera sensor

2023-10-07 Thread Hans Verkuil
of scaling in the ISP - Automatic exposure and white balance - Manual exposure and analog gain - Horizontal and vertical flip Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil MAINTAINERS |1 + drivers/media/i2c

[git:media_stage/master] media: vidtv: psi: Add check for kstrdup

2023-10-07 Thread Hans Verkuil
by: Jiasheng Jiang Signed-off-by: Hans Verkuil drivers/media/test-drivers/vidtv/vidtv_psi.c | 45 1 file changed, 40 insertions(+), 5 deletions(-) --- diff --git a/drivers/media/test-drivers/vidtv/vidtv_psi.c b/drivers/media/test-drivers/vidtv/vidtv_psi.c in

[git:media_stage/master] media: qcom: camss: Pass icc bandwidth table as a platform parameter

2023-10-07 Thread Hans Verkuil
not if/else derived pointer to the static table. Signed-off-by: Bryan O'Donoghue Acked-by: Konrad Dybcio Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss.c | 29 + drivers/media/platform/qcom/camss/camss.h | 3 ++- 2 files

[git:media_stage/master] media: pci: mgb4: Added Digiteq Automotive MGB4 driver

2023-10-07 Thread Hans Verkuil
-by: Martin Tůma Signed-off-by: Hans Verkuil MAINTAINERS | 7 + drivers/media/pci/Kconfig | 1 + drivers/media/pci/Makefile | 1 + drivers/media/pci/mgb4/Kconfig | 17 + drivers/media/pci/mgb4/Makefile | 6

[git:media_stage/master] media: tvp541x: Sort header files

2023-10-07 Thread Hans Verkuil
-by: Hans Verkuil drivers/media/i2c/tvp514x.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) --- diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c index 569a9437ec86..c37f605cb75f 100644 --- a/drivers/media/i2c/tvp514x.c +++ b/drivers/media/i2c

[git:media_stage/master] media: qcom: camss: Untangle if/else spaghetti in camss

2023-10-07 Thread Hans Verkuil
to be rationalised to make it more sustainable. Adding in another Soc or two will make some of these if statements into increasingly large multi-clause behemoths. Introduce switches in the obvious places to despaghetiify. Signed-off-by: Bryan O'Donoghue Acked-by: Konrad Dybcio Signed-off-by: Hans Verkuil

[git:media_stage/master] media: i2c/hi556: add a new mode 1296x722 settings

2023-10-07 Thread Hans Verkuil
Signed-off-by: Qingwu Zhang Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/hi556.c | 64 ++- 1 file changed, 63 insertions(+), 1 deletion(-) --- diff --git a/drivers/media/i2c/hi556.c b/drivers/media/i2c/hi556.c index

[git:media_stage/master] media: mediatek: vcodec: add encoder power management helper functions

2023-10-07 Thread Hans Verkuil
functions to get PM before encoding frame start and put PM after encoding frame done. Meanwhile, remove unnecessary clock operations. Signed-off-by: Irui Wang Signed-off-by: Hans Verkuil .../mediatek/vcodec/encoder/mtk_vcodec_enc.c| 21 +++-- .../mediatek/vcodec/encoder

[git:media_stage/master] media: i2c: adv7180: Drop CONFIG_OF ifdeffery

2023-10-07 Thread Hans Verkuil
. This slightly increases the size of adv7180_driver on non-OF system and shouldn't be an issue. Add mod_devicetable.h include. It also allows, in case if needed, to enumerate this device via ACPI with PRP0001 magic. Signed-off-by: Biju Das Reviewed-by: Jacopo Mondi Signed-off-by: Hans Verkuil drivers

[git:media_stage/master] media: qcom: camss: Assign the correct number of RDIs per VFE

2023-10-07 Thread Hans Verkuil
ed-by: Konrad Dybcio Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss-vfe.h | 2 -- drivers/media/platform/qcom/camss/camss.c | 20 ++-- 2 files changed, 10 insertions(+), 12 deletions(-) --- diff --git a/drivers/media/platf

[git:media_stage/master] media: qcom: camss: Allow clocks vfeN vfe_liteN or vfe_lite

2023-10-07 Thread Hans Verkuil
ng strings with the pattern above, so encapsulate the logic in one function. Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss-vfe.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) --- diff --git a/drivers/media/platform/

[git:media_stage/master] media: i2c: imx219: Drop unused macros

2023-10-07 Thread Hans Verkuil
-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 10 -- 1 file changed, 10 deletions(-) --- diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 9d84f09bcced..a9f929fc58b0 100644

[git:media_stage/master] media: i2c: imx219: Replace register addresses with macros

2023-10-07 Thread Hans Verkuil
, and use them to replace the numerical addresses. This improves readability. Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 169 ++--- 1 file changed, 81

[git:media_stage/master] media: qcom: camss: Propagate vfe_reset error up the callstack

2023-10-07 Thread Hans Verkuil
() since we didn't trap any meaningful errors. Konrad pointed out vfe_reset() could return an error, which is true. Trap the vfe_reset() error code and throw it up the callstack. Suggested-by: Konrad Dybcio Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil drivers/media/platform/qcom

[git:media_stage/master] media: tvp541x: Drop CONFIG_OF ifdeffery

2023-10-07 Thread Hans Verkuil
increases the size of tvp514x_driver on non-OF system and shouldn't be an issue. Add mod_devicetable.h include. It also allows, in case if needed, to enumerate this device via ACPI with PRP0001 magic. Signed-off-by: Biju Das Reviewed-by: Jacopo Mondi Signed-off-by: Hans Verkuil drivers/media

[git:media_stage/master] media: visl: use canonical ftrace path

2023-10-07 Thread Hans Verkuil
at: /sys/kernel/debug/tracing Update the visl decoder driver documentation to use this tracefs path. Signed-off-by: Ross Zwisler Reviewed-by: Masami Hiramatsu (Google) Reviewed-by: Steven Rostedt (Google) Signed-off-by: Hans Verkuil Documentation/admin-guide/media/visl.rst | 6 +++--- 1 file

[git:media_stage/master] media: imx334: Orphan the driver

2023-10-07 Thread Hans Verkuil
-by: Sakari Ailus Signed-off-by: Hans Verkuil MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- diff --git a/MAINTAINERS b/MAINTAINERS index 85c817eae9ae..985670c74cf0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20020,10 +20020,8 @@ T: git git://linuxtv.org

[git:media_stage/master] media: dvb-frontends: drop check because i2c_unregister_device() is NULL safe

2023-10-07 Thread Hans Verkuil
of i2c_unregister_device() because the function itself does it. Signed-off-by: Wolfram Sang Reviewed-by: Kieran Bingham Reviewed-by: Geert Uytterhoeven Signed-off-by: Hans Verkuil drivers/media/dvb-frontends/m88ds3103.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- diff --git a/drivers/media/dvb

[git:media_stage/master] media: allegro: Annotate struct mcu_msg_push_buffers_internal with __counted_by

2023-10-07 Thread Hans Verkuil
for struct mcu_msg_push_buffers_internal. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Michael Tretter Cc: Pengutronix Kernel Team Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Signed-off-by: Hans Verkuil drivers/media/platform

[git:media_stage/master] media: platform: cros-ec: Add Taranza to the match table

2023-10-07 Thread Hans Verkuil
port 1 Signed-off-by: Ken Lin Signed-off-by: Hans Verkuil drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++ 1 file changed, 2 insertions(+) --- diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c index dbee25b138ff

[git:media_stage/master] media: imx335: Orphan the driver

2023-10-07 Thread Hans Verkuil
-by: Sakari Ailus Signed-off-by: Hans Verkuil MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- diff --git a/MAINTAINERS b/MAINTAINERS index a9d4f734702b..85c817eae9ae 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20029,10 +20029,8 @@ F: Documentation/devicetree

[git:media_stage/master] media: i2c: imx219: Convert to CCI register access helpers

2023-10-07 Thread Hans Verkuil
register access helpers in the imx219 driver. This simplifies the driver by reducing the amount of code. Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/Kconfig | 1 + drivers/media/i2c/imx219.c | 513

[git:media_stage/master] media: vidtv: mux: Add check and kfree for kstrdup

2023-10-07 Thread Hans Verkuil
in order to avoid NULL pointer dereference. Moreover, use kfree() in the later error handling in order to avoid memory leak. Fixes: c2f78f0cb294 ("media: vidtv: psi: add a Network Information Table (NIT)") Signed-off-by: Jiasheng Jiang Signed-off-by: Hans Verkuil drivers/media/test-dri

[git:media_stage/master] media: s3c-camif: Avoid inappropriate kfree()

2023-10-07 Thread Hans Verkuil
tya Orlova Signed-off-by: Hans Verkuil drivers/media/platform/samsung/s3c-camif/camif-capture.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- diff --git a/drivers/media/platform/samsung/s3c-camif/camif-capture.c b/drivers/media/platform/samsung/s3c-camif/camif-capture.c index 76

[git:media_stage/master] media: qcom: camss: Rename camss struct resources to camss_subdev_resources

2023-10-07 Thread Hans Verkuil
Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss-csid.c | 2 +- drivers/media/platform/qcom/camss/camss-csid.h | 4 +-- drivers/media/platform/qcom/camss/camss-csiphy.c | 2 +- drivers/media/platform/qcom/camss/camss-csiphy.h | 4 +-- dri

[git:media_stage/master] media: qcom: camss: Support RDI3 for VFE 17x

2023-10-07 Thread Hans Verkuil
which tops-out at RDI2 meaning only three RDIs can be utilised in practice. Extend out the various routines in camss-vfe-17x.c to support the higher RDI count. Signed-off-by: Bryan O'Donoghue Acked-by: Konrad Dybcio Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/platform

[git:media_stage/master] media: qcom: camss: Amalgamate struct resource with struct resource_ispif

2023-10-07 Thread Hans Verkuil
one. Signed-off-by: Bryan O'Donoghue Acked-by: Konrad Dybcio Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss-ispif.c | 4 ++-- drivers/media/platform/qcom/camss/camss-ispif.h | 4 ++-- drivers/media/platform/qcom/camss/camss.c | 14

[git:media_stage/master] media: tvp541x: Extend match support for OF tables

2023-10-07 Thread Hans Verkuil
where the new entry goes _after_ the termination without the compiler noticing. Signed-off-by: Biju Das Reviewed-by: Jacopo Mondi Signed-off-by: Hans Verkuil drivers/media/i2c/tvp514x.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) --- diff --git a/drivers

[git:media_stage/master] media: i2c: adv7180: Extend match support for OF tables

2023-10-07 Thread Hans Verkuil
the new entry goes _after_ the termination without the compiler noticing. Signed-off-by: Biju Das Reviewed-by: Jacopo Mondi Signed-off-by: Hans Verkuil drivers/media/i2c/adv7180.c | 60 ++--- 1 file changed, 29 insertions(+), 31 deletions(-) --- diff

[git:media_stage/master] media: qcom: camss: Comment CSID dt_id field

2023-10-07 Thread Hans Verkuil
by: Bryan O'Donoghue Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss-csid-gen2.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) --- diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen2.c b/drivers/media/platform/qcom/camss/camss-csid-gen2.

[git:media_stage/master] media: cedrus: Fix clock/reset sequence

2023-10-07 Thread Hans Verkuil
. This is also consistent with vendor driver. Fixes: d5aecd289bab ("media: cedrus: Implement runtime PM") Signed-off-by: Jernej Skrabec Acked-by: Paul Kocialkowski Signed-off-by: Hans Verkuil drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 24 1 file c

[git:media_stage/master] media: qcom: camss: Start to move to module compat matched resources

2023-10-07 Thread Hans Verkuil
Acked-by: Konrad Dybcio Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss.c | 90 --- drivers/media/platform/qcom/camss/camss.h | 8 +++ 2 files changed, 54 insertions(+), 44 deletions(-) --- diff --git a/drivers/media/platform/qcom/camss/camss.c b

[git:media_stage/master] media: qcom: camss: Pass line_num from compat resources

2023-10-07 Thread Hans Verkuil
ass line_num from a compat string controlled data-structure and do so on a per-VFE basis. Later patches will assign the correct number of RDI blocks per VFE. Signed-off-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/me

[git:media_stage/master] media: qcom: camss: Pass remainder of variables as resources

2023-10-07 Thread Hans Verkuil
by: Bryan O'Donoghue Acked-by: Konrad Dybcio Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss-csid.c | 14 +-- .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 8 +- drivers/media/platform/qcom/camss/camss-csiphy.c | 16 +-- driv

[git:media_stage/master] media: cobalt: Use FIELD_GET() to extract Link Width

2023-10-07 Thread Hans Verkuil
instead of custom masking and shifting. Signed-off-by: Ilpo Järvinen Reviewed-by: Jonathan Cameron Signed-off-by: Hans Verkuil drivers/media/pci/cobalt/cobalt-driver.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) --- diff --git a/drivers/media/pci/cobalt/cobalt-driver.c b

[git:media_stage/master] media: v4l2-event: Annotate struct v4l2_subscribed_event with __counted_by

2023-10-07 Thread Hans Verkuil
Reviewed-by: Gustavo A. R. Silva Signed-off-by: Hans Verkuil drivers/media/v4l2-core/v4l2-event.c | 2 +- include/media/v4l2-event.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/v4l2-core/v4l2-event.c b/drivers/media/v4l2-core/v4l2

[git:media_stage/master] media: platform: cros-ec: Rename conns array for the match table

2023-10-07 Thread Hans Verkuil
. ex: dibbi_conns support Port D and B will be renamed to port_db_conns. Make it much cleaner and readable. Signed-off-by: Ken Lin Signed-off-by: Hans Verkuil drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 30 1 file changed, 15 insertions(+), 15 deletions

[git:media_stage/master] media: platform: mtk-mdp3: add missing of_node_put

2023-10-07 Thread Hans Verkuil
of the loop requires an of_node_put. This was done using the Coccinelle semantic patch iterators/for_each_child.cocci Signed-off-by: Julia Lawall Signed-off-by: Hans Verkuil drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c | 1 + 1 file changed, 1 insertion(+) --- diff --git a/drivers

[git:media_stage/master] media: Documentation: dv-timings.rst: explain basic approach

2023-10-07 Thread Hans Verkuil
This is an automatic generated email to let you know that the following patch were queued: Subject: media: Documentation: dv-timings.rst: explain basic approach Author: Hans Verkuil Date:Thu Sep 7 10:54:31 2023 +0200 Explain how the DV Timings API and the V4L2_EVENT_SOURCE_CHANGE event

[git:media_stage/master] media: ov9282: Assign maintenance to Dave

2023-10-07 Thread Hans Verkuil
over the driver, assign maintenance to him. Signed-off-by: Sakari Ailus Acked-by: Dave Stevenson Signed-off-by: Hans Verkuil MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- diff --git a/MAINTAINERS b/MAINTAINERS index bba09f9d0141..bcbc7c2b9c3f 100644 --- a/MAINTAINERS

[git:media_stage/master] media: nuvoton: npcm-video: Fix IS_ERR() vs NULL bug

2023-10-07 Thread Hans Verkuil
pointers. Update the check accordingly. Fixes: 70721089985c ("media: nuvoton: Add driver for NPCM video capture and encoding engine") Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil drivers/media/platform/nuvoton/npcm-video.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[git:media_stage/master] media: qcom: camss: Pass CAMSS subdev callbacks via resource ops pointer

2023-10-07 Thread Hans Verkuil
internal operations pointers from the controlling resources structure with an additional pointer added to the resources structure. This allows for the removal of most of the probe-time control structures. Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss

[git:media_stage/master] media: qcom: camss: Fix support for setting CSIPHY clock name csiphyX

2023-10-07 Thread Hans Verkuil
set during csiphy_set_clock_rates() phase. sdm845 and sm8250 will work with the code as-is so I've omitted this from a suggested Fixes list. Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss-csiphy.c | 4 1 file changed, 4 insertions(+) ---

[git:media_stage/master] media: amphion: handle firmware debug message

2023-10-07 Thread Hans Verkuil
of the firmware in case of error Fixes: 9f599f351e86 ("media: amphion: add vpu core driver") Signed-off-by: Ming Qian Reviewed-by: Nicolas Dufresne Signed-off-by: Hans Verkuil drivers/media/platform/amphion/vpu_defs.h| 1 + drivers/media/platform/amphion/vpu_helpers.c | 1 + dri

[git:media_stage/master] media: Documentation: Added Digiteq Automotive MGB4 driver documentation

2023-10-07 Thread Hans Verkuil
Automotive MGB4 driver. Signed-off-by: Martin Tůma Signed-off-by: Hans Verkuil Documentation/admin-guide/media/mgb4.rst | 374 +++ Documentation/admin-guide/media/pci-cardlist.rst | 1 + Documentation/admin-guide/media/v4l-drivers.rst | 1 + 3 files changed, 376

[git:media_stage/master] media: imx412: Orphan the driver

2023-10-07 Thread Hans Verkuil
-by: Sakari Ailus Signed-off-by: Hans Verkuil MAINTAINERS | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- diff --git a/MAINTAINERS b/MAINTAINERS index bcbc7c2b9c3f..a9d4f734702b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -20045,10 +20045,8 @@ T: git git://linuxtv.org

[git:media_stage/master] media: s5p-mfc: Fix potential deadlock on condlock

2023-10-07 Thread Hans Verkuil
nge clear_work_bit() inside enc_post_frame_start() to clear_work_bit_irqsave(). Signed-off-by: Chengfeng Ye Acked-by: Marek Szyprowski Signed-off-by: Hans Verkuil drivers/media/platform/samsung/s5p-mfc/s5p_mfc_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/med

[git:media_stage/master] media: dt-bindings: media: i2c: Add MT9M114 camera sensor binding

2023-10-07 Thread Hans Verkuil
sensor. Signed-off-by: Laurent Pinchart Reviewed-by: Rob Herring Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil .../bindings/media/i2c/onnn,mt9m114.yaml | 114 + MAINTAINERS| 7 ++ 2 files changed, 121 insertions

[git:media_stage/master] media: i2c: drop check because i2c_unregister_device() is NULL safe

2023-10-07 Thread Hans Verkuil
the function itself does it. Signed-off-by: Wolfram Sang Reviewed-by: Geert Uytterhoeven Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/i2c/rdacm20.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- diff --git a/drivers/media/i2c/rdacm20.c b/drivers

[git:media_stage/master] media: qcom: camss: Functionally decompose CSIPHY clock lookups

2023-10-07 Thread Hans Verkuil
if we have five CSIPHYs we can have no more and no less than five csiphy_timer clocks. Similarly csi_phy core clocks have a 1:1 relationship with the PHY they clock. Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss-csiphy.

[git:media_stage/master] media: qcom: camss: Remove special case for VFE get/put

2023-10-07 Thread Hans Verkuil
ent Pinchart Tested-by: Bryan O'Donoghue # rb3 # db410c Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/platform/qcom/camss/camss-csid.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) --- diff --git a/drivers/media/platform/qcom/camss/ca

[git:media_stage/master] media: qcom: camss: Move vfe_disable into a common routine where applicable

2023-10-07 Thread Hans Verkuil
in the core VFE file provided we make wm_stop() a VFE specific callback. The callback is required to capture the case where VFE 17x currently isn't VC enabled where as VFE 480 is. Suggested-by: Laurent Pinchart Signed-off-by: Bryan O'Donoghue Signed-off-by: Hans Verkuil drivers/media/platform

[git:media_stage/master] media: mtk-jpegenc: Fix bug in JPEG encode quality selection

2023-10-07 Thread Hans Verkuil
media: platform: Add jpeg enc feature") Signed-off-by: Fei Shao Reviewed-by: Chen-Yu Tsai Signed-off-by: Hans Verkuil drivers/media/platform/mediatek/jpeg/mtk_jpeg_enc_hw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpe

[git:media_stage/master] media: i2c: imx219: Set mode registers programmatically

2023-10-07 Thread Hans Verkuil
Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 134 - 1 file changed, 36 insertions(+), 98 deletions(-) --- diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index cf55c59cbb7f..927ab106cea6 100644 --- a/drivers/media

[git:media_stage/master] media: i2c: imx219: Merge format and binning setting functions

2023-10-07 Thread Hans Verkuil
Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 43 ++- 1 file changed, 10 insertions(+), 33 deletions(-) --- diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 927ab106cea6..140924445a61 100644 --- a/drivers/media/i2c/imx219

[git:media_stage/master] media: i2c: imx219: Initialize ycbcr_enc

2023-10-07 Thread Hans Verkuil
the driver behave in a less deterministic way. Fix it by picking the default value for the colorspace. Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 1 + 1 file changed, 1 insertion

[git:media_stage/master] media: i2c: imx219: Fix test pattern window for 640x480 mode

2023-10-07 Thread Hans Verkuil
-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index a14de8f3dee7..cf55c59cbb7f 100644 --- a/drivers/media/i2c/imx219.c +++ b/drivers

[git:media_stage/master] media: i2c: imx219: Group functions by purpose

2023-10-07 Thread Hans Verkuil
. No functional change is intended. Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 591 +++-- 1 file changed, 303 insertions(+), 288 deletions(-) --- diff

[git:media_stage/master] media: i2c: imx219: Infer binning settings from format and crop

2023-10-07 Thread Hans Verkuil
binning settings, instead of storing the binning mode in the imx219_mode structure. This removes duplicate information from the mode. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c

[git:media_stage/master] media: i2c: imx219: Access height from active format in imx219_set_ctrl

2023-10-07 Thread Hans Verkuil
-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) --- diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index bc836cd13ef5..f4f684bda4fa 100644 --- a/drivers

[git:media_stage/master] media: i2c: imx219: Don't store the current mode in the imx219 structure

2023-10-07 Thread Hans Verkuil
-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) --- diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index f4f684bda4fa..82e5d1dad14a 100644 --- a/drivers/media/i2c/imx219.c

[git:media_stage/master] media: i2c: imx219: Drop IMX219_VTS_* macros

2023-10-07 Thread Hans Verkuil
by the driver. They are used in a single place, and hinder readability compared to using the value directly as a decimal number. Drop them. Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Reviewed-by: Jacopo Mondi Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c

[git:media_stage/master] media: ccs: Switch to init_cfg

2023-10-07 Thread Hans Verkuil
Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/i2c/ccs/ccs-core.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) --- diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c index fb823c5c3dd3..9e8769603704 100644

[git:media_stage/master] media: i2c: imx219: Calculate crop rectangle dynamically

2023-10-07 Thread Hans Verkuil
the format, instead of storing it in the imx219_mode structure. This removes duplicated information from the mode, to guarantee consistency. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 45

[git:media_stage/master] media: i2c: imx219: Implement .init_cfg() using .set_fmt()

2023-10-07 Thread Hans Verkuil
() operation in .init_cfg(), call .set_fmt() directly. This centralizes the format and crop rectangle calculations in a single place. Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 40

[git:media_stage/master] media: Documentation: Align numbered list, make it a proper ReST

2023-10-07 Thread Hans Verkuil
output for all list entries. Also indent paragraphs of such list entries for consistency. Also use ReST numbered list syntax for the entries. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil .../userspace-api/media/v4l/dev-subdev.rst | 49

[git:media_stage/master] media: ccs: Correctly initialise try compose rectangle

2023-10-07 Thread Hans Verkuil
kari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/i2c/ccs/ccs-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c index 6a8116454f87..022e8712d48e 100644 --- a/drivers/med

[git:media_stage/master] media: v4l: subdev: Clear frame descriptor before get_frame_desc

2023-10-07 Thread Hans Verkuil
() op. Also remove the corresponding memset() calls from drivers. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Reviewed-by: Tomi Valkeinen Signed-off-by: Hans Verkuil drivers/media/i2c/ds90ub913.c | 2 -- drivers/media/i2c/ds90ub953.c | 2 -- drivers

[git:media_stage/master] media: i2c: imx219: Use active crop rectangle to configure registers

2023-10-07 Thread Hans Verkuil
in the active crop rectangle instead of the mode structure. This removes usage of the mode from the imx219_set_framefmt(). No functional change is intended. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c

[git:media_stage/master] media: ccs: Obtain media bus formats before initialising up sub-devices

2023-10-07 Thread Hans Verkuil
, at the time sub-devices are initialisaed. This is due to calling init_cfg() op via the v4l2_subdev_init_finalize(). Move ccs_get_mbus_formats() before ccs_init_subdev() calls. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/ccs/ccs-core.c | 12 ++-- 1 file changed, 6

[git:media_stage/master] media: i2c: imx219: Drop IMX219_REG_CSI_LANE_MODE from common regs array

2023-10-07 Thread Hans Verkuil
Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 1 - 1 file changed, 1 deletion(-) --- diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c index 530b03d78e34..a14de8f3d

[git:media_stage/master] media: i2c: imx219: Name all subdev state variables 'state'

2023-10-07 Thread Hans Verkuil
' through the driver. To improve consistency, name them all 'state'. Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) --- diff

[git:media_stage/master] media: i2c: imx219: Separate horizontal and vertical binning

2023-10-07 Thread Hans Verkuil
and vertical directions. Calculate their value and write them separately. Signed-off-by: Laurent Pinchart Reviewed-by: Jacopo Mondi Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 39 +++ 1 file changed, 27 insertions(+), 12

[git:media_stage/master] media: i2c: imx219: Move variables to inner scope

2023-10-07 Thread Hans Verkuil
scope in the imx219_set_pad_format() function. Move them to that scope to keep them closer to their usage and improve readability. Signed-off-by: Laurent Pinchart Reviewed-by: Dave Stevenson Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/imx219.c | 5 - 1 file

[git:media_stage/master] media: ccs: Use sub-device active state

2023-10-07 Thread Hans Verkuil
the mutex is non-existent as access to the driver's core data structure still needs to be serialised. This still removes a lot of code as the code paths for active and try state are the same in many cases. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/ccs/ccs-core.c | 286

[git:media_stage/master] media: ccs: Fix driver quirk struct documentation

2023-10-07 Thread Hans Verkuil
deviations from the standard. The flags field was drifted away from where it should have been. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/i2c/ccs/ccs-quirk.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- diff --git a/drivers

[git:media_stage/master] media: ccs: Move media_entity_pads_init to init from register

2023-10-07 Thread Hans Verkuil
init finalisation that allocates memory for sub-device state. Do that now. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/ccs/ccs-core.c | 75 +++- 1 file changed, 36 insertions(+), 39 deletions(-) --- diff --git a/drivers/media

[git:media_stage/master] media: ov2740: Use sub-device active state

2023-10-07 Thread Hans Verkuil
to the active state. Also clean up locking on s_stream handler. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/i2c/ov2740.c | 109 + 1 file changed, 42 insertions(+), 67 deletions(-) --- diff --git a/drivers

[git:media_stage/master] media: ccs: Correct error handling in ccs_register_subdev

2023-10-07 Thread Hans Verkuil
that now. Also switch to goto based error handling. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/i2c/ccs/ccs-core.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) --- diff --git a/drivers/media/i2c/ccs/ccs-core.c b

[git:media_stage/master] media: ccs: Rename ccs_create_subdev as ccs_init_subdev

2023-10-07 Thread Hans Verkuil
, including CCS specific needs. Rename it as ccs_init_subdev() as it better reflects what the function does. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil drivers/media/i2c/ccs/ccs-core.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) --- diff --git a/drivers

[git:media_stage/master] media: ov2740: Enable runtime PM before registering the async subdev

2023-10-07 Thread Hans Verkuil
as the driver UAPI may become accessible immediately after the registration. Runtime PM needs to be enabled by that time. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/i2c/ov2740.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions

[git:media_stage/master] media: ov2740: Return -EPROBE_DEFER if no endpoint is found

2023-10-07 Thread Hans Verkuil
initialised. This may happen after the sensor driver has first probed. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/i2c/ov2740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- diff --git a/drivers/media/i2c/ov2740.c b/drivers/media

[git:media_stage/master] media: mc: Check pad flag validity

2023-10-07 Thread Hans Verkuil
-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Hans Verkuil drivers/media/mc/mc-entity.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) --- diff --git a/drivers/media/mc/mc-entity.c b/drivers/media/mc/mc-entity.c index 83468d4a440b..543a392f8635 100644

[git:media_stage/master] media: ccs: Partially revert "media: i2c: Use pm_runtime_resume_and_get()"

2023-10-07 Thread Hans Verkuil
values > 0 of pm_runtime_get_sync(), thus it can't use pm_runtime_resume_and_get(). There's even a comment in the driver on this, a few lines above the code. Fixes: aa0adb399d09 ("media: i2c: Use pm_runtime_resume_and_get()") Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil dr

<    3   4   5   6   7   8   9   10   11   12   >