This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: i2c: imx334: Drop check for reentrant .s_stream()
Author:  Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Date:    Thu Sep 14 21:16:16 2023 +0300

The subdev .s_stream() operation shall not be called to start streaming
on an already started subdev, or stop streaming on a stopped subdev.
Remove the check that guards against that condition.

The streaming field of the driver's private structure is now unused,
drop it as well.

Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl>

 drivers/media/i2c/imx334.c | 9 ---------
 1 file changed, 9 deletions(-)

---

diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index 91c79af70734..1196fe93506b 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -138,7 +138,6 @@ struct imx334_mode {
  * @mutex: Mutex for serializing sensor controls
  * @menu_skip_mask: Menu skip mask for link_freq_ctrl
  * @cur_code: current selected format code
- * @streaming: Flag indicating streaming state
  */
 struct imx334 {
        struct device *dev;
@@ -161,7 +160,6 @@ struct imx334 {
        struct mutex mutex;
        unsigned long menu_skip_mask;
        u32 cur_code;
-       bool streaming;
 };
 
 static const s64 link_freq[] = {
@@ -1051,11 +1049,6 @@ static int imx334_set_stream(struct v4l2_subdev *sd, int 
enable)
 
        mutex_lock(&imx334->mutex);
 
-       if (imx334->streaming == enable) {
-               mutex_unlock(&imx334->mutex);
-               return 0;
-       }
-
        if (enable) {
                ret = pm_runtime_resume_and_get(imx334->dev);
                if (ret < 0)
@@ -1069,8 +1062,6 @@ static int imx334_set_stream(struct v4l2_subdev *sd, int 
enable)
                pm_runtime_put(imx334->dev);
        }
 
-       imx334->streaming = enable;
-
        mutex_unlock(&imx334->mutex);
 
        return 0;

_______________________________________________
linuxtv-commits mailing list
linuxtv-commits@linuxtv.org
https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits

Reply via email to