This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/cgit.cgi/v4l-utils.git tree:
Subject: cec-compliance: rename 'ok' to 'unknown' Author: Hans Verkuil <hverkuil-ci...@xs4all.nl> Date: Mon Sep 30 12:29:58 2019 +0200 The topology_probe_device() function uses a 'bool ok;' when this really means 'bool unknown;', i.e. the requested information is unknown because either the transmit failed, or the message timed out/was aborted. Calling this 'ok' was very misleading. Signed-off-by: Hans Verkuil <hverkuil-ci...@xs4all.nl> utils/cec-compliance/cec-compliance.cpp | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) --- http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=3bf9dce31f3387c2ecd1673e9841d4ce88ec24ba diff --git a/utils/cec-compliance/cec-compliance.cpp b/utils/cec-compliance/cec-compliance.cpp index d89962f0604b..756d8dbf5b78 100644 --- a/utils/cec-compliance/cec-compliance.cpp +++ b/utils/cec-compliance/cec-compliance.cpp @@ -924,16 +924,16 @@ static int poll_remote_devs(struct node *node) static void topology_probe_device(struct node *node, unsigned i, unsigned la) { struct cec_msg msg = { }; - bool ok; + bool unknown; printf("\tSystem Information for device %d (%s) from device %d (%s):\n", i, la2s(i), la, la2s(la)); cec_msg_init(&msg, la, i); cec_msg_get_cec_version(&msg, true); - ok = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); + unknown = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); printf("\t\tCEC Version : "); - if (ok) { + if (unknown) { printf("%s\n", status2s(msg).c_str()); node->remote[i].cec_version = CEC_OP_CEC_VERSION_1_4; } @@ -954,9 +954,9 @@ static void topology_probe_device(struct node *node, unsigned i, unsigned la) cec_msg_init(&msg, la, i); cec_msg_give_physical_addr(&msg, true); - ok = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); + unknown = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); printf("\t\tPhysical Address : "); - if (ok) { + if (unknown) { printf("%s\n", status2s(msg).c_str()); node->remote[i].phys_addr = CEC_PHYS_ADDR_INVALID; } @@ -971,9 +971,9 @@ static void topology_probe_device(struct node *node, unsigned i, unsigned la) cec_msg_init(&msg, la, i); cec_msg_give_device_vendor_id(&msg, true); - ok = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); + unknown = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); printf("\t\tVendor ID : "); - if (ok) { + if (unknown) { printf("%s\n", status2s(msg).c_str()); node->remote[i].vendor_id = CEC_VENDOR_ID_NONE; } else { @@ -985,9 +985,9 @@ static void topology_probe_device(struct node *node, unsigned i, unsigned la) cec_msg_init(&msg, la, i); cec_msg_give_osd_name(&msg, true); - ok = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); + unknown = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); printf("\t\tOSD Name : "); - if (ok) { + if (unknown) { printf("%s\n", status2s(msg).c_str()); } else { cec_ops_set_osd_name(&msg, node->remote[i].osd_name); @@ -1004,9 +1004,9 @@ static void topology_probe_device(struct node *node, unsigned i, unsigned la) cec_msg_init(&msg, la, i); cec_msg_give_device_power_status(&msg, true); - ok = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); + unknown = !transmit_timeout(node, &msg) || timed_out_or_abort(&msg); printf("\t\tPower Status : "); - if (ok) { + if (unknown) { printf("%s\n", status2s(msg).c_str()); } else { __u8 pwr; _______________________________________________ linuxtv-commits mailing list linuxtv-commits@linuxtv.org https://www.linuxtv.org/cgi-bin/mailman/listinfo/linuxtv-commits
