[git:media_tree/fixes] media: Don't let tvp5150_get_vbi() go out of vbi_ram_default array

2018-02-23 Thread Mauro Carvalho Chehab 
This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: Don't let tvp5150_get_vbi() go out of vbi_ram_default array
Author:  Mauro Carvalho Chehab 
Date:Mon Feb 19 13:23:39 2018 -0500

As pointed by Dan, possible values for bits[3:0] of te Line Mode Registers
can range from 0x0 to 0xf, but the check logic allow values ranging
from 0x0 to 0xe.

As static arrays are initialized with zero, using a value without
an explicit initializer at the array won't cause any harm.

Reported-by: Dan Carpenter 
Signed-off-by: Mauro Carvalho Chehab 

 drivers/media/i2c/tvp5150.c | 88 +++--
 1 file changed, 45 insertions(+), 43 deletions(-)

---

diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 3c1851984b90..2476d812f669 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -505,80 +505,77 @@ static struct i2c_vbi_ram_value vbi_ram_default[] =
/* FIXME: Current api doesn't handle all VBI types, those not
   yet supported are placed under #if 0 */
 #if 0
-   {0x010, /* Teletext, SECAM, WST System A */
+   [0] = {0x010, /* Teletext, SECAM, WST System A */
{V4L2_SLICED_TELETEXT_SECAM,6,23,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0xe7, 0x2e, 0x20, 0x26,
  0xe6, 0xb4, 0x0e, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
 #endif
-   {0x030, /* Teletext, PAL, WST System B */
+   [1] = {0x030, /* Teletext, PAL, WST System B */
{V4L2_SLICED_TELETEXT_B,6,22,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0x27, 0x2e, 0x20, 0x2b,
  0xa6, 0x72, 0x10, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
 #if 0
-   {0x050, /* Teletext, PAL, WST System C */
+   [2] = {0x050, /* Teletext, PAL, WST System C */
{V4L2_SLICED_TELETEXT_PAL_C,6,22,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0xe7, 0x2e, 0x20, 0x22,
  0xa6, 0x98, 0x0d, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
-   {0x070, /* Teletext, NTSC, WST System B */
+   [3] = {0x070, /* Teletext, NTSC, WST System B */
{V4L2_SLICED_TELETEXT_NTSC_B,10,21,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0x27, 0x2e, 0x20, 0x23,
  0x69, 0x93, 0x0d, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
-   {0x090, /* Tetetext, NTSC NABTS System C */
+   [4] = {0x090, /* Tetetext, NTSC NABTS System C */
{V4L2_SLICED_TELETEXT_NTSC_C,10,21,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0xe7, 0x2e, 0x20, 0x22,
  0x69, 0x93, 0x0d, 0x00, 0x00, 0x00, 0x15, 0x00 }
},
-   {0x0b0, /* Teletext, NTSC-J, NABTS System D */
+   [5] = {0x0b0, /* Teletext, NTSC-J, NABTS System D */
{V4L2_SLICED_TELETEXT_NTSC_D,10,21,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0xa7, 0x2e, 0x20, 0x23,
  0x69, 0x93, 0x0d, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
-   {0x0d0, /* Closed Caption, PAL/SECAM */
+   [6] = {0x0d0, /* Closed Caption, PAL/SECAM */
{V4L2_SLICED_CAPTION_625,22,22,1},
{ 0xaa, 0x2a, 0xff, 0x3f, 0x04, 0x51, 0x6e, 0x02,
  0xa6, 0x7b, 0x09, 0x00, 0x00, 0x00, 0x27, 0x00 }
},
 #endif
-   {0x0f0, /* Closed Caption, NTSC */
+   [7] = {0x0f0, /* Closed Caption, NTSC */
{V4L2_SLICED_CAPTION_525,21,21,1},
{ 0xaa, 0x2a, 0xff, 0x3f, 0x04, 0x51, 0x6e, 0x02,
  0x69, 0x8c, 0x09, 0x00, 0x00, 0x00, 0x27, 0x00 }
},
-   {0x110, /* Wide Screen Signal, PAL/SECAM */
+   [8] = {0x110, /* Wide Screen Signal, PAL/SECAM */
{V4L2_SLICED_WSS_625,23,23,1},
{ 0x5b, 0x55, 0xc5, 0xff, 0x00, 0x71, 0x6e, 0x42,
  0xa6, 0xcd, 0x0f, 0x00, 0x00, 0x00, 0x3a, 0x00 }
},
 #if 0
-   {0x130, /* Wide Screen Signal, NTSC C */
+   [9] = {0x130, /* Wide Screen Signal, NTSC C */
{V4L2_SLICED_WSS_525,20,20,1},
{ 0x38, 0x00, 0x3f, 0x00, 0x00, 0x71, 0x6e, 0x43,
  0x69, 0x7c, 0x08, 0x00, 0x00, 0x00, 0x39, 0x00 }
},
-   {0x150, /* Vertical Interval Timecode (VITC), PAL/SECAM */
+   [10] = {0x150, /* Vertical Interval Timecode (VITC), PAL/SECAM */
{V4l2_SLICED_VITC_625,6,22,0},
{ 0x00, 0x00, 0x00, 0x00, 0x00, 0x8f, 0x6d, 0x49,
  0xa6, 0x85, 0x08, 0x00, 0x00, 0x00, 0x4c, 0x00 }
},
-   {0x170, /* Vertical Interval Timecode (VITC), NTSC */
+   [11] = {0x170, /* Vertical Interval Timecode (VITC), NTSC */
{V4l2_SLICED_VITC_525,10,20,0},
{ 0x00, 0x00, 0x00, 0x00, 0x00, 0x8f, 0x6d, 0x49,
  0x69, 0x94, 0x08, 0x00, 0x00, 0x00, 0x4c, 0x00 }
},
 #endif
-   {0x190, /* Video Program System (VPS), PAL */
+   [12] = {0x190, /* Video Program

[git:media_tree/fixes] media: Don't let tvp5150_get_vbi() go out of vbi_ram_default array

2018-02-23 Thread Mauro Carvalho Chehab 
This is an automatic generated email to let you know that the following patch 
were queued:

Subject: media: Don't let tvp5150_get_vbi() go out of vbi_ram_default array
Author:  Mauro Carvalho Chehab 
Date:Mon Feb 19 13:23:39 2018 -0500

As pointed by Dan, possible values for bits[3:0] of te Line Mode Registers
can range from 0x0 to 0xf, but the check logic allow values ranging
from 0x0 to 0xe.

As static arrays are initialized with zero, using a value without
an explicit initializer at the array won't cause any harm.

Reported-by: Dan Carpenter 
Signed-off-by: Mauro Carvalho Chehab 

 drivers/media/i2c/tvp5150.c | 88 +++--
 1 file changed, 45 insertions(+), 43 deletions(-)

---

diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 3c1851984b90..2476d812f669 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
@@ -505,80 +505,77 @@ static struct i2c_vbi_ram_value vbi_ram_default[] =
/* FIXME: Current api doesn't handle all VBI types, those not
   yet supported are placed under #if 0 */
 #if 0
-   {0x010, /* Teletext, SECAM, WST System A */
+   [0] = {0x010, /* Teletext, SECAM, WST System A */
{V4L2_SLICED_TELETEXT_SECAM,6,23,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0xe7, 0x2e, 0x20, 0x26,
  0xe6, 0xb4, 0x0e, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
 #endif
-   {0x030, /* Teletext, PAL, WST System B */
+   [1] = {0x030, /* Teletext, PAL, WST System B */
{V4L2_SLICED_TELETEXT_B,6,22,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0x27, 0x2e, 0x20, 0x2b,
  0xa6, 0x72, 0x10, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
 #if 0
-   {0x050, /* Teletext, PAL, WST System C */
+   [2] = {0x050, /* Teletext, PAL, WST System C */
{V4L2_SLICED_TELETEXT_PAL_C,6,22,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0xe7, 0x2e, 0x20, 0x22,
  0xa6, 0x98, 0x0d, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
-   {0x070, /* Teletext, NTSC, WST System B */
+   [3] = {0x070, /* Teletext, NTSC, WST System B */
{V4L2_SLICED_TELETEXT_NTSC_B,10,21,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0x27, 0x2e, 0x20, 0x23,
  0x69, 0x93, 0x0d, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
-   {0x090, /* Tetetext, NTSC NABTS System C */
+   [4] = {0x090, /* Tetetext, NTSC NABTS System C */
{V4L2_SLICED_TELETEXT_NTSC_C,10,21,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0xe7, 0x2e, 0x20, 0x22,
  0x69, 0x93, 0x0d, 0x00, 0x00, 0x00, 0x15, 0x00 }
},
-   {0x0b0, /* Teletext, NTSC-J, NABTS System D */
+   [5] = {0x0b0, /* Teletext, NTSC-J, NABTS System D */
{V4L2_SLICED_TELETEXT_NTSC_D,10,21,1},
{ 0xaa, 0xaa, 0xff, 0xff, 0xa7, 0x2e, 0x20, 0x23,
  0x69, 0x93, 0x0d, 0x00, 0x00, 0x00, 0x10, 0x00 }
},
-   {0x0d0, /* Closed Caption, PAL/SECAM */
+   [6] = {0x0d0, /* Closed Caption, PAL/SECAM */
{V4L2_SLICED_CAPTION_625,22,22,1},
{ 0xaa, 0x2a, 0xff, 0x3f, 0x04, 0x51, 0x6e, 0x02,
  0xa6, 0x7b, 0x09, 0x00, 0x00, 0x00, 0x27, 0x00 }
},
 #endif
-   {0x0f0, /* Closed Caption, NTSC */
+   [7] = {0x0f0, /* Closed Caption, NTSC */
{V4L2_SLICED_CAPTION_525,21,21,1},
{ 0xaa, 0x2a, 0xff, 0x3f, 0x04, 0x51, 0x6e, 0x02,
  0x69, 0x8c, 0x09, 0x00, 0x00, 0x00, 0x27, 0x00 }
},
-   {0x110, /* Wide Screen Signal, PAL/SECAM */
+   [8] = {0x110, /* Wide Screen Signal, PAL/SECAM */
{V4L2_SLICED_WSS_625,23,23,1},
{ 0x5b, 0x55, 0xc5, 0xff, 0x00, 0x71, 0x6e, 0x42,
  0xa6, 0xcd, 0x0f, 0x00, 0x00, 0x00, 0x3a, 0x00 }
},
 #if 0
-   {0x130, /* Wide Screen Signal, NTSC C */
+   [9] = {0x130, /* Wide Screen Signal, NTSC C */
{V4L2_SLICED_WSS_525,20,20,1},
{ 0x38, 0x00, 0x3f, 0x00, 0x00, 0x71, 0x6e, 0x43,
  0x69, 0x7c, 0x08, 0x00, 0x00, 0x00, 0x39, 0x00 }
},
-   {0x150, /* Vertical Interval Timecode (VITC), PAL/SECAM */
+   [10] = {0x150, /* Vertical Interval Timecode (VITC), PAL/SECAM */
{V4l2_SLICED_VITC_625,6,22,0},
{ 0x00, 0x00, 0x00, 0x00, 0x00, 0x8f, 0x6d, 0x49,
  0xa6, 0x85, 0x08, 0x00, 0x00, 0x00, 0x4c, 0x00 }
},
-   {0x170, /* Vertical Interval Timecode (VITC), NTSC */
+   [11] = {0x170, /* Vertical Interval Timecode (VITC), NTSC */
{V4l2_SLICED_VITC_525,10,20,0},
{ 0x00, 0x00, 0x00, 0x00, 0x00, 0x8f, 0x6d, 0x49,
  0x69, 0x94, 0x08, 0x00, 0x00, 0x00, 0x4c, 0x00 }
},
 #endif
-   {0x190, /* Video Program System (VPS), PAL */
+   [12] = {0x190, /* Video Program