Re: [Linuxwacom-devel] [PATCH] Swap stylus buttons 2 and 3 for Tablet PCs

2010-07-20 Thread Peter Hutterer
On Wed, Jul 21, 2010 at 01:04:13AM +0200, Jan Steffens wrote: > Hi, > > I want to submit a patch to swap buttons 2 and 3 for TabletPCs by > default, since having the TPCButton do right-click is arguably more > useful than middle-click. > > Cheers, > Jan Steffens > From 4bb377c55cc9759c58ec54849e

[Linuxwacom-devel] [PATCH 4/6] ISDV4: use case range statements instead of nested ifs.

2010-07-20 Thread Peter Hutterer
Just to make it a bit easier to read on a glance. Signed-off-by: Peter Hutterer --- src/wcmISDV4.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c index ea33c18..d65a533 100644 --- a/src/wcmISDV4.c +++ b/src/wcmISDV4.c @@ -85

[Linuxwacom-devel] [PATCH 6/6] Make 19200 the default baud rate for 0x90 TPCs

2010-07-20 Thread Peter Hutterer
From: Jan Steffens This implements using 19200 as a default baudrate for some tablets instead of always using 38400. The baudrate switching logic in isdv4GetRanges is extended to be able to switch to 38400 as well. It also now outputs a warning. My WACf004 needs a baudrate of 19200, and is incl

[Linuxwacom-devel] [PATCH 5/6] Make sure the baudrate is properly set

2010-07-20 Thread Peter Hutterer
From: Jan Steffens If the BaudRate option isn't set, X will use the default, which issues2 9600. Make sure we properly set this option. Also make sure the it is set properly before we try to query the tablet. Signed-off-by: Jan Steffens Signed-off-by: Peter Hutterer --- src/wcmISDV4.c |6

[Linuxwacom-devel] [PATCH 0/6] ISDV4 19200 baud rate fixes

2010-07-20 Thread Peter Hutterer
Current master has some issues with serial tablets that require a baud rate of 19200, not our current default of 38400. Most notably, even if a baud rate is configured in the xorg.conf the tablet may use a wrong one. The patches below fix these issues, and set the default baudrate based on the mode

[Linuxwacom-devel] [PATCH 2/6] ISDV4: don't overwrite the baud setting for 19200 tablets.

2010-07-20 Thread Peter Hutterer
This patch changes isdv4Query to just execute the query passed in and do some additional sanity checking. If it fails, return the failure to the caller isdv4GetRanges(). isdv4GetRanges() can then change the baud rate and re-query if required. If the query at 19200 succeeds, skip the touch query. A

[Linuxwacom-devel] [PATCH 3/6] ISDV4: if the BaudRate was autodetected to 19200, replace it in the options.

2010-07-20 Thread Peter Hutterer
xf86OpenSerial() uses the BaudRate option to set the serial port. If the baud rate was autodetected to 19200, replace this so that the next DEVICE_ON call will use the right one. Signed-off-by: Peter Hutterer --- src/wcmISDV4.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff

[Linuxwacom-devel] [PATCH 1/6] ISDV4: document the init process.

2010-07-20 Thread Peter Hutterer
List which order the functions are called in to avoid having to re-read the code every single time I look at this... Signed-off-by: Peter Hutterer --- src/wcmISDV4.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/src/wcmISDV4.c b/src/wcmISDV4.c in

Re: [Linuxwacom-devel] [PATCH] Don't load keysyms into the driver, use keycodes instead.

2010-07-20 Thread Ping Cheng
On Tue, Jul 20, 2010 at 8:48 PM, Peter Hutterer wrote: > This addresses a hang in the driver when buttons are configured to send > keystrokes. The current code calls XkbGetCoreMap() which allocates during > the signal handler, causing server hangs. > > This patch changes the driver to use keycodes

Re: [Linuxwacom-devel] [PATCH] Swap stylus buttons 2 and 3 for Tablet PCs

2010-07-20 Thread Ping Cheng
> From 4bb377c55cc9759c58ec54849e42347a73284eec Mon Sep 17 00:00:00 2001 > From: Jan Steffens > Date: Mon, 19 Jul 2010 06:07:49 +0200 > Subject: [PATCH] Swap stylus buttons 2 and 3 for Tablet PCs > > There are only a few TPC pens with 2 buttons, and arguably right-click > is more useful than middl

[Linuxwacom-devel] [PATCH] Don't load keysyms into the driver, use keycodes instead.

2010-07-20 Thread Peter Hutterer
This addresses a hang in the driver when buttons are configured to send keystrokes. The current code calls XkbGetCoreMap() which allocates during the signal handler, causing server hangs. This patch changes the driver to use keycodes instead of keysyms. There are a number of reasons for this: - Xk

[Linuxwacom-devel] [PATCH] Swap stylus buttons 2 and 3 for Tablet PCs

2010-07-20 Thread Jan Steffens
Hi, I want to submit a patch to swap buttons 2 and 3 for TabletPCs by default, since having the TPCButton do right-click is arguably more useful than middle-click. Cheers, Jan Steffens From 4bb377c55cc9759c58ec54849e42347a73284eec Mon Sep 17 00:00:00 2001 From: Jan Steffens Date: Mon, 19 Jul 201