[Linuxwacom-devel] [PATCH] Gesture: send ctrl + scroll wheel events instead of +/-.

2010-07-21 Thread Peter Hutterer
The number of apps supporting scroll wheel zoom events is higher than the ones supporting ctrl +/-. And the ctrl key can be assumed on the same key for most keyboards, leaving us with a more stable zoom gesture than the previous approach of hardcoding the position of +/-. Suggested-by: Ping Cheng

Re: [Linuxwacom-devel] [PATCH] Don't load keysyms into the driver, use keycodes instead.

2010-07-21 Thread Chris Bagwell
On Wed, Jul 21, 2010 at 9:47 PM, Peter Hutterer wrote: > On Wed, Jul 21, 2010 at 09:18:26PM -0500, Chris Bagwell wrote: >> On Wed, Jul 21, 2010 at 5:10 PM, Peter Hutterer >> wrote: >> > On Wed, Jul 21, 2010 at 02:37:23PM -0700, Ping Cheng wrote: >> >> >> >> It might be easier for you to amend the

Re: [Linuxwacom-devel] [PATCH] Don't load keysyms into the driver, use keycodes instead.

2010-07-21 Thread Peter Hutterer
On Wed, Jul 21, 2010 at 09:18:26PM -0500, Chris Bagwell wrote: > On Wed, Jul 21, 2010 at 5:10 PM, Peter Hutterer > wrote: > > On Wed, Jul 21, 2010 at 02:37:23PM -0700, Ping Cheng wrote: > >> > >> It might be easier for you to amend the patch directly. Basically, we > >> can use "ctrl + mouse butto

Re: [Linuxwacom-devel] [PATCH] Don't load keysyms into the driver, use keycodes instead.

2010-07-21 Thread Chris Bagwell
On Wed, Jul 21, 2010 at 5:10 PM, Peter Hutterer wrote: > On Wed, Jul 21, 2010 at 02:37:23PM -0700, Ping Cheng wrote: >> >> It might be easier for you to amend the patch directly. Basically, we >> can use "ctrl + mouse button 4/5" for zooming. So, it would be >> something like the following: >> >>

Re: [Linuxwacom-devel] [PATCH] Don't load keysyms into the driver, use keycodes instead.

2010-07-21 Thread Ping Cheng
On Wed, Jul 21, 2010 at 3:10 PM, Peter Hutterer wrote: > On Wed, Jul 21, 2010 at 02:37:23PM -0700, Ping Cheng wrote: >> >> diff --git a/src/wcmTouchFilter.c b/src/wcmTouchFilter.c >> >> index 246b33c..7d3f860 100644 >> >> --- a/src/wcmTouchFilter.c >> >> +++ b/src/wcmTouchFilter.c >> >> @@ -467,17

Re: [Linuxwacom-devel] [PATCH] Don't load keysyms into the driver, use keycodes instead.

2010-07-21 Thread Peter Hutterer
On Wed, Jul 21, 2010 at 02:37:23PM -0700, Ping Cheng wrote: > >> diff --git a/src/wcmTouchFilter.c b/src/wcmTouchFilter.c > >> index 246b33c..7d3f860 100644 > >> --- a/src/wcmTouchFilter.c > >> +++ b/src/wcmTouchFilter.c > >> @@ -467,17 +467,23 @@ static void wcmFingerZoom(WacomDevicePtr priv) > >>

Re: [Linuxwacom-devel] [PATCH] Don't load keysyms into the driver, use keycodes instead.

2010-07-21 Thread Ping Cheng
On Tue, Jul 20, 2010 at 9:01 PM, Ping Cheng wrote: > On Tue, Jul 20, 2010 at 8:48 PM, Peter Hutterer > wrote: >> This addresses a hang in the driver when buttons are configured to send >> keystrokes. The current code calls XkbGetCoreMap() which allocates during >> the signal handler, causing serv