I've same question on 2024 value.
Are you trying to account for THRESHOLD_TOLERANCE so button could be
released at some point? I'm coming up with 16 for tolerance but 2024
is closer to 24.
This comment really applies to patch #3. So my reviewed-by applies to
patches 1, 2, and 4 and also to 3
On Mon, Feb 7, 2011 at 11:29 PM, Jason Gerecke killert...@gmail.com wrote:
s/none /non-/
Signed-off-by: Jason Gerecke killert...@gmail.com
Acked-by: Ping Cheng pingli...@gmail.com
Thank you, Jason.
Ping
---
man/wacom.man | 2 +-
tools/xsetwacom.c | 2 +-
2 files changed, 2
I have to understand why we need this patch before I can make a
comment. I will share what I understood about the Threshold and
PressureCurve first.
Threshold is the minimal pressure before a button 1 click is posted.
PressureCurve is used to soften (increase the pressure) or harden
(decrease the
On Mon, Feb 07, 2011 at 11:29:42PM -0800, Jason Gerecke wrote:
s/none /non-/
Signed-off-by: Jason Gerecke killert...@gmail.com
---
man/wacom.man |2 +-
tools/xsetwacom.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/man/wacom.man b/man/wacom.man
On Tue, Feb 08, 2011 at 08:29:01AM -0600, Chris Bagwell wrote:
I've same question on 2024 value.
Are you trying to account for THRESHOLD_TOLERANCE so button could be
released at some point? I'm coming up with 16 for tolerance but 2024
is closer to 24.
yeah, sorry. simple typo from being
On Tue, Feb 08, 2011 at 12:16:12PM -0800, Ping Cheng wrote:
I have to understand why we need this patch before I can make a
comment. I will share what I understood about the Threshold and
PressureCurve first.
Threshold is the minimal pressure before a button 1 click is posted.
PressureCurve
On Thu, Feb 03, 2011 at 09:12:10PM -0800, Ping Cheng wrote:
Signed-off-by: Ping Cheng pingli...@gmail.com
---
src/wcmUSB.c | 17 -
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/src/wcmUSB.c b/src/wcmUSB.c
index 689378a..017e3a0 100644
--- a/src/wcmUSB.c
For consistency with the rest of the code.
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net
---
src/wcmCommon.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/wcmCommon.c b/src/wcmCommon.c
index d62ce3d..59c7af3 100644
--- a/src/wcmCommon.c
+++
This is a stopgap solution only. Due to the current hotplugging approach,
the dependent tools are initialised before the parent device. This leaves us
with a time window where the parent device does not yet have a DeviceIntPtr
attached.
If an event from the parent device comes in during this time
