Re: [Linuxwacom-devel] [PATCH 3/4] Keep an enabled flag in the tool to avoid racy startup.

2011-03-03 Thread Ping Cheng
On Thu, Mar 3, 2011 at 2:35 AM, Peter Hutterer peter.hutte...@who-t.netwrote: On 3/03/11 17:07 , Ping Cheng wrote: On Wed, Mar 2, 2011 at 10:06 PM, Peter Hutterer peter.hutte...@who-t.net mailto:peter.hutte...@who-t.net wrote: There is a small time window where a device may try to send

[Linuxwacom-devel] wcmTilt2R

2011-03-03 Thread Peter Hutterer
Ok, having just spend 2 hours looking at this function and trying to fix it pieces I give up. I can't even figure out what this is doing. Can someone please explain to me what this function is actually supposed to be doing? The atan2() inverses the rotation direction, I got that far. Then we

[Linuxwacom-devel] [PATCH 02/11] Document findTool()

2011-03-03 Thread Peter Hutterer
And rename tooldef to tooldefault, I always get confused by that. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmCommon.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index bf33507..7f420ef 100644

[Linuxwacom-devel] [PATCH 03/11] Remove now-obsolete condition.

2011-03-03 Thread Peter Hutterer
With the removal of the tool areas, this check became obsolete. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmCommon.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index 7f420ef..89a4d81 100644 ---

[Linuxwacom-devel] [PATCH 07/11] test: remove miPointer wrappers, unneded.

2011-03-03 Thread Peter Hutterer
Obsolete with a9fe6a0337183c653ede6b5724612a138b022fb9 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/fake-symbols.c |6 -- test/fake-symbols.h |1 - 2 files changed, 0 insertions(+), 7 deletions(-) diff --git a/test/fake-symbols.c b/test/fake-symbols.c index

[Linuxwacom-devel] [PATCH 06/11] test: add tests for wcmCheckSuppress.

2011-03-03 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- test/wacom-tests.c | 86 1 files changed, 86 insertions(+), 0 deletions(-) diff --git a/test/wacom-tests.c b/test/wacom-tests.c index b8ad63c..23bfba6 100644 --- a/test/wacom-tests.c

[Linuxwacom-devel] [PATCH 09/11] Fix indentation in wcmTilt2R.

2011-03-03 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmFilter.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/wcmFilter.c b/src/wcmFilter.c index 9f4f366..5f3fa7d 100644 --- a/src/wcmFilter.c +++ b/src/wcmFilter.c @@ -332,7 +332,7 @@ void

Re: [Linuxwacom-devel] [PATCH 02/11] Document findTool()

2011-03-03 Thread Ping Cheng
Shouldn't we merge 8/11 to this one? Ping On Thu, Mar 3, 2011 at 4:56 PM, Peter Hutterer peter.hutte...@who-t.netwrote: And rename tooldef to tooldefault, I always get confused by that. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmCommon.c | 16 1

Re: [Linuxwacom-devel] [PATCH 02/11] Document findTool()

2011-03-03 Thread Peter Hutterer
On Thu, Mar 03, 2011 at 05:37:16PM -0800, Ping Cheng wrote: Shouldn't we merge 8/11 to this one? yeah, fair call. I'll squash them together. Cheers, Peter On Thu, Mar 3, 2011 at 4:56 PM, Peter Hutterer peter.hutte...@who-t.netwrote: And rename tooldef to tooldefault, I always get

Re: [Linuxwacom-devel] [PATCH 10/11] Fix typo for max axis range on the cursor tool.

2011-03-03 Thread Peter Hutterer
On Thu, Mar 03, 2011 at 05:36:07PM -0800, Ping Cheng wrote: On Thu, Mar 3, 2011 at 4:56 PM, Peter Hutterer peter.hutte...@who-t.netwrote: This also suggests that no-one has actually tried a cursor tool with this driver... That comment is inaccurate ;). Cursor moves and clicks all

Re: [Linuxwacom-devel] [PATCH 05/11] Rewrite wcmCheckSuppress

2011-03-03 Thread Peter Hutterer
On Thu, Mar 03, 2011 at 06:06:01PM -0800, Ping Cheng wrote: On Thu, Mar 3, 2011 at 4:56 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Instead of returning rather ambiguous 0, 1 and 2, return enums with readable descriptions. No functional changes, other than that we now skip a

Re: [Linuxwacom-devel] [PATCH 05/11] Rewrite wcmCheckSuppress

2011-03-03 Thread Ping Cheng
On Thu, Mar 3, 2011 at 6:35 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Thu, Mar 03, 2011 at 06:06:01PM -0800, Ping Cheng wrote: On Thu, Mar 3, 2011 at 4:56 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Instead of returning rather ambiguous 0, 1 and 2, return enums with