Re: [Linuxwacom-devel] [PATCH] remove per-device filter function

2011-03-11 Thread Chris Bagwell
On Thu, Mar 10, 2011 at 2:26 PM, Favux ... favux...@gmail.com wrote: Hi Chris, BackBONE7 reports the patch didn't work for his stylus issue.  Sounds more like jumps than jitters. He sees:    (WW) Serial Wacom Tablet stylus: bad data at 7 v=91 l=9    (WW) Serial Wacom Tablet stylus: bad

Re: [Linuxwacom-devel] [PATCH] xsetwacom: update the property when we have items to write

2011-03-11 Thread Chris Bagwell
This looks needed: Acked-by: Chris Bagwell ch...@cnpbagwell.com On Thu, Mar 10, 2011 at 5:12 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Introduced in 22bc3028effbdc79d426c0b3dcf586734d4c7532, changed logic caused the property not to update in all cases. Signed-off-by: Peter Hutterer

Re: [Linuxwacom-devel] [PATCH] xsetwacom: remove unused need_update

2011-03-11 Thread Chris Bagwell
Reviewed-by: Chris Bagwell ch...@cnpbagwell.com On Thu, Mar 10, 2011 at 5:30 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Unused since ba77b532e6c2a0b7b05ab129009c1f614b089c37 Signed-off-by: Peter Hutterer peter.hutte...@who-t.net ---  tools/xsetwacom.c |    2 --  1 files changed, 0

Re: [Linuxwacom-devel] [PATCH] Remove XWACOM_MAX_SAMPLES

2011-03-11 Thread Ping Cheng
On Fri, Mar 11, 2011 at 8:39 AM, Jason Gerecke killert...@gmail.com wrote: XWACOM_MAX_SAMPLES is a duplicate of MAX_SAMPLES, and appears to have no reason to be included in the Xwacom.h header. We remove it and retarget all references. Signed-off-by: Jason Gerecke killert...@gmail.com

Re: [Linuxwacom-devel] [PATCH] remove per-device filter function

2011-03-11 Thread Favux ...
Hi Chris, My fault. Yes the Toshiba Portege M700 and M750's are serial tabletPCs with 1FGT. So good guess. I believe the M750's can have 2FGT also, depending on what was ordered. I suggested your change. Hopefully he'll want to try it. Dave On Fri, Mar 11, 2011 at 10:30 AM, Chris Bagwell

Re: [Linuxwacom-devel] [PATCH 3/4] Keep an enabled flag in the tool to avoid racy startup.

2011-03-11 Thread Ping Cheng
On Thu, Mar 10, 2011 at 7:45 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Thu, Mar 10, 2011 at 05:51:34PM -0800, Ping Cheng wrote: On Wed, Mar 2, 2011 at 10:06 PM, Peter Hutterer peter.hutte...@who-t.netwrote: There is a small time window where a device may try to send an event

[Linuxwacom-devel] [PATCH v2] Require PROP_FLAG_BOOLEAN params to be 'off' or 'on

2011-03-11 Thread Jason Gerecke
This patch set breaks apart the referenced patch into its component changes as requested by Peter. -- Colocation vs. Managed Hosting A question and answer guide to determining the best fit for your organization - today

[Linuxwacom-devel] [PATCH v2 2/5] Detect boolean conversion failure in convert_value_from_user

2011-03-11 Thread Jason Gerecke
Properties with PROP_FLAG_BOOLEAN set can only take on a restricted set of values. We detect if the string matches any of the allowed values and convert if possible. If not possible, the caller is notified. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c |9 +++--

[Linuxwacom-devel] [PATCH v2 5/5] Add tests for convert_value_from_user

2011-03-11 Thread Jason Gerecke
Some basic tests to ensure booleans and non-booleans act like we want them to. Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c | 43 +++ 1 files changed, 43 insertions(+), 0 deletions(-) diff --git a/tools/xsetwacom.c

[Linuxwacom-devel] [PATCH v2 4/5] Expand recognized boolean input for convert_value_from_user

2011-03-11 Thread Jason Gerecke
We remove the case sensitivity requirement for off/on and also allow the use of true and false Signed-off-by: Jason Gerecke killert...@gmail.com --- tools/xsetwacom.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xsetwacom.c b/tools/xsetwacom.c index

[Linuxwacom-devel] [PATCH] Fix button assignment bug introduced in 22bc3028

2011-03-11 Thread Jason Gerecke
I just noticed I was unable to map button presses to keys and after some investigation (yay git bisect!) found the following commit caused the bug: 22bc3028effbdc79d426c0b3dcf586734d4c7532 It appears the original comment accompaning the argc check was wrong. The original 'if' statement was if

Re: [Linuxwacom-devel] [PATCH] Fix button assignment bug introduced in 22bc3028

2011-03-11 Thread Chris Bagwell
I just acked a similar patch from Peter because his addition of nitems looked needed and I didn't have time to think in depth about earlier patch that caused issue. - if (unset_prop) + if (unset_prop || nitems 0) XChangeDeviceProperty(dpy, dev, prop, XA_INTEGER, 32,