[Linuxwacom-devel] [PATCH 1/2 v3] Support pen and MT on the same logical port

2011-03-21 Thread Ping Cheng
Serial ISDv4 kernel driver, wacom_w8001.ko, provides both pen and touch events on the same logical port. Filtering touch events when pen is in proximity while allowing pen events (ABS_X/Y, etc) pass. Making this action configurable would make sense when XInput 2.1 is ready. At that point, we can

[Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-21 Thread Eduard Hasenleithner
Hi Here I have a very early draft for setting the Intuos4 OLED display by means of xsetwacom. It defines a new pseudo-property Wacom Button Image. When XChangeDeviceProperty is called with a 2049 octet data, the first octet is taken as the button number, and the remaining 2048 octets are taken

[Linuxwacom-devel] [PATCH] test: drop glib dependency

2011-03-21 Thread Peter Hutterer
We weren't really using any of the glib-specific stuff anyway, so just replace g_assert with normal assert and drop the dependency. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- configure.ac | 11 + test/Makefile.am |4 +- test/wacom-tests.c | 122

[Linuxwacom-devel] GNOME configuration not-quite-GUI

2011-03-21 Thread Peter Hutterer
As you know, the gnome GUI to configure wacom devices is taking its time. Currently it's waiting for designers approval (or comments). Meanwhile, GNOME 3.0 will have a configuration interface that allows scripts to configure devices (including wacom devices) that aren't covered by the existing

Re: [Linuxwacom-devel] [PATCH] Remove one FIXME

2011-03-21 Thread Peter Hutterer
On Fri, Mar 18, 2011 at 03:07:24PM -0700, Ping Cheng wrote: Get the f out of the code as well as the root cause. A proper fix would be to use resolution to decide the distance. That can be considered when we push the resolution table to the kernel. Hopefully, at that time, we can also post

Re: [Linuxwacom-devel] [PATCH 1/2 v3] Support pen and MT on the same logical port

2011-03-21 Thread Peter Hutterer
On Mon, Mar 21, 2011 at 02:09:58PM -0700, Ping Cheng wrote: Serial ISDv4 kernel driver, wacom_w8001.ko, provides both pen and touch events on the same logical port. Filtering touch events when pen is in proximity while allowing pen events (ABS_X/Y, etc) pass. Making this action configurable

Re: [Linuxwacom-devel] [PATCH 2/2] Enable left click for MT touchscreen

2011-03-21 Thread Peter Hutterer
On Mon, Mar 21, 2011 at 02:10:42PM -0700, Ping Cheng wrote: Tools that are in absolute mode emit left click when the tool touches the surface. However, tools in relative mode need to locate the object on the surface before it selects (left click on) the object. That is, a second event

[Linuxwacom-devel] [PATCH] Fix strip_keys index, copy/paste error.

2011-03-21 Thread Peter Hutterer
Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmCommon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index d024ad8..caa6774 100644 --- a/src/wcmCommon.c +++ b/src/wcmCommon.c @@ -376,7 +376,7 @@ static int

Re: [Linuxwacom-devel] [PATCH 1/2] Fix X crash after remapping touchstrips and wheels

2011-03-21 Thread Peter Hutterer
On Fri, Mar 18, 2011 at 06:01:16PM -0700, Jason Gerecke wrote: Crash first appears in ab311bf20535acd6e7201e024bc311e0e15b5b6b. This commit rewrote wcmUpdateButtonKeyActions with one-indexed arrays in mind and extended the 'keys' array in _WacomDeviceRec to make room. However, the 'wheel_keys'

Re: [Linuxwacom-devel] [PATCH 2/2] Clear the correct amount of memory

2011-03-21 Thread Peter Hutterer
On Fri, Mar 18, 2011 at 06:01:17PM -0700, Jason Gerecke wrote: Though this doesn't result in any bad behavior at the moment, it could cause some serious headaches in the future. Signed-off-by: Jason Gerecke killert...@gmail.com --- src/wcmXCommand.c |2 +- 1 files changed, 1

[Linuxwacom-devel] [PATCH] wcmUSB: change MOD_BUTTONS macro into a function

2011-03-21 Thread Peter Hutterer
Values in, values out. No magic state structs, keep it simple. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmUSB.c | 55 --- test/wacom-tests.c | 16 +++ 2 files changed, 55 insertions(+), 16 deletions(-)

Re: [Linuxwacom-devel] [PATCH 1/3] Prepare for the removal of BTN_TOOL_FINGER for pad tool in the kernel

2011-03-21 Thread Peter Hutterer
On Mon, Mar 21, 2011 at 05:55:18PM -0700, Ping Cheng wrote: BTN_TOOL_FINGER was borrowed to group PAD events. With the support of pen and touch on the same logical port, we can not use it any more. PAD events of generic protocol has already manually routed to the pad channel, the last

Re: [Linuxwacom-devel] [PATCH] test: drop glib dependency

2011-03-21 Thread Ping Cheng
Thank you for the patch. Acked-by: Ping Cheng pingli...@gmail.com Ping On Mon, Mar 21, 2011 at 7:02 PM, Peter Hutterer peter.hutte...@who-t.netwrote: We weren't really using any of the glib-specific stuff anyway, so just replace g_assert with normal assert and drop the dependency.

Re: [Linuxwacom-devel] [PATCH 2/3] Move findDeviceType from wcmCommon to wcmUSB

2011-03-21 Thread Peter Hutterer
On Mon, Mar 21, 2011 at 05:55:41PM -0700, Ping Cheng wrote: Serial model is not supported. So, findDeviceType is only used by wcmUSB.c. Now it is the individual model's, wcmUSB or wcmISDV4, responsibility to set the device type locally. For wcmUSB, since kernel input filters out duplicated

Re: [Linuxwacom-devel] [PATCH 3/3] Bring idtotype and findDeviceType to the style

2011-03-21 Thread Peter Hutterer
On Mon, Mar 21, 2011 at 05:56:09PM -0700, Ping Cheng wrote: Make them into the usb family and follow the style guide. Consolidate tool id for the existing tools into three defines. Update findDeviceType to cover more cases so it may be called by other routines to retrieve tool types.