[Linuxwacom-devel] [PATCH libwacom] Rely on the PRODUCT attribute to fetch the bus, vid pid informations

2014-09-11 Thread Benjamin Tissoires
PRODUCT attribute is set correctly for the input device, whether the device is USB or Bluetooth. We can use a common path for those two. uinput devices have their PRODUCT attribute set according to the registered device, so they work too. This change allows libwacom to properly detect the actual

Re: [Linuxwacom-devel] [PATCH libwacom] Rely on the PRODUCT attribute to fetch the bus, vid pid informations

2014-09-11 Thread Bastien Nocera
On Thu, 2014-09-11 at 14:07 -0400, Benjamin Tissoires wrote: PRODUCT attribute is set correctly for the input device, whether the device is USB or Bluetooth. We can use a common path for those two. uinput devices have their PRODUCT attribute set according to the registered device, so they work

[Linuxwacom-devel] [PATCH libwacom] Rely on the PRODUCT attribute to fetch the bus, vid pid informations

2014-09-11 Thread Benjamin Tissoires
PRODUCT attribute is set correctly for the input device, whether the device is USB or Bluetooth. We can use a common path for those two. uinput devices have their PRODUCT attribute set according to the registered device, so they work too. This change allows libwacom to properly detect the actual

Re: [Linuxwacom-devel] [PATCH libwacom] Rely on the PRODUCT attribute to fetch the bus, vid pid informations

2014-09-11 Thread Bastien Nocera
On Thu, 2014-09-11 at 14:45 -0400, Benjamin Tissoires wrote: + /* Parse the PRODUCT attribute (for Bluetooth and USB) */ + retval = get_bus_vid_pid (device, bus, vendor_id, product_id, error); + if (retval) + goto bail; Can you rename the bail label to out? I

Re: [Linuxwacom-devel] [PATCH libwacom] Rely on the PRODUCT attribute to fetch the bus, vid pid informations

2014-09-11 Thread Benjamin Tissoires
On Sep 11 2014 or thereabouts, Bastien Nocera wrote: On Thu, 2014-09-11 at 14:45 -0400, Benjamin Tissoires wrote: + /* Parse the PRODUCT attribute (for Bluetooth and USB) */ + retval = get_bus_vid_pid (device, bus, vendor_id, product_id, error); + if (retval) +

Re: [Linuxwacom-devel] [PATCH libwacom] Rely on the PRODUCT attribute to fetch the bus, vid pid informations

2014-09-11 Thread Bastien Nocera
On Thu, 2014-09-11 at 15:02 -0400, Benjamin Tissoires wrote: On Sep 11 2014 or thereabouts, Bastien Nocera wrote: On Thu, 2014-09-11 at 14:45 -0400, Benjamin Tissoires wrote: + /* Parse the PRODUCT attribute (for Bluetooth and USB) */ + retval = get_bus_vid_pid (device, bus,

[Linuxwacom-devel] [PATCH v3 libwacom] Rely on the PRODUCT attribute to fetch the bus, vid pid informations

2014-09-11 Thread Benjamin Tissoires
PRODUCT attribute is set correctly for the input device, whether the device is USB or Bluetooth. We can use a common path for those two. uinput devices have their PRODUCT attribute set according to the registered device, so they work too. This change allows libwacom to properly detect the actual

Re: [Linuxwacom-devel] [PATCH v3 libwacom] Rely on the PRODUCT attribute to fetch the bus, vid pid informations

2014-09-11 Thread Benjamin Tissoires
On Thu, Sep 11, 2014 at 3:25 PM, Benjamin Tissoires benjamin.tissoi...@redhat.com wrote: PRODUCT attribute is set correctly for the input device, whether the device is USB or Bluetooth. We can use a common path for those two. uinput devices have their PRODUCT attribute set according to the