Re: [Linuxwacom-devel] [PATCH 0/3] Bamboo 3rd gen in input-wacom

2011-11-28 Thread Ping Cheng
On Sat, Nov 26, 2011 at 4:29 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com Hi all.  maybe this will help out some users.  I added a back port of latest drivers to 2.6.38 kernel inside input-wacom package since that is first version that supports mt.h header file

Re: [Linuxwacom-devel] [PATCH] Initial driver for Wacom Intuos4 Wireless (Bluetooth) - final version

2011-10-31 Thread Ping Cheng
On Mon, Oct 31, 2011 at 5:02 AM, Przemo Firszt prz...@firszt.eu wrote: Dnia 2011-10-24, pon o godzinie 10:52 -0700, Ping Cheng pisze: On Sun, Oct 23, 2011 at 5:17 AM, Przemo Firszt prz...@firszt.eu wrote: Next part of the I4 WL driver attached - this time pen button reporting. This is part

Re: [Linuxwacom-devel] [PATCH] Add pen button reporting for Intuos4 WL (HID driver)

2011-10-24 Thread Ping Cheng
On Sun, Oct 23, 2011 at 5:17 AM, Przemo Firszt prz...@firszt.eu wrote: Next part of the I4 WL driver attached - this time pen button reporting. This is part of I4 WL support. We should merge it into the other patch. Ping

Re: [Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-24 Thread Ping Cheng
On Sun, Oct 23, 2011 at 8:22 PM, Peter Hutterer peter.hutte...@who-t.net wrote: what other axes are on this device? if it's just 2 anyway this is a nonissue. if there are other axes we need to rely on the client to determine which axis represents what anyway (already the case for XI 1.x)

Re: [Linuxwacom-devel] Status of Intuos4 driver (USB)

2011-10-21 Thread Ping Cheng
On Fri, Oct 21, 2011 at 5:21 AM, Przemo Firszt prz...@firszt.eu wrote: Hi, What's the current status of Intuos4 (USB) driver. Is it fully finctional? I just connected mine Intuos4 WL using USB cable and tablet works, but pen buttons are dead. Is that WL specific (so I can fix it) or it's

Re: [Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-21 Thread Ping Cheng
On Thu, Oct 20, 2011 at 11:46 PM, Peter Hutterer peter.hutte...@who-t.net wrote: This requires an interface change. We will need to only report 2 valuators, x and y. That might be fine with newer X server and Gtk versions. But, I guess we'll need to deal with backward compatibility issue. I am

Re: [Linuxwacom-devel] [PATCH] Initial driver for Wacom Intuos4 Wireless - version 3, merge with hid-wacom.c

2011-10-21 Thread Ping Cheng
On Fri, Oct 21, 2011 at 1:29 PM, Przemo Firszt prz...@firszt.eu wrote: Verssion 3. The only difference is __set_bit(INPUT_PROP_POINTER, input-propbit); moved to common section of probe function. I don't think I have time to test Graphire WL. You can add my Acked-by when submitting to

[Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-21 Thread Ping Cheng
On Fri, Oct 21, 2011 at 6:55 AM, Chris Bagwell ch...@cnpbagwell.com wrote: pressure.  Maybe your seeing something related to pen proximity masking that I didn't consider since my hw doesn't have pen support. No, my touchscreen doesn't support pen. It's a single touch device.

Re: [Linuxwacom-devel] [PATCH 1/2] Process pressure only when it is supported

2011-10-20 Thread Ping Cheng
On Wed, Oct 19, 2011 at 7:01 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Oct 19, 2011 at 7:01 PM, Ping Cheng pingli...@gmail.com wrote: normalizePressure crashes if wcmMaxZ is 0. The crash must depend on version of Xorg your using.  I'd assume I'd see this crash as well now that I'm

Re: [Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-20 Thread Ping Cheng
On Thu, Oct 20, 2011 at 8:03 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Oct 19, 2011 at 9:10 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Oct 19, 2011 at 7:01 PM, Ping Cheng pingli...@gmail.com wrote: So, we can not rely on pressure to set button 1 click for touch screen

Re: [Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-20 Thread Ping Cheng
On Thu, Oct 20, 2011 at 8:03 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Oct 19, 2011 at 9:10 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Oct 19, 2011 at 7:01 PM, Ping Cheng pingli...@gmail.com wrote: So, we can not rely on pressure to set button 1 click for touch screen

Re: [Linuxwacom-devel] [PATCH] Initial driver for Wacom Intuos4 Wireless - version 2, merge with hid-wacom.c

2011-10-20 Thread Ping Cheng
On Tue, Oct 18, 2011 at 12:18 PM, Przemo Firszt prz...@firszt.eu wrote: Please test comment. I cannot convince git to block text in a different way - if anyone knows how to do it please let me know. Can I assume you have tested the driver with your Graphire WL? Why do we need to move

[Linuxwacom-devel] [PATCH 1/2] Process pressure only when it is supported

2011-10-19 Thread Ping Cheng
normalizePressure crashes if wcmMaxZ is 0. Signed-off-by: Ping Cheng pi...@wacom.com --- src/wcmCommon.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index c3c8907..08b3283 100644 --- a/src/wcmCommon.c +++ b/src/wcmCommon.c

[Linuxwacom-devel] [PATCH 2/2] Pressure is not reported for touch devices in the kernel

2011-10-19 Thread Ping Cheng
So, we can not rely on pressure to set button 1 click for touch screen devices. Signed-off-by: Ping Cheng pi...@wacom.com --- src/wcmCommon.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index 08b3283..016e5e7

Re: [Linuxwacom-devel] [PATCH] Initial driver for Wacom Intuos4 Wireless (Bluetooth)

2011-10-08 Thread Ping Cheng
On Fri, Oct 7, 2011 at 2:53 PM, Przemo Firszt prz...@firszt.eu wrote: Hi, Please comment, test, ack, sign-off and so on. I would share the common routines and structs between hid-wacom.c and hid-wacom-i4wl.c instead of creating new ones. Besides less code to maintain, I think we want to keep

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-28 Thread Ping Cheng
On Wed, Sep 28, 2011 at 4:02 PM, Peter Hutterer peter.hutte...@who-t.net wrot We can make the xsetwacom led a get and set command (instead of get-only). If end users can set led status, the following may happen: one user/app may change the status while the other wants it unchanged. How do we

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-27 Thread Ping Cheng
TODO: * Add function for setting the status led I am working on patches to support this function as well as retrieving the LED status from the kernel. The code is for linuxwacom, the older X servers, right now. I need to submit the kernel patch that adds ABS_LED_STATUS before making

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-27 Thread Ping Cheng
On Mon, Sep 26, 2011 at 11:46 PM, Peter Hutterer peter.hutte...@who-t.net wrote: TODO: * Add function for setting the status led * Add function for setting luminance make the status led a 2-value property, first one to set which led, second one to set the luminance. I would prefer we have

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-27 Thread Ping Cheng
On Tue, Sep 27, 2011 at 5:30 AM, Eduard Hasenleithner ehase...@gmail.com wrote: But this is not exactly what the touch ring was designed for. It was designed for things like zooming in/out, cycle layers in photoshop, change the brush size, etc. In order to avoid the need for multiple touch

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-27 Thread Ping Cheng
(c) 2004 Panagiotis Issaris panagiotis.issa...@mech.kuleuven.ac.be - * Copyright (c) 2002-2009 Ping Cheng pi...@wacom.com + * Copyright (c) 2002-2011 Ping Cheng pi...@wacom.com * * ChangeLog: * v0.1 (vp) - Initial release @@ -93,7 +93,7 @@ /* * Version Information

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-27 Thread Ping Cheng
On Tue, Sep 27, 2011 at 2:03 PM, Eduard Hasenleithner ehase...@gmail.com wrote: Yes, and no. Yes for the led to provide new app functions. No if you think we are going to report the LED through XInput valuators. Due to backward compatibility, we will not report LED as a new axis. It will only

Re: [Linuxwacom-devel] [PATCH] Backport of Intuos4 LED and OLED control

2011-09-27 Thread Ping Cheng
On Mon, Sep 26, 2011 at 12:34 PM, Eduard Hasenleithner edu...@hasenleithner.at wrote: The Intous4 LED and OLED control patch has been accepted into the linux-input tree, and is scheduled for inclusion into linux-3.2. This is a backport of said patch into the wacom-input tree in order to

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-26 Thread Ping Cheng
files * Add ability for more sophisticated text layout * Add support for non TrueColor mode X Server Signed-off-by: Eduard Hasenleithner edu...@hasenleithner.at Acked-by: Ping Cheng pingli...@gmail.com Ping ---  include/wacom-properties.h |    7 ++  man/xsetwacom.man          |    4

Re: [Linuxwacom-devel] [PATCH] First version of Button Image setting

2011-09-26 Thread Ping Cheng
On Mon, Sep 26, 2011 at 4:04 PM, Eduard Hasenleithner ehase...@gmail.com wrote: Hi Ping Thanks for the ACK. 2011/9/27 Ping Cheng pingli...@gmail.com: On Sun, Sep 25, 2011 at 1:23 PM, Eduard Hasenleithner edu...@hasenleithner.at wrote: TODO: * Add function for setting the status led I am

Re: [Linuxwacom-devel] [v2]wacom_wac.c: Add the D5

2011-09-20 Thread Ping Cheng
On Mon, Sep 19, 2011 at 8:28 PM, Favux ... favux...@gmail.com wrote: Patch to add the Bamboo Pen Medium CTL-660/K (D5) to input-wacom.  Stylus with two side buttons (rocker switch). v. 2 has the D5 resolution for wacom_wac.c in the 2.6.36 folder as per Chris. Both this one and the next one

Re: [Linuxwacom-devel] wacom_wac.c: Add the D5

2011-09-09 Thread Ping Cheng
On Fri, Sep 9, 2011 at 11:27 AM, Favux ... favux...@gmail.com wrote: OK, I'll do it that way and see if Ping minds. If you are talking about adding res to input-wacom/2.6.36, I do not mind. In fact, I am grateful for your contributions to linux-wacom and linux-input. Any effort to bring the two

Re: [Linuxwacom-devel] [PATCH] Sanitize condition to check for complex gestures.

2011-08-23 Thread Ping Cheng
Acked-by: Ping Cheng pingli...@gmail.com Ping On Mon, Aug 22, 2011 at 8:50 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- no functional changes, but at least it's readable now. src/wcmTouchFilter.c | 25

Re: [Linuxwacom-devel] [PATCH] man: clarify which way the rotation goes

2011-08-23 Thread Ping Cheng
-t.net Acked-by: Ping Cheng pingli...@gmail.com with comments inline. Ping --- I've taken the easy way out, simply stating that it's the tablet area that is rotated. Going a different direction than GNOME would be too painful, especially since at the same time we'd still have to support

Re: [Linuxwacom-devel] RFC: how to report a new value to XInput

2011-08-19 Thread Ping Cheng
On Thu, Aug 18, 2011 at 9:40 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Wed, Aug 17, 2011 at 08:26:26AM -0700, Ping Cheng wrote: On Wed, Aug 17, 2011 at 12:02 AM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Aug 16, 2011 at 11:48:51PM -0700, Ping Cheng wrote: I

Re: [Linuxwacom-devel] smooth scrolling server plans - input needed

2011-08-18 Thread Ping Cheng
On Thu, Aug 18, 2011 at 3:04 PM, Peter Hutterer peter.hutte...@who-t.netwrote: There are two cases here, I think. 1. Users want to map those wheels/strips to a predefined events, such as keystrokes. We do not need to post the actual values, i.e., no valuators are reported. Just emit

Re: [Linuxwacom-devel] smooth scrolling server plans - input needed

2011-08-18 Thread Ping Cheng
On Thu, Aug 18, 2011 at 3:40 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Not sure how the app developers and end users will take on this new feature. afaik, there is already GTK3 work going on to integrate this. I don't worry about the future. It's the current and past apps that I

Re: [Linuxwacom-devel] RFC: how to report a new value to XInput

2011-08-17 Thread Ping Cheng
On Tue, Aug 16, 2011 at 11:20 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Aug 16, 2011 at 04:02:15PM -0700, Ping Cheng wrote: I need to report a new value to the user-land for pad. We have the forth (left strip), fifth (right strip), and sixth (abs wheel) axises in use

Re: [Linuxwacom-devel] smooth scrolling server plans - input needed

2011-08-17 Thread Ping Cheng
On Wed, Aug 17, 2011 at 12:53 AM, Peter Hutterer peter.hutte...@who-t.netwrote: In case you're not following the discussion on the xorg-devel list, a short summary from the thread here: http://lists.freedesktop.org/archives/xorg-devel/2011-August/024394.html and particulary the last one in

Re: [Linuxwacom-devel] [PATCH 3/4] man: document gesture-related options

2011-08-16 Thread Ping Cheng
On Tue, Aug 16, 2011 at 12:16 PM, Chris Bagwell ch...@cnpbagwell.comwrote: On Mon, Aug 15, 2011 at 10:03 PM, Peter Hutterer peter.hutte...@who-t.net wrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/wacom.man | 22 ++ 1 files changed, 22

[Linuxwacom-devel] RFC: how to report a new value to XInput

2011-08-16 Thread Ping Cheng
I need to report a new value to the user-land for pad. We have the forth (left strip), fifth (right strip), and sixth (abs wheel) axises in use. The first three are unused because they are (kinda) reserved for X, Y, and pressure although pad has none of them. Now, I need to report a new value. If

Re: [Linuxwacom-devel] [PATCH 3/4] man: document gesture-related options

2011-08-16 Thread Ping Cheng
On Tue, Aug 16, 2011 at 3:44 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Aug 16, 2011 at 03:34:42PM -0700, Ping Cheng wrote: On Tue, Aug 16, 2011 at 12:16 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Mon, Aug 15, 2011 at 10:03 PM, Peter Hutterer peter.hutte...@who

Re: [Linuxwacom-devel] [PATCH 1/4] Update comments for wheel and TwinView resolution properties

2011-08-15 Thread Ping Cheng
? Acked-by: Ping Cheng pingli...@gmail.com for the whole series. Ping -- uberSVN's rich system and user administration capabilities and model configuration take the hassle out of deploying and managing Subversion

Re: [Linuxwacom-devel] [PATCH 1/3] Print error to the log if the Type option is missing.

2011-08-01 Thread Ping Cheng
-by: Ping Cheng pinglinux@gmail,com for the series. Ping -- BlackBerryreg; DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps

Re: [Linuxwacom-devel] [PATCH 0/3] Gesture improvements on touchscreens

2011-07-05 Thread Ping Cheng
On Sat, Jul 2, 2011 at 6:03 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com Acked-by: Ping Cheng pingli...@gmail.com Ping This series of patches improves gestures on touchscreens; especially 2 finger gestures. It also allows Bamboo touchpads to fully disable

Re: [Linuxwacom-devel] [PATCH] xsetwacom: plug minor memory leak

2011-06-30 Thread Ping Cheng
On Thu, Jun 30, 2011 at 4:17 PM, Peter Hutterer peter.hutte...@who-t.netwrote: data is allocated, needs to be freed. No real impact since xsetwacom will exit anyway after this. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net Reviewed-by: Ping Cheng pingli...@gmail.com for both

Re: [Linuxwacom-devel] [PATCH v2 1/2] Remove unused Capacity logic on touch devices

2011-06-27 Thread Ping Cheng
. So, Acked-by: Ping Cheng pingli...@gmail.com. Ping The feature never fully worked and bits have slowing been removed. Remove remaining in one swoop. As apart of removing logic, now store ABS_PRESSURE values in the more appropriate pressure location so that it can eventually be exposed

Re: [Linuxwacom-devel] [PATCH v3 3/3] Set WCM_TPC when generic tablet is detect.

2011-06-26 Thread Ping Cheng
On Sun, Jun 26, 2011 at 5:15 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Thu, Jun 23, 2011 at 10:49:00PM -0700, Ping Cheng wrote: On Thu, Jun 23, 2011 at 8:06 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com This allows unknown touchscreens to work

Re: [Linuxwacom-devel] [PATCH 1/4] Remove unused Capacity logic on touch devices

2011-06-26 Thread Ping Cheng
On Sun, Jun 26, 2011 at 5:24 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Sat, Jun 25, 2011 at 01:05:49PM -0500, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com The feature never fully worked and bits have slowing been removed. Remove remaining in one swoop.

Re: [Linuxwacom-devel] [PATCH v3 3/3] Set WCM_TPC when generic tablet is detect.

2011-06-23 Thread Ping Cheng
with new hardware. Signed-off-by: Chris Bagwell ch...@cnpbagwell.com --- No change in behavior for this patch but had to change function prototype to allow using TabletSetTablet(). So removed previous Sorry, nitpicking again: s/TabletSetTablet/TabletSetFeature Reviewed-by. Ping Cheng pingli

Re: [Linuxwacom-devel] 50-wacom-conf issues

2011-06-21 Thread Ping Cheng
On Mon, Jun 20, 2011 at 10:38 PM, Favux ... favux...@gmail.com wrote: On Tue, Jun 21, 2011 at 12:25 AM, Ping Cheng pingli...@gmail.com wrote: On Mon, Jun 20, 2011 at 11:24 AM, Favux ... favux...@gmail.com wrote: Just a heads up. We just finished setting up unclepedro's Thinkpad X220t

Re: [Linuxwacom-devel] 50-wacom-conf issues

2011-06-21 Thread Ping Cheng
On Tue, Jun 21, 2011 at 7:25 AM, Ping Cheng pingli...@gmail.com wrote: On Mon, Jun 20, 2011 at 11:18 PM, Favux ... favux...@gmail.com wrote: Thank you Ping. Will do. WALTOP and ISD-V4 both. From Ethan Schoonover's X220t in Arch: http://sourceforge.net/mailarchive/forum.php?thread_name

Re: [Linuxwacom-devel] 50-wacom-conf issues

2011-06-21 Thread Ping Cheng
On Tue, Jun 21, 2011 at 4:29 PM, Favux ... favux...@gmail.com wrote: Hi Ping, That would make sense. The E6 would then have the same name type as the E3 and the others, i.e. Wacom ISDv4 E6. What kernel is that? I checked the Ubuntu 2.6.38 kernel source code. The latest 2.6.38 at

[Linuxwacom-devel] [PATCH] Silent compiler

2011-06-20 Thread Ping Cheng
Initialize rotation to ROTATE_NONE so compiler won't complain. Signed-off-by: Ping Cheng pingl...@gmail.com --- src/wcmValidateDevice.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/wcmValidateDevice.c b/src/wcmValidateDevice.c index 409a42f..e2598cb 100644

Re: [Linuxwacom-devel] 50-wacom-conf issues

2011-06-20 Thread Ping Cheng
On Mon, Jun 20, 2011 at 11:24 AM, Favux ... favux...@gmail.com wrote: Just a heads up. We just finished setting up unclepedro's Thinkpad X220t (first usb instead of ISDV4 Thinkpad) in Ubuntu 11.04 (Natty Narwhal) on Ubuntu forums. According to xinput list the kernel is exporting the two

Re: [Linuxwacom-devel] input-wacom_wacom_wac.c: Add 0xE6

2011-06-17 Thread Ping Cheng
Will be pushed soon. Thank you. Ping On Wed, May 25, 2011 at 8:02 AM, Favux ... favux...@gmail.com wrote: Adds the E6 2FGT tablet PC digitizer to input-wacom. Already in at least the 2.6.38 kernel. Dave --

Re: [Linuxwacom-devel] They call me Jonathan

2011-06-10 Thread Ping Cheng
Hi Jonathan, Welcome aboard! This is an open source project. All contributions are encouraged and greatly appreciated. So, feel free to share your thoughts and post your questions here. We have a wonderful team to enjoy your experience and bear your pain :). Ping On Wed, May 25, 2011 at 11:09

Re: [Linuxwacom-devel] Capacity Setting on ISDV4 Not working, screen overly capacitive

2011-06-09 Thread Ping Cheng
Hi Cedric, Capacity won't change anything since it is not truly implemented in the driver. We thought of using it. But we do not always get reliable capacity values. That's why we deferred the implementation. Please trace the problem in the log file (/var/log/Xorg.0.log) to see if there is

Re: [Linuxwacom-devel] Rotate parameter

2011-04-24 Thread Ping Cheng
On Wed, Apr 20, 2011 at 7:35 PM, Favux ... favux...@gmail.com wrote: While preparing to modify the Rotate parameter entries in the mediawiki to bring them up to date with 0.11.0 I tested the parameter. It is not tablet wide with a Bamboo Pen Touch. Rotating the stylus does rotate the

Re: [Linuxwacom-devel] Rotate parameter

2011-04-24 Thread Ping Cheng
On Thu, Apr 21, 2011 at 8:52 AM, Chris Bagwell ch...@cnpbagwell.com wrote: On Thu, Apr 21, 2011 at 1:14 AM, Peter Hutterer peter.hutte...@who-t.net wrote: On Wed, Apr 20, 2011 at 09:35:52PM -0500, Favux ... wrote: While preparing to modify the Rotate parameter entries in the mediawiki to

Re: [Linuxwacom-devel] [PATCH 4/4] man: Describe ToolSerials option

2011-04-20 Thread Ping Cheng
it is copy/pasted from the block above. So, I am fine to let the patch in for now. A follow up patchset is needed to complete this support. Thank you. Acked-by: Ping Cheng pingli...@gmail.com for the whole series. Ping +.TP 4 .B Option \fIThreshold\fP \fInumber\fP sets the pressure threshold used

Re: [Linuxwacom-devel] [PATCH 1/2] Retrieve resolution from the kernel whenever we can

2011-04-14 Thread Ping Cheng
On Wed, Apr 13, 2011 at 6:51 PM, Chris Bagwell ch...@cnpbagwell.com wrote: On Wed, Apr 13, 2011 at 5:43 PM, Ping Cheng pingli...@gmail.com wrote: The resolution table has been added to the kernel driver. Let use it when we can. Signed-off-by: Ping Cheng pingli...@gmail.com --- src

[Linuxwacom-devel] [PATCH v2] Retrieve resolution from the kernel whenever we can

2011-04-14 Thread Ping Cheng
The resolution table has been added to the kernel driver. Let's use it when we can. Signed-off-by: Ping Cheng pingli...@gmail.com --- Changes to v1: assign absinfo.resolution to wcmResolX instead of letting it fall to the WacomModelDesc table. src/wcmUSB.c | 22 -- 1 files

[Linuxwacom-devel] [PATCH 1/2] Retrieve resolution from the kernel whenever we can

2011-04-13 Thread Ping Cheng
The resolution table has been added to the kernel driver. Let use it when we can. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 1219530..2c2eb32 100644 --- a/src

[Linuxwacom-devel] [PATCH 2/2] Fake resolution for 9F and E2

2011-04-13 Thread Ping Cheng
9F and E2 are touch only devices, for which we need to retrieve the resolution from the kernel. So, the resolution defined in WacomModelDesc does not count for anything. However, to avoid future questions about the weird 394, align them with their cousins. Signed-off-by: Ping Cheng pingli

Re: [Linuxwacom-devel] [PATCH v2] Add support for Lenovo tablet ID 0xE6

2011-04-07 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Thank you, Timo and Manoj, for the patch and the testing. Ping On Thu, Apr 7, 2011 at 2:25 AM, Timo Aaltonen tjaal...@ubuntu.com wrote: Signed-off-by: Timo Aaltonen timo.aalto...@canonical.com Tested-by: Manoj Iyer manoj.i...@canonical.com

Re: [Linuxwacom-devel] [PATCH v2] Add support for Lenovo tablet ID 0xE6

2011-04-07 Thread Ping Cheng
On Thu, Apr 7, 2011 at 4:02 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Thu, Apr 07, 2011 at 12:25:32PM +0300, Timo Aaltonen wrote: Signed-off-by: Timo Aaltonen timo.aalto...@canonical.com Tested-by: Manoj Iyer manoj.i...@canonical.com --- src/wcmUSB.c |1 + 1 files

Re: [Linuxwacom-devel] [PATCH 0/4] Hover Click/TPCButton inversion

2011-04-04 Thread Ping Cheng
Acked-by: Ping Cheng pingli...@gmail.com for the series. Ping On Sun, Apr 3, 2011 at 10:51 PM, Peter Hutterer peter.hutte...@who-t.netwrote: the Hover Click property and TPCButton option do the same thing, but inverted. Hover Click indicates when hover click is enabled, but TCPButton means

Re: [Linuxwacom-devel] [PATCH 4/5] Don't rotate hotplugged devices.

2011-04-04 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com for the series except this patch. Please see my comments inline. Ping On Mon, Apr 4, 2011 at 8:44 PM, Peter Hutterer peter.hutte...@who-t.netwrote: We only rotate on a per-tablet basis, not per-tool. Don't accept rotation values on dependent devices

Re: [Linuxwacom-devel] [PATCH v2] fix filter issue on MT bamboos

2011-04-03 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Sun, Apr 3, 2011 at 6:49 AM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com Init tool device type is needed for all MT devices to do correct filtering; not just pen+MT tablets. Signed-off-by: Chris Bagwell ch

[Linuxwacom-devel] [PATCH 0/3 v2] Centralize arbitration

2011-04-03 Thread Ping Cheng
Patch 1 is unchanged. Resend it with the group to make sure it gets merged; Patches 2 and 3 are updated with Peter's comments. Ping Cheng (3): Check predefined serial number as early as we can Add IsPen to cover both IsStylus and IsEraser Centralize pen and touch arbitration src

[Linuxwacom-devel] [PATCH 1/3] Check predefined serial number as early as we can

2011-04-03 Thread Ping Cheng
Don't wait before we can post the events. Verify the serial number as soon as the information is accessible. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmCommon.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c

[Linuxwacom-devel] [PATCH 2/3 v2] Add IsPen to cover both IsStylus and IsEraser

2011-04-03 Thread Ping Cheng
It will be used more often when we need to compare touch events with pen events. Signed-off-by: Ping Cheng pingli...@gmail.com --- Changes in v2: use IsStylus and IsEraser instead of checking on the flags directly. src/wcmCommon.c |2 +- src/xf86WacomDefs.h |1 + 2 files changed, 2

[Linuxwacom-devel] [PATCH 3/3 v2] Centralize pen and touch arbitration

2011-04-03 Thread Ping Cheng
to distinguish them in the driver. Signed-off-by: Ping Cheng pingli...@gmail.com --- Changes in v2: unlink touch and pen when at least one of them is disabled; fixed an if-statement in ignoring touch when pen is in prox; and a few coding style suggestions made by Peter. src/wcmCommon.c | 32

Re: [Linuxwacom-devel] [PATCH 3/3] Centralize pen and touch arbitration

2011-04-03 Thread Ping Cheng
On Sun, Apr 3, 2011 at 6:35 PM, Peter Hutterer peter.hutte...@who-t.netwrote: What information can the user use for Uniq to associate the devices, which we do not have in the driver? Both devices have the same product ID and name. I only have one Bamboo, but the test code below gives

Re: [Linuxwacom-devel] [PATCH 3/3] Centralize pen and touch arbitration

2011-04-03 Thread Ping Cheng
On Sun, Apr 3, 2011 at 7:51 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Sun, Apr 03, 2011 at 07:23:34PM -0700, Ping Cheng wrote: On Sun, Apr 3, 2011 at 6:35 PM, Peter Hutterer peter.hutte...@who-t.net wrote: What information can the user use for Uniq to associate

Re: [Linuxwacom-devel] [PATCH] Update all tools rotation property when rotating one of them.

2011-04-03 Thread Ping Cheng
On Sun, Apr 3, 2011 at 5:39 PM, Peter Hutterer peter.hutte...@who-t.netwrote: All tools on the same tablet share the rotation value, so if one of them is rotated, all of them must be. Since the property value is stored in the server, we need to trigger it explicitly. Test case: $ xsetwacom

Re: [Linuxwacom-devel] [PATCH] allow more than 3 buttons

2011-04-02 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Sat, Apr 2, 2011 at 4:46 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com Made check be based on # of bits and not on # of bytes. Maybe there is a macro that already does this type math? Signed-off-by: Chris

Re: [Linuxwacom-devel] [PATCH] fix filter issue on MT bamboos

2011-04-02 Thread Ping Cheng
On Sat, Apr 2, 2011 at 4:53 PM, ch...@cnpbagwell.com wrote: From: Chris Bagwell ch...@cnpbagwell.com Init device type always is a good idea. Plus its required so that filtering works correctly for MT devices that do not have a pen+touch. PAD was the reason that I didn't call

Re: [Linuxwacom-devel] [PATCH 3/3] Centralize pen and touch arbitration

2011-04-01 Thread Ping Cheng
On Thu, Mar 31, 2011 at 10:57 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Thu, Mar 31, 2011 at 10:37:54PM -0700, Ping Cheng wrote: On Thu, Mar 31, 2011 at 4:43 PM, Peter Hutterer peter.hutte...@who-t.netwrote: /* FIXME: why strstr and not strcmp

Re: [Linuxwacom-devel] [PATCH] Add support for Lenovo tablet ID 0xE6

2011-04-01 Thread Ping Cheng
Hi Timo, Does E6 come with a stylus (pen)? If so, you need to change the resolution from 5 to 10. Thank you. Ping P.S., I don't have that system myself. On Fri, Apr 1, 2011 at 2:45 AM, Timo Aaltonen tjaal...@ubuntu.com wrote: From: Timo Aaltonen timo.aalto...@canonical.com

Re: [Linuxwacom-devel] [PATCH 3/3] Centralize pen and touch arbitration

2011-03-31 Thread Ping Cheng
On Wed, Mar 30, 2011 at 11:17 PM, Peter Hutterer peter.hutte...@who-t.netwrote: { - temppriv = (WacomDevicePtr) device-private; - tempcommon = temppriv-common; - - if

[Linuxwacom-devel] [PATCH 1/3] Check predefined serial number as early as we can

2011-03-30 Thread Ping Cheng
Don't wait before we can post the events. Verify the serial number as soon as the information is accessible. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmCommon.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c

[Linuxwacom-devel] [PATCH 2/3] Add IsPen to cover both IsStylus and IsEraser

2011-03-30 Thread Ping Cheng
It will be used more often when we need to compare touch events with pen events. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmCommon.c |2 +- src/xf86WacomDefs.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/wcmCommon.c b/src/wcmCommon.c index

Re: [Linuxwacom-devel] [PATCH 1/6] usb: count the number of buttons instead of hardcoding them.

2011-03-29 Thread Ping Cheng
I like the idea. Please see my comments inline. Ping On Mon, Mar 28, 2011 at 6:11 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmUSB.c | 35 ++- test/Makefile.am |4 ++- test/usb-tests.c | 97

Re: [Linuxwacom-devel] [PATCH 3/6] usb: swap two checks.

2011-03-29 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Mon, Mar 28, 2011 at 6:11 PM, Peter Hutterer peter.hutte...@who-t.netwrote: If the absbit isn't set, don't bother with the EV_ABS ioctl. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmUSB.c |6 +++--- 1 files

Re: [Linuxwacom-devel] [PATCH 4/6] usb: print invalid max value if we get one.

2011-03-29 Thread Ping Cheng
On Mon, Mar 28, 2011 at 6:11 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmUSB.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index aadafd0..e40a671 100644

Re: [Linuxwacom-devel] [PATCH 5/6] Remove discard_first field from DeviceStateRec

2011-03-29 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Mon, Mar 28, 2011 at 6:11 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Obsolete since the removal of old serial devices. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmCommon.c |4 ++-- src

Re: [Linuxwacom-devel] [PATCH 6/6] Remove STYLUS_DEVICE_ID and friends.

2011-03-29 Thread Ping Cheng
Hi Peter, There is a bit of history behind the IDs. Those *_DEVICE_IDs are from the kernel. For protocol 5 devices, there are different IDs for different styli and pucks. We reported them from the kernel through ABS_MISC. That's why we needed the device_id field to store them. To make the id

Re: [Linuxwacom-devel] [PATCH 1/6] usb: count the number of buttons instead of hardcoding them.

2011-03-29 Thread Ping Cheng
On Tue, Mar 29, 2011 at 3:06 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Mar 29, 2011 at 12:28:09PM -0700, Ping Cheng wrote: I like the idea. Please see my comments inline. Ping On Mon, Mar 28, 2011 at 6:11 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed

Re: [Linuxwacom-devel] [PATCH 6/6] Remove STYLUS_DEVICE_ID and friends.

2011-03-29 Thread Ping Cheng
On Tue, Mar 29, 2011 at 3:40 PM, Peter Hutterer peter.hutte...@who-t.netwrote: On Tue, Mar 29, 2011 at 01:24:33PM -0700, Ping Cheng wrote: Hi Peter, There is a bit of history behind the IDs. Those *_DEVICE_IDs are from the kernel. For protocol 5 devices, there are different IDs

Re: [Linuxwacom-devel] [PATCH] Replace manual array size with ARRAY_SIZE macro.

2011-03-29 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping P.S., sorry, forgot to reply all. On Tue, Mar 29, 2011 at 8:40 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmUSB.c |8 1 files changed, 4 insertions(+), 4

Re: [Linuxwacom-devel] [PATCH] Move npadkeys to fix comment.

2011-03-29 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Tue, Mar 29, 2011 at 8:41 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Fixing the comment would do too, but it really doesn't matter. Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/xf86WacomDefs.h |2 +- 1 files

Re: [Linuxwacom-devel] [PATCH v2] ISDV4: use libudev instead of manual syspath creation.

2011-03-28 Thread Ping Cheng
Acked-by: Ping Cheng pingli...@gmail.com Ping On Sun, Mar 27, 2011 at 11:10 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- Changes to v1: - check for libudev, not udev - link test case with libudev - use udev_device_get_syspath

[Linuxwacom-devel] [PATCH v2] Resolve the oldHwProx puzzle

2011-03-28 Thread Ping Cheng
the kernel. Reviewed-by: Chris Bagwell ch...@cnpbagwell.com Acked-by: Peter Hutterer peter.hutte...@who-t.net Signed-off-by: Ping Cheng pingli...@gmail.com --- Changes in v2: Check IsCursor before updating oldCursorHwProx; Update commit comments with model spefici info; Use wcmMaxDist (retrieved from

[Linuxwacom-devel] [PATCH 1/2] Resolve the oldHwProx puzzle

2011-03-24 Thread Ping Cheng
for the next round of relative cursor movement when tool first comes in prox. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmCommon.c | 24 ++-- src/wcmConfig.c |2 +- src/wcmUSB.c|4 src/xf86Wacom.c |6 -- src/xf86WacomDefs.h |2

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Ping Cheng
On Wed, Mar 23, 2011 at 3:36 AM, Eduard Hasenleithner ehase...@gmail.comwrote: 2011/3/23 Peter Hutterer peter.hutte...@who-t.net: On Tue, Mar 22, 2011 at 10:47:12PM +0100, Eduard Hasenleithner wrote: For accessing USB-FS, I already considered libusb, just to find out that it does not

Re: [Linuxwacom-devel] [draft-patch] OLED setting for xsetwacom

2011-03-23 Thread Ping Cheng
On Wed, Mar 23, 2011 at 12:55 PM, Eduard Hasenleithner ehase...@gmail.comwrote: Now I even tested the linuxwacom/src/2.6.30 driver on a fresh linux-2.6.38 from kernel.org. I had to do a few minor modifications to the driver source (ioctl has been renamed to unlocked_ioctl in usb_device and

[Linuxwacom-devel] [PATCH 1/3 v4] Support pen and MT on the same logical port

2011-03-23 Thread Ping Cheng
post MT valuators while pen events are posted. Some code refactoring is needed to add a new channel to store the pen data as well as the 2FGT data. Defering the code refactoring until we support XInput 2.1. Signed-off-by: Ping Cheng pingli...@gmail.com Reviewed-by: Peter Hutterer peter.hutte

[Linuxwacom-devel] [PATCH 2/3] Fix a copy/paste error in usbFindDeviceType comment

2011-03-23 Thread Ping Cheng
Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index 197d9fc..d58a740 100644 --- a/src/wcmUSB.c +++ b/src/wcmUSB.c @@ -945,8 +945,8 @@ static int usbIdToType(int id

[Linuxwacom-devel] [PATCH 3/3] PAD is always on PAD_CHANNEL

2011-03-23 Thread Ping Cheng
Don't assume the last tool was a pad, which confuses those tools that never receive a serial number. Keep PAD on the PAD_CHANNEL. Signed-off-by: Ping Cheng pingli...@gmail.com --- src/wcmUSB.c | 21 - 1 files changed, 4 insertions(+), 17 deletions(-) diff --git a/src

Re: [Linuxwacom-devel] [PATCH] Fix strip_keys index, copy/paste error.

2011-03-23 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Mon, Mar 21, 2011 at 9:04 PM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmCommon.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src

Re: [Linuxwacom-devel] Kernel driver for OLED support (was: OLED setting for xsetwacom)

2011-03-23 Thread Ping Cheng
On Wed, Mar 23, 2011 at 4:09 PM, Eduard Hasenleithner ehase...@gmail.comwrote: 2011/3/23 Ping Cheng pingli...@gmail.com: On Wed, Mar 23, 2011 at 12:55 PM, Eduard Hasenleithner ehase...@gmail.com wrote: Now I even tested the linuxwacom/src/2.6.30 driver on a fresh linux-2.6.38 from

Re: [Linuxwacom-devel] [PATCH] Silence compiler warning.

2011-03-23 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Thu, Mar 24, 2011 at 9:20 AM, Peter Hutterer peter.hutte...@who-t.netwrote: ./src/wcmCommon.c: In function 'sendCommonEvents': ./src/wcmCommon.c:382:2: warning: 'value' may be used uninitialized in this function [-Wuninitialized] ./src

Re: [Linuxwacom-devel] [PATCH 1/2] ISDV4: udpate a comment, we may return tablet id 0x90 on failure.

2011-03-23 Thread Ping Cheng
Reviewed-by: Ping Cheng pingli...@gmail.com Ping On Thu, Mar 24, 2011 at 9:40 AM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- src/wcmISDV4.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src

Re: [Linuxwacom-devel] [PATCH 2/2] ISDV4: use libudev instead of manual syspath creation.

2011-03-23 Thread Ping Cheng
On Thu, Mar 24, 2011 at 9:40 AM, Peter Hutterer peter.hutte...@who-t.netwrote: Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- configure.ac|3 ++ src/Makefile.am |2 +- src/wcmISDV4.c | 92 ++ 3 files changed,

<    1   2   3   4   5   6   7   8   >