On Sun, Mar 13, 2011 at 11:00 PM, Peter Hutterer
wrote:
> On Fri, Mar 11, 2011 at 04:02:56PM -0800, Jason Gerecke wrote:
>> I just noticed I was unable to map button presses to keys and after
>> some investigation (yay git bisect!) found the following commit
>> caused the bug:
>>
>> 22bc3028effbdc
On Fri, Mar 11, 2011 at 04:02:56PM -0800, Jason Gerecke wrote:
> I just noticed I was unable to map button presses to keys and after
> some investigation (yay git bisect!) found the following commit
> caused the bug:
>
> 22bc3028effbdc79d426c0b3dcf586734d4c7532
>
> It appears the original comment
On Fri, Mar 11, 2011 at 09:05:34PM -0600, Chris Bagwell wrote:
> I just acked a similar patch from Peter because his addition of nitems
> looked needed and I didn't have time to think in depth about earlier
> patch that caused issue.
>
> - if (unset_prop)
> + if (unset_prop || nitems >
I just acked a similar patch from Peter because his addition of nitems
looked needed and I didn't have time to think in depth about earlier
patch that caused issue.
- if (unset_prop)
+ if (unset_prop || nitems > 0)
XChangeDeviceProperty(dpy, dev, prop, XA_INTEGER, 32,
I just noticed I was unable to map button presses to keys and after
some investigation (yay git bisect!) found the following commit
caused the bug:
22bc3028effbdc79d426c0b3dcf586734d4c7532
It appears the original comment accompaning the argc check was wrong.
The original 'if' statement was "if (a
