Re: [Linuxwacom-devel] [PATCH 1/3] Fix double-free in wcmPreInitParseOptions

2012-09-25 Thread Peter Hutterer
On Tue, Sep 25, 2012 at 10:28:05AM -0700, Jason Gerecke wrote: > The 'tool' function here is set equal to 'priv->tool' earlier in > this function. If an error condition occurs, the tool can be freed > both here and in wcmFree (via wcmUninit). > > It should be safe to postpone this free() until wcm

[Linuxwacom-devel] [PATCH 1/3] Fix double-free in wcmPreInitParseOptions

2012-09-25 Thread Jason Gerecke
The 'tool' function here is set equal to 'priv->tool' earlier in this function. If an error condition occurs, the tool can be freed both here and in wcmFree (via wcmUninit). It should be safe to postpone this free() until wcmFree to be freed along with the rest of the memory allocated in wcmAlloca