Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-16 Thread Chris Bagwell
On Fri, Dec 14, 2012 at 6:39 PM, Ping Cheng wrote: > Hi Chris, > > Long time no "say". What's your opinion about the patchset? Do you care to > give an acked-by or nacked-by? Without your help, the bamboo PAD is broken > every so often these days > Sorry I haven't been able to contribute muc

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-14 Thread Ping Cheng
Hi Chris, Long time no "say". What's your opinion about the patchset? Do you care to give an acked-by or nacked-by? Without your help, the bamboo PAD is broken every so often these days Ping On Fri, Dec 14, 2012 at 2:58 PM, Chris Bagwell wrote: > > On Thu, Dec 13, 2012 at 9:37 PM, Peter Hu

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-14 Thread Chris Bagwell
On Thu, Dec 13, 2012 at 9:37 PM, Peter Hutterer wrote: > On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke >wrote: > > > > > It certainly doesn't hurt :) I think my biggest problem is that I never > > > really understood exactly when t

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-13 Thread Ping Cheng
On Thursday, December 13, 2012, Peter Hutterer wrote: > On Thu, Dec 13, 2012 at 10:08:07PM -0800, Ping Cheng wrote: > > On Thursday, December 13, 2012, Peter Hutterer wrote: > > > > > On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > > > > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gereck

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-13 Thread Peter Hutterer
On Thu, Dec 13, 2012 at 10:08:07PM -0800, Ping Cheng wrote: > On Thursday, December 13, 2012, Peter Hutterer wrote: > > > On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > > > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke > >wrote: > > > > > > > It certainly doesn't hurt :) I think

[Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-13 Thread Ping Cheng
On Thursday, December 13, 2012, Peter Hutterer wrote: > On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke >wrote: > > > > > It certainly doesn't hurt :) I think my biggest problem is that I never > > > really understood exactly when th

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-13 Thread Peter Hutterer
On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke wrote: > > > It certainly doesn't hurt :) I think my biggest problem is that I never > > really understood exactly when this code was required. > > > I bet you don't want to know ;-). Ch

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-12 Thread Ping Cheng
On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke wrote: > It certainly doesn't hurt :) I think my biggest problem is that I never > really understood exactly when this code was required. I bet you don't want to know ;-). Chris knows this chunk of code way better than me. It is a long story and it

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-12 Thread Jason Gerecke
It certainly doesn't hurt :) I think my biggest problem is that I never really understood exactly when this code was required. It makes sense that only MT using *TAP events would need it (or dual-track, but that's protocol 5), so I don't really see any problem given the testing you've done. Jason

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-12 Thread Ping Cheng
On Wed, Dec 12, 2012 at 9:45 AM, Jason Gerecke wrote: > Though I can't quite convince myself that this is safe, I don't see any > problems with it. > > Acked-By: Jason Gerecke > Will I say it is tested on older and new systems make it easier to convince you? Ping > Jason > > --- > When you'r

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-12 Thread Jason Gerecke
Though I can't quite convince myself that this is safe, I don't see any problems with it. Acked-By: Jason Gerecke Jason --- When you're rife with devastation / There's a simple explanation: You're a toymaker's creation / Trapped inside a crystal ball. And whichever way he tilts it / Know that

[Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-06 Thread Ping Cheng
We use true MT protocol for MT devices in kernel now. This code was introduced to deal with ABS_TOOL_*TAP events loss issue. It is uncessary any more. And its existence makes it hard to support generic PAD cleanly. Signed-off-by: Ping Cheng --- src/wcmUSB.c | 34 ++-