Re: [Linuxwacom-devel] [PATCH 1/9] Fix buttons must be set twice bug from d650b139

2011-03-30 Thread Jason Gerecke
On Tue, Mar 29, 2011 at 9:03 PM, Peter Hutterer peter.hutte...@who-t.net wrote: applied, but from a cursory glance I'm not sure why. In fact, I would have guessed the other way round. anyway, I've added a comment to avoid this in the future (at least until we find the reason why and fixed it).

Re: [Linuxwacom-devel] [PATCH 1/9] Fix buttons must be set twice bug from d650b139

2011-03-30 Thread Eduard Hasenleithner
Hi I join the discussion, because I have to deal with Array of Atom constructs also for my OLED Images. 2011/3/30 Peter Hutterer peter.hutte...@who-t.net: applied, but from a cursory glance I'm not sure why. In fact, I would have guessed the other way round. anyway, I've added a comment to

Re: [Linuxwacom-devel] [PATCH 1/9] Fix buttons must be set twice bug from d650b139

2011-03-29 Thread Peter Hutterer
On Tue, Mar 29, 2011 at 04:18:30PM -0700, Jason Gerecke wrote: *facepalm* I simply can't believe I didn't test this, but there's no denying the bug exists. Looks like the change to 'btnact_prop' *must* occur after the change to 'prop'. If it happens beforehand, then the driver appears to be