Re: [Linuxwacom-devel] [PATCH 3/3] Simplify boolean expression

2018-06-27 Thread Peter Hutterer
On Wed, Jun 27, 2018 at 02:24:43PM -0700, Jason Gerecke wrote: > The check here is logically equivalent to (a != b) but much harder to read. > Lets change that. > > V728 An excessive check can be simplified. The '(A && !B) || (!A && B)' > expression is equivalent to the 'bool(A) != bool(B)' expres

[Linuxwacom-devel] [PATCH 3/3] Simplify boolean expression

2018-06-27 Thread Jason Gerecke
The check here is logically equivalent to (a != b) but much harder to read. Lets change that. V728 An excessive check can be simplified. The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression. Signed-off-by: Jason Gerecke --- src/wcmUSB.c | 6 ++ 1 file