Re: [Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-11-07 Thread Peter Hutterer
On Wed, Nov 07, 2012 at 09:24:47AM +0100, Olivier Fourdan wrote: > > Hey Peter, > > Olivier Fourdan said the following on 11/07/2012 09:16 AM: > >>> All four patches merged, thank you. > >Thanks!:-) > > Err, I can't find them in git master: > http://linuxwacom.git.sourceforge.net/git/gitweb.cg

Re: [Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-11-07 Thread Olivier Fourdan
Hey Peter, Olivier Fourdan said the following on 11/07/2012 09:16 AM: >> > All four patches merged, thank you. > Thanks!:-) Err, I can't find them in git master: http://linuxwacom.git.sourceforge.net/git/gitweb.cgi?p=linuxwacom/libwacom;a=log Did you push to a different branch? Cheers, Olivi

Re: [Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-11-07 Thread Olivier Fourdan
Hey Peter, Peter Hutterer said the following on 11/07/2012 02:34 AM: > show-svg-image.c: In function ‘on_expose_cb’: > show-svg-image.c:238:18: warning: variable ‘expose_event’ set but not used > [-Wunused-but-set-variable] > looks like one can just drop it, that's what I did here after merging.

Re: [Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-11-06 Thread Peter Hutterer
On Tue, Nov 06, 2012 at 03:06:59PM +0100, Olivier Fourdan wrote: > Note: This updated patch also adds support for groups () in SVG. > > >From faed67e73057c6998fde65871075e9bfbcaa43af Mon Sep 17 00:00:00 2001 > From: Olivier Fourdan > Date: Mon, 29 Oct 2012 18:08:27 +0100 > Subject: [PATCH 3/4] t

[Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-11-06 Thread Olivier Fourdan
Note: This updated patch also adds support for groups () in SVG. >From faed67e73057c6998fde65871075e9bfbcaa43af Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Mon, 29 Oct 2012 18:08:27 +0100 Subject: [PATCH 3/4] tools: add tablet image viewer test: add image validation for tablet images.

[Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-11-06 Thread Olivier Fourdan
>From d711ef807a41636fd7682c810c5f2c03ab1a93dc Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Mon, 29 Oct 2012 18:25:24 +0100 Subject: [PATCH 4/4] data: add missing button direction test: check presence of direction for all known buttons Make it mandatory to provide the existing buttons

Re: [Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-10-31 Thread Peter Hutterer
On Wed, Oct 31, 2012 at 02:18:43PM +0100, Olivier Fourdan wrote: > Reimplement the SVG validation using libxml instead of librsvg. > > SVG validation should check for the ID and classes of each control > (to avoid the error Jason pointed out initially with one of the SVG > image), but librsvg is n

Re: [Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-10-31 Thread Olivier Fourdan
Reimplement the SVG validation using libxml instead of librsvg. SVG validation should check for the ID and classes of each control (to avoid the error Jason pointed out initially with one of the SVG image), but librsvg is not the best tool for this, so reimplemented the SVG validation using li

Re: [Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-10-30 Thread Olivier Fourdan
Argh, sorry, updated patch for image viewer/validity test Need to include "libwacom.h" and not otherwise the build will fail if libwacom is not already installed on the system (found out thanks to "make distcheck") >From 34e83110e10eeb01265627e8ff58a346495f9e5a Mon Sep 17 00:00:00 2001 From: O

[Linuxwacom-devel] [PATCH 3/4] tools: add tablet image viewer

2012-10-29 Thread Olivier Fourdan
>From 5ad76a56beacc3fdc7cbfcff4ae42fa3dfcac768 Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Mon, 29 Oct 2012 18:08:27 +0100 Subject: [PATCH 3/4] tools: add tablet image viewer test: add image validation for tablet images. Built is optional and depends on availability of GTK+-2.x and l