Re: [Linuxwacom-devel] [PATCH 4/4] Interpret threshold for button click relative to pressure curve.

2011-02-08 Thread Chris Bagwell
I've same question on 2024 value. Are you trying to account for THRESHOLD_TOLERANCE so button could be released at some point? I'm coming up with 16 for tolerance but 2024 is closer to 24. This comment really applies to patch #3. So my reviewed-by applies to patches 1, 2, and 4 and also to 3

Re: [Linuxwacom-devel] [PATCH 4/4] Interpret threshold for button click relative to pressure curve.

2011-02-08 Thread Ping Cheng
I have to understand why we need this patch before I can make a comment. I will share what I understood about the Threshold and PressureCurve first. Threshold is the minimal pressure before a button 1 click is posted. PressureCurve is used to soften (increase the pressure) or harden (decrease the

Re: [Linuxwacom-devel] [PATCH 4/4] Interpret threshold for button click relative to pressure curve.

2011-02-08 Thread Peter Hutterer
On Tue, Feb 08, 2011 at 08:29:01AM -0600, Chris Bagwell wrote: I've same question on 2024 value. Are you trying to account for THRESHOLD_TOLERANCE so button could be released at some point? I'm coming up with 16 for tolerance but 2024 is closer to 24. yeah, sorry. simple typo from being

Re: [Linuxwacom-devel] [PATCH 4/4] Interpret threshold for button click relative to pressure curve.

2011-02-08 Thread Peter Hutterer
On Tue, Feb 08, 2011 at 12:16:12PM -0800, Ping Cheng wrote: I have to understand why we need this patch before I can make a comment. I will share what I understood about the Threshold and PressureCurve first. Threshold is the minimal pressure before a button 1 click is posted. PressureCurve

[Linuxwacom-devel] [PATCH 4/4] Interpret threshold for button click relative to pressure curve.

2011-02-07 Thread Peter Hutterer
Don't interpret the button press pressure threshold as an absolute number but as a relative one in relation to the pressure curve. Reported-by: Chris Bagwell ch...@cnpbagwell.com Signed-off-by: Peter Hutterer peter.hutte...@who-t.net --- man/wacom.man |4 ++-- src/wcmCommon.c |2 +- 2

Re: [Linuxwacom-devel] [PATCH 4/4] Interpret threshold for button click relative to pressure curve.

2011-02-07 Thread Jason Gerecke
Is [0..2024] really the normalized pressure range? Wouldn't [0..2048] be correct since its the range of the pressure curve mapping? (Also applies to patch 3/4 as well) Sorry about the dupe Peter... Looks like I missed the 'Reply All' button... Jason On Mon, Feb 7, 2011 at 9:06 PM, Peter