Re: [Linuxwacom-devel] [PATCH libwacom] tools: use stdout for printing, not stdin

2013-04-29 Thread Peter Hutterer
On Mon, Apr 29, 2013 at 12:10:28PM -0400, Joaquim Rocha wrote: > The patch looks good but although it looks as intended in the shell's output, > it's not really writing things in the expected order. > The issue is that you're using STDOUT_FILENO to print the devices' > configuration but you're pr

Re: [Linuxwacom-devel] [PATCH libwacom] tools: use stdout for printing, not stdin

2013-04-29 Thread Joaquim Rocha
Hi Ping, - Original Message - From: "Ping Cheng" To: "Joaquim Rocha" Cc: "linuxwacom-devel" Sent: Monday, April 29, 2013 6:39:04 PM Subject: Re: [Linuxwacom-devel] [PATCH libwacom] tools: use stdout for printing, not stdin Glad to see more experts chime

Re: [Linuxwacom-devel] [PATCH libwacom] tools: use stdout for printing, not stdin

2013-04-29 Thread Ping Cheng
Glad to see more experts chime in. Thank you for your support, on behave of the project ;-). Can we count your comments as a tested-by as well? Ping On Mon, Apr 29, 2013 at 9:10 AM, Joaquim Rocha wrote: > The patch looks good but although it looks as intended in the shell's > output, it's not

Re: [Linuxwacom-devel] [PATCH libwacom] tools: use stdout for printing, not stdin

2013-04-29 Thread Joaquim Rocha
The patch looks good but although it looks as intended in the shell's output, it's not really writing things in the expected order. The issue is that you're using STDOUT_FILENO to print the devices' configuration but you're printing the separator (''...) to stdout and although this would be

[Linuxwacom-devel] [PATCH libwacom] tools: use stdout for printing, not stdin

2013-04-25 Thread Peter Hutterer
Signed-off-by: Peter Hutterer Reported-by: Joaquim Rocha --- oops. tools/list-devices.c | 3 ++- tools/list-local-devices.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/list-devices.c b/tools/list-devices.c index 4a96434..79d13e8 100644 --- a/tools/list-de