Re: [Linuxwacom-devel] [PATCH v2] First version of Button Image setting

2011-09-29 Thread Eduard Hasenleithner
2011/9/29 Peter Hutterer : > On Wed, Sep 28, 2011 at 11:29:39PM +0200, Eduard Hasenleithner wrote: >> Here is some further thought about the pixmap handling. What I somehow >> dislike is the "dirty" handling of pixmaps when the client is closed. >> How about pre-allocating the pixmaps at driver sta

Re: [Linuxwacom-devel] [PATCH v2] First version of Button Image setting

2011-09-28 Thread Peter Hutterer
On Wed, Sep 28, 2011 at 11:29:39PM +0200, Eduard Hasenleithner wrote: > Here is some further thought about the pixmap handling. What I somehow > dislike is the "dirty" handling of pixmaps when the client is closed. > How about pre-allocating the pixmaps at driver startup: > > void wcmLedInitPixmap

Re: [Linuxwacom-devel] [PATCH v2] First version of Button Image setting

2011-09-28 Thread Eduard Hasenleithner
Here is some further thought about the pixmap handling. What I somehow dislike is the "dirty" handling of pixmaps when the client is closed. How about pre-allocating the pixmaps at driver startup: void wcmLedInitPixmap(WacomDevicePtr priv, int *values, int count) { int i; ScreenPtr

Re: [Linuxwacom-devel] [PATCH v2] First version of Button Image setting

2011-09-27 Thread Eduard Hasenleithner
Hi This is v2 of the patch. The xsetwacom side of the patch is considered only for demonstration/testing purposes. I want to deal with that side when the x11 input driver is stabilized. For the x11 input driver part, we still need to continue the discussion on pixmap handling. Thanks, Eduard --

[Linuxwacom-devel] [PATCH v2] First version of Button Image setting

2011-09-27 Thread Eduard Hasenleithner
Linux kernels starting with version number 3.2 are supposed to have the LED extensions included in the wacom driver. This commit provides a first demonstration on how the new interface might be exposed by means of xsetwacom. The basic mechanism for passing the Button images between the xsetwacom t