Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-29 Thread Olivier Fourdan
Hi Peter, Peter Hutterer said the following on 11/28/2012 01:43 AM: [...] I have to admit, this confused me quite a bit during testing (reason was that I forgot to install the data files at first, so list-local-devices gave me wrong values). turns out integration_flags is the one read from

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-29 Thread Olivier Fourdan
Olivier Fourdan said the following on 11/29/2012 05:49 PM: [...] It should be the other way around. The kernel flags are used only if the integration flags are not set in the database. Sorry please ignore that sentence in my previous reply, it was left over from a first draft... meh :(

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-27 Thread Olivier Fourdan
Peter Hutterer said the following on 11/27/2012 12:27 AM: [...] + device-integration_flags = WACOM_DEVICE_INTEGRATED_NONE; + for (i = 0; string_list[i]; i++) { + for (n = 0; n G_N_ELEMENTS (integration_flags); n++) { +

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-27 Thread Peter Hutterer
On Tue, Nov 27, 2012 at 11:02:03AM +0100, Olivier Fourdan wrote: Peter Hutterer said the following on 11/27/2012 12:27 AM: [...] +device-integration_flags = WACOM_DEVICE_INTEGRATED_NONE; +for (i = 0; string_list[i]; i++) { +for (n = 0; n

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-26 Thread Olivier Fourdan
Olivier Fourdan said the following on 11/26/2012 08:44 AM: So how about making UNSET internal-only (in which case you can leave it as -1) but filter it to NONE before returning it to the client? Yeap, agreed, updated patch attached. Not USER is filtered out and NONE is returned to the

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-26 Thread Peter Hutterer
On Mon, Nov 26, 2012 at 08:44:56AM +0100, Olivier Fourdan wrote: Hi Peter, Peter Hutterer said the following on 11/26/2012 07:47 AM: [...] I'd like to get this API right before we make it public and have clients depend on it, with all the lag that entails (I know you already have something

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-25 Thread Peter Hutterer
On Fri, Nov 23, 2012 at 09:28:26AM +0100, Olivier Fourdan wrote: Hey Peter, Peter Hutterer said the following on 11/23/2012 12:21 AM: [...] two things: I'd like to see a test that screams bloody murder when the flag is in fact unset. presumably if we add new devices we known whether

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-23 Thread Olivier Fourdan
Hey Peter, Peter Hutterer said the following on 11/23/2012 12:21 AM: [...] two things: I'd like to see a test that screams bloody murder when the flag is in fact unset. presumably if we add new devices we known whether they're built-in and the test should complain if we forget to add this.

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-22 Thread Peter Hutterer
On Wed, Nov 07, 2012 at 01:22:11PM +0100, Olivier Fourdan wrote: From 15f93f5d3bd9f2aefd59a5087b2ce44a3c53403c Mon Sep 17 00:00:00 2001 From: Olivier Fourdan ofour...@redhat.com Date: Thu, 11 Oct 2012 12:04:45 +0200 Subject: [PATCH 3/3] lib: add IntegratedIn to device group to describe

[Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-07 Thread Olivier Fourdan
From 15f93f5d3bd9f2aefd59a5087b2ce44a3c53403c Mon Sep 17 00:00:00 2001 From: Olivier Fourdan ofour...@redhat.com Date: Thu, 11 Oct 2012 12:04:45 +0200 Subject: [PATCH 3/3] lib: add IntegratedIn to device group to describe integrated system devices and screen tablets. A bit field allows to