Re: [Linuxwacom-devel] [PATCH 2/3] Properly handle nulls in wcmCheckSource

2012-10-03 Thread Jason Gerecke
On Mon, Oct 1, 2012 at 6:55 PM, Peter Hutterer wrote: > On Fri, Sep 28, 2012 at 04:00:32PM -0700, Jason Gerecke wrote: >> Off-list -- >> >> In retrospect, it makes a lot more sense to just fix the xserver. I >> can't seem to get the git master to compile over here (some weird >> problem with lex)

Re: [Linuxwacom-devel] [PATCH 2/3] Properly handle nulls in wcmCheckSource

2012-10-01 Thread Peter Hutterer
On Fri, Sep 28, 2012 at 04:00:32PM -0700, Jason Gerecke wrote: > Off-list -- > > In retrospect, it makes a lot more sense to just fix the xserver. I > can't seem to get the git master to compile over here (some weird > problem with lex) and was wondering if you'd mind trying to compile it > with t

Re: [Linuxwacom-devel] [PATCH 2/3] Properly handle nulls in wcmCheckSource

2012-09-28 Thread Jason Gerecke
Erm. Whoops. :D Oh well -- it doesn't really matter who tests that patch as long as you've got a copy of the xserver repo to apply it against :) Jason --- When you're rife with devastation / There's a simple explanation: You're a toymaker's creation / Trapped inside a crystal ball. And whichever

Re: [Linuxwacom-devel] [PATCH 2/3] Properly handle nulls in wcmCheckSource

2012-09-28 Thread Jason Gerecke
Off-list -- In retrospect, it makes a lot more sense to just fix the xserver. I can't seem to get the git master to compile over here (some weird problem with lex) and was wondering if you'd mind trying to compile it with the attached patch for me. I'll send it off to xorg-devel if all goes well

Re: [Linuxwacom-devel] [PATCH 2/3] Properly handle nulls in wcmCheckSource

2012-09-25 Thread Peter Hutterer
On Tue, Sep 25, 2012 at 07:10:16PM -0700, Jason Gerecke wrote: > On Tue, Sep 25, 2012 at 6:30 PM, Peter Hutterer > wrote: > > On Tue, Sep 25, 2012 at 10:28:06AM -0700, Jason Gerecke wrote: > >> Commit cff344b1 modified the null-handling of wcmCheckSource, such > >> that the wrong result will be re

Re: [Linuxwacom-devel] [PATCH 2/3] Properly handle nulls in wcmCheckSource

2012-09-25 Thread Jason Gerecke
On Tue, Sep 25, 2012 at 6:30 PM, Peter Hutterer wrote: > On Tue, Sep 25, 2012 at 10:28:06AM -0700, Jason Gerecke wrote: >> Commit cff344b1 modified the null-handling of wcmCheckSource, such >> that the wrong result will be returned if either/both fsource and >> psource are null. >> >> Signed-off-

Re: [Linuxwacom-devel] [PATCH 2/3] Properly handle nulls in wcmCheckSource

2012-09-25 Thread Peter Hutterer
On Tue, Sep 25, 2012 at 10:28:06AM -0700, Jason Gerecke wrote: > Commit cff344b1 modified the null-handling of wcmCheckSource, such > that the wrong result will be returned if either/both fsource and > psource are null. > > Signed-off-by: Jason Gerecke > --- > src/wcmValidateDevice.c | 8 ++