Re: [Linuxwacom-devel] [PATCH libwacom] test: check for duplicate matching IDs

2013-01-31 Thread Peter Hutterer
On Thu, Jan 31, 2013 at 09:36:30AM +0100, Olivier Fourdan wrote: > Hey Peter, > > Peter Hutterer said the following on 01/31/2013 04:55 AM: > >On Wed, Jan 30, 2013 at 02:03:59PM +0100, Olivier Fourdan wrote: > >>[...] > >>So I think this adding this check here is not sufficient. Ideally, > >>this

Re: [Linuxwacom-devel] [PATCH libwacom] test: check for duplicate matching IDs

2013-01-31 Thread Olivier Fourdan
Hey Peter, Peter Hutterer said the following on 01/31/2013 04:55 AM: On Wed, Jan 30, 2013 at 02:03:59PM +0100, Olivier Fourdan wrote: [...] So I think this adding this check here is not sufficient. Ideally, this should be done when loading the database (also because people could add new definit

Re: [Linuxwacom-devel] [PATCH libwacom] test: check for duplicate matching IDs

2013-01-30 Thread Peter Hutterer
On Wed, Jan 30, 2013 at 02:03:59PM +0100, Olivier Fourdan wrote: > > Hey PEter, > > Peter Hutterer said the following on 01/30/2013 05:27 AM: > >No two device description files should match on the same ID. > > > >Since a tablet may be listed multiple times in the database if it has more > >than o

Re: [Linuxwacom-devel] [PATCH libwacom] test: check for duplicate matching IDs

2013-01-30 Thread Olivier Fourdan
Hey PEter, Peter Hutterer said the following on 01/30/2013 05:27 AM: > No two device description files should match on the same ID. > > Since a tablet may be listed multiple times in the database if it has more > than one match, we can't assume the matches are unique, we need to compare > the dev