Re: [Linuxwacom-devel] [PATCH 0/2] libwacom status LED helper functions

2012-10-03 Thread Olivier Fourdan
Hi Jason, Jason Gerecke said the following on 10/02/2012 06:43 PM: > [...] > NAK. I agree this should go in libwacom instead of GNOME, but am not > at all sold on the "ModeswitchLED" definition. From a database > normalization standpoint it winds up duplicating data, and could be > *significantly

[Linuxwacom-devel] [PATCH 0/2] libwacom status LED helper functions - take 2

2012-10-03 Thread Olivier Fourdan
Adds a new field "StatusLEDs" in the feature group to list the status LEDs present on the device in the same order as they appear in the sysfs control entries. Adds a WacomStatusLEDs enumeration type to identify known status LED types, Adds libwacom_get_status_leds() function to retrieve the numb

[Linuxwacom-devel] [PATCH 1/2] libwacom status LED helper functions - take 2

2012-10-03 Thread Olivier Fourdan
>From 1363b036b05e1a6d8cabd62bb4132c6157a8a8d5 Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Wed, 3 Oct 2012 15:23:37 +0200 Subject: [PATCH 1/2] data: update the database entry with status LED Adds a new field "StatusLEDs" in the feature group to list the status LEDs present on the devic

[Linuxwacom-devel] [PATCH 2/2] libwacom status LED helper functions - take 2

2012-10-03 Thread Olivier Fourdan
>From 8818b3c53ca63f5d2071ff3eabe4397a747f11aa Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Wed, 3 Oct 2012 15:31:24 +0200 Subject: [PATCH 2/2] lib: add helper functions to list available status LED Parses the newly added "StatusLEDs" field from the database entries, Adds a WacomStatus

[Linuxwacom-devel] [PATCH 2/2] libwacom status LED helper functions - take 2

2012-10-03 Thread Olivier Fourdan
Sorry, updated 2nd patch, meant to print "StatusLEDs=", not just "LEDs=" in libwacom_print_device_description() >From 0216649221b0b4776d322ae25e1b7dba8d07dd84 Mon Sep 17 00:00:00 2001 From: Olivier Fourdan Date: Wed, 3 Oct 2012 15:31:24 +0200 Subject: [PATCH 2/2] lib: add helper functions to list

Re: [Linuxwacom-devel] [PATCH 2/2] libwacom status LED helper functions - take 2

2012-10-03 Thread Jason Gerecke
For the set, Reviewed-by: Jason Gerecke Jason --- When you're rife with devastation / There's a simple explanation: You're a toymaker's creation / Trapped inside a crystal ball. And whichever way he tilts it / Know that we must be resilient We won't let them break our spirits / As we sing our s

Re: [Linuxwacom-devel] [PATCH 2/3] Properly handle nulls in wcmCheckSource

2012-10-03 Thread Jason Gerecke
On Mon, Oct 1, 2012 at 6:55 PM, Peter Hutterer wrote: > On Fri, Sep 28, 2012 at 04:00:32PM -0700, Jason Gerecke wrote: >> Off-list -- >> >> In retrospect, it makes a lot more sense to just fix the xserver. I >> can't seem to get the git master to compile over here (some weird >> problem with lex)