[Linuxwacom-devel] libwacom: Mode-switches and libwacom API

2012-12-13 Thread Olivier Fourdan
Hi all, It seems GNOME settings daemon was modelled after the I4, where you have multiple modes (4 on the I4) and a single mode-switch button. Pressing the mode-switch will cycle between the mode, 1, 2, 3, 4, 1, 2, etc. The hardware on the 24HD is different, there are 3 modes per ring, and 3

Re: [Linuxwacom-devel] libwacom: Mode-switches and libwacom API

2012-12-13 Thread Bastien Nocera
On Thu, 2012-12-13 at 11:52 +0100, Olivier Fourdan wrote: > Hi all, > > It seems GNOME settings daemon was modelled after the I4, where you > have multiple modes (4 on the I4) and a single mode-switch button. > The hardware on the 24HD is different Blame work, which bought me the wrong kind of

Re: [Linuxwacom-devel] libwacom: Mode-switches and libwacom API

2012-12-13 Thread Olivier Fourdan
Hi Bastien, Bastien Nocera said the following on 12/13/2012 12:12 PM: > [...] >> The hardware on the 24HD is different > Blame work, which bought me the wrong kind of hardware. Oh, sorry, I really did not mean to blame anything or anybody, sorry if my email sounded like that, it was not my inte

Re: [Linuxwacom-devel] libwacom: Mode-switches and libwacom API

2012-12-13 Thread Olivier Fourdan
Olivier Fourdan said the following on 12/13/2012 01:26 PM: > [...] > > What I am after is really a way to fix this, without introducing too > many ugly hacks in gnome-settings-daemon... Thus my question about > using the API in libwacom to detect the different use cases. Well, it proved easier tha

[Linuxwacom-devel] [PATCH 1/4 v2] Remove channel duplication code for generic devices

2012-12-13 Thread Ping Cheng
We use true MT protocol for MT devices in kernel now. This code was introduced to deal with ABS_TOOL_*TAP events loss issue. It is uncessary any more. And its existence makes it hard to support generic PAD cleanly. Signed-off-by: Ping Cheng Acked-by: Jason Gerecke --- v2: only patch 2/4 has code

[Linuxwacom-devel] [PATCH 2/4 v2] Initialize wcmBTNChannel in usbWcmInitPadState()

2012-12-13 Thread Ping Cheng
wcmBTNChannel is only used by generic PAD device. And it is statically assigned to PAD_CHANNEL. No need to reassign it for every packet. Signed-off-by: Ping Cheng Acked-by: Jason Gerecke --- src/wcmUSB.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/wcm

[Linuxwacom-devel] [PATCH 3/4 v2] Send generic PAD events before other events

2012-12-13 Thread Ping Cheng
If we wait until we finish other verifications, we could miss PAD events since they will be filtered out when there are no motion events sent simultaneously. Signed-off-by: Ping Cheng Acked-by: Jason Gerecke --- src/wcmUSB.c | 13 + 1 file changed, 13 insertions(+) diff --git a/s

[Linuxwacom-devel] [PATCH 4/4 v2] BTN_TOOL_FINGER is not for PAD if MT is supported

2012-12-13 Thread Ping Cheng
BTN_TOOL_FINGER indicates single touch/first finger if MT is enabled Signed-off-by: Ping Cheng Reviewed-by: Jason Gerecke --- src/wcmUSB.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/wcmUSB.c b/src/wcmUSB.c index ef19b51..1f1db35 100644 --- a/src/wcmU

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-13 Thread Peter Hutterer
On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke wrote: > > > It certainly doesn't hurt :) I think my biggest problem is that I never > > really understood exactly when this code was required. > > > I bet you don't want to know ;-). Ch

Re: [Linuxwacom-devel] [PATCH 1/4 v2] Remove channel duplication code for generic devices

2012-12-13 Thread Peter Hutterer
On Thu, Dec 13, 2012 at 12:16:52PM -0800, Ping Cheng wrote: > We use true MT protocol for MT devices in kernel now. This code > was introduced to deal with ABS_TOOL_*TAP events loss issue. It > is uncessary any more. And its existence makes it hard to support > generic PAD cleanly. > > Signed-off-

[Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-13 Thread Ping Cheng
On Thursday, December 13, 2012, Peter Hutterer wrote: > On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke >wrote: > > > > > It certainly doesn't hurt :) I think my biggest problem is that I never > > > really understood exactly when th

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-13 Thread Peter Hutterer
On Thu, Dec 13, 2012 at 10:08:07PM -0800, Ping Cheng wrote: > On Thursday, December 13, 2012, Peter Hutterer wrote: > > > On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > > > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gerecke > >wrote: > > > > > > > It certainly doesn't hurt :) I think

Re: [Linuxwacom-devel] [PATCH 1/4 v2] Remove channel duplication code for generic devices

2012-12-13 Thread Ping Cheng
On Thursday, December 13, 2012, Peter Hutterer wrote: > On Thu, Dec 13, 2012 at 12:16:52PM -0800, Ping Cheng wrote: > > We use true MT protocol for MT devices in kernel now. This code > > was introduced to deal with ABS_TOOL_*TAP events loss issue. It > > is uncessary any more. And its existence m

Re: [Linuxwacom-devel] [PATCH 1/4] Remove channel duplication code for generic devices

2012-12-13 Thread Ping Cheng
On Thursday, December 13, 2012, Peter Hutterer wrote: > On Thu, Dec 13, 2012 at 10:08:07PM -0800, Ping Cheng wrote: > > On Thursday, December 13, 2012, Peter Hutterer wrote: > > > > > On Wed, Dec 12, 2012 at 11:08:17AM -0800, Ping Cheng wrote: > > > > On Wed, Dec 12, 2012 at 10:54 AM, Jason Gereck