Re: [Linuxwacom-devel] Patch libwacom CTH-661/L

2013-01-29 Thread Olivier Fourdan
Hi, Pander said the following on 01/26/2013 03:38 PM: Please process the following patch as a result of this week's discussion. Nak. +[Device] +Name=Wacom Bamboo 4FG 6x8 SE NL +DeviceMatch=usb:056a:00db +Class=Bamboo +Width=13.27 +Height=8.78 Width/Height are the active area size, not the

Re: [Linuxwacom-devel] Patch libwacom CTH-661/L

2013-01-29 Thread Olivier Fourdan
Hey Bastien, Bastien Nocera said the following on 01/29/2013 09:56 AM: > On Tue, 2013-01-29 at 09:47 +0100, Olivier Fourdan wrote: > >> Does the attached patch works for you? To test, make sure you remove >> your added definition first... > The library should complain loudly if there are double

Re: [Linuxwacom-devel] Patch libwacom CTH-661/L

2013-01-29 Thread Bastien Nocera
On Tue, 2013-01-29 at 10:11 +0100, Olivier Fourdan wrote: > Hey Bastien, > > Bastien Nocera said the following on 01/29/2013 09:56 AM: > > On Tue, 2013-01-29 at 09:47 +0100, Olivier Fourdan wrote: > > > >> Does the attached patch works for you? To test, make sure you remove > >> your added defini

Re: [Linuxwacom-devel] Patch libwacom CTH-661/L

2013-01-29 Thread Bastien Nocera
On Tue, 2013-01-29 at 09:47 +0100, Olivier Fourdan wrote: > Does the attached patch works for you? To test, make sure you remove > your added definition first... The library should complain loudly if there are double definitions. > If that works, I'd prefer this > approach, unless Ping or Jas

Re: [Linuxwacom-devel] Patch libwacom CTH-661/L

2013-01-29 Thread Olivier Fourdan
Bastien Nocera said the following on 01/29/2013 10:13 AM: >> So I see no reason for the library to complain loudly. And fact is it >> passes "make check" just fine with this (I did try before posting my >> reply, though). > I meant the "make sure you remove your added definition first". Ah sorry,

Re: [Linuxwacom-devel] Patch libwacom CTH-661/L

2013-01-29 Thread Pander
On 2013-01-29 10:33, Olivier Fourdan wrote: > Bastien Nocera said the following on 01/29/2013 10:13 AM: >>> So I see no reason for the library to complain loudly. And fact is it >>> passes "make check" just fine with this (I did try before posting my >>> reply, though). >> I meant the "make sure yo

[Linuxwacom-devel] [PATCH libwacom] test: check for duplicate matching IDs

2013-01-29 Thread Peter Hutterer
No two device description files should match on the same ID. Since a tablet may be listed multiple times in the database if it has more than one match, we can't assume the matches are unique, we need to compare the device name. Build hashtable of {match string : device name}, then check for each