[Linuxwacom-devel] [PATCH 2/3] xsetwacom: Don't drop "const" when performing a cast

2017-11-28 Thread Jason Gerecke
GCC warns that we're droping the "const" attribute in one of our casts. Looking at the affected function, it is obvious that the cast is entirely unnecessary and can be dropped entirely. Signed-off-by: Jason Gerecke --- tools/xsetwacom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[Linuxwacom-devel] [PATCH 1/3] xsetwacom: Use explicit NULL for final element of 'parameters' array

2017-11-28 Thread Jason Gerecke
C does not strictly allow allow an empty initializer list `{}`, which can result in missing-field-initializers warnings from the compiler. All consumers of this array cycle through until they see a NULL name, so this commit replaces the empty initializer with { .name = NULL }. Signed-off-by: Jason

[Linuxwacom-devel] [PATCH 3/3] Remove no-longer-necessary "Wno-error" exceptions from Travis

2017-11-28 Thread Jason Gerecke
The missing-field-initializers and cast-qual warnings had to be excepted out from the Travis build since code in xsetwacom would trigger them. These issues have been resolved by the last two commits, allowing us to remove the exceptions. Signed-off-by: Jason Gerecke --- .travis.yml | 2 +- 1 fil

[Linuxwacom-devel] [PATCH] Build tools with AM_CFLAGS and its warnings

2017-11-28 Thread Jason Gerecke
The Makefile.am contained under the tools subdirectory makes use of an Automake feature that allows the definition of per-executable CFLAGS. These CFLAGS definitions do not automatically include the general-use AM_CFLAGS. This has resulted in these executables not being built with the intentended w

Re: [Linuxwacom-devel] [PATCH 1/3] xsetwacom: Use explicit NULL for final element of 'parameters' array

2017-11-28 Thread Ping Cheng
On Tuesday, November 28, 2017, Jason Gerecke wrote: > C does not strictly allow allow an empty initializer I like people to put efforts on cleaning up the code. It is a very good habit, which we all should have ;). Patches in this set, plus the individual one after this set, look good to me. O

Re: [Linuxwacom-devel] One by Wacom CTL-672

2017-11-28 Thread Peter Hutterer
On Wed, Nov 22, 2017 at 08:42:12AM +0200, T.Kovács család wrote: > Hi! > Thank You for the quick answer. > Unfortunately the xinput is not recognizing the device. Here is the output: > > xinput list > ⎡ Virtual core pointerid=2[master pointer (3)] > ⎜ ↳ Virtual core

Re: [Linuxwacom-devel] One by Wacom CTL-672

2017-11-28 Thread T . Kovács család
Thanks! I have the last version kernel installed (4.13.0-17-generic), but no success. It is possible to install this patch somehow, to help testing the device? Aron 2017-11-29 6:24 GMT+02:00 Peter Hutterer : > On Wed, Nov 22, 2017 at 08:42:12AM +0200, T.Kovács család wrote: > > Hi! > > Thank You