Re: [Linuxwacom-devel] libwacom: [PATCH] data: Add caption indicators to layouts

2012-11-29 Thread Olivier Fourdan
Favux ... said the following on 11/29/2012 07:08 AM: In drafting there is a technical name for lines connecting labels to the object they reference. Leaders Leaders or leader lines indicate the part or area of a drawing to which a number, note or other reference applies. They are solid lines

Re: [Linuxwacom-devel] libwacom: [PATCH] data: Add caption indicators to layouts

2012-11-29 Thread Olivier Fourdan
Hi Peter, Peter Hutterer said the following on 11/29/2012 06:34 AM: As Ping said, up/down on a ring is ambiguous. we use that terminology in the driver, but I do think we have the chance here to use CW/CCW instead. Right, but is is it guaranteed that {Abs,Rel}Wheel*UP as received by the

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-29 Thread Olivier Fourdan
Hi Peter, Peter Hutterer said the following on 11/28/2012 01:43 AM: [...] I have to admit, this confused me quite a bit during testing (reason was that I forgot to install the data files at first, so list-local-devices gave me wrong values). turns out integration_flags is the one read from

Re: [Linuxwacom-devel] libwacom: [PATCH 3/3] lib: add IntegratedIn to device group

2012-11-29 Thread Olivier Fourdan
Olivier Fourdan said the following on 11/29/2012 05:49 PM: [...] It should be the other way around. The kernel flags are used only if the integration flags are not set in the database. Sorry please ignore that sentence in my previous reply, it was left over from a first draft... meh :(

[Linuxwacom-devel] libwacom: [PATCH] lib: constify parameters in API

2012-11-29 Thread Olivier Fourdan
[...] Olivier Fourdan said the following on 11/29/2012 05:49 PM: sorry, I didn't spot this earlier, this should be const WacomDevice *device. (only noticed that when doing some printf testing on my device). Given that is_builtin, is_reversible, etc aren't const we should update all of them

Re: [Linuxwacom-devel] libwacom: [PATCH] data: Add caption indicators to layouts

2012-11-29 Thread Olivier Fourdan
Olivier Fourdan said the following on 11/29/2012 05:34 PM: Updated patch. Uses CW and CCW instead of Up and Down for touch rings, adds (optional) arrows to show rotation on touch rings, renamed indicator as leader as per previous reviews. Patch is slightly larger than the limit for the

Re: [Linuxwacom-devel] libwacom: [PATCH] data: Add caption indicators to layouts

2012-11-29 Thread Jason Gerecke
On Thu, Nov 29, 2012 at 12:45 AM, Olivier Fourdan ofour...@redhat.comwrote: Hi Peter, Peter Hutterer said the following on 11/29/2012 06:34 AM: As Ping said, up/down on a ring is ambiguous. we use that terminology in the driver, but I do think we have the chance here to use CW/CCW

Re: [Linuxwacom-devel] libwacom: [PATCH] data: Add caption indicators to layouts

2012-11-29 Thread Peter Hutterer
On Thu, Nov 29, 2012 at 05:34:28PM +0100, Olivier Fourdan wrote: Updated patch. Uses CW and CCW instead of Up and Down for touch rings, adds (optional) arrows to show rotation on touch rings, renamed indicator as leader as per previous reviews. ack to the leader part of it, but the other

Re: [Linuxwacom-devel] libwacom: [PATCH] data: Add caption indicators to layouts

2012-11-29 Thread Olivier Fourdan
Updated patch. Uses CW and CCW instead of Up and Down for touch rings, adds (optional) arrows to show rotation on touch rings, renamed indicator as leader as per previous reviews. From b877ff84ee108ce2115a40b4d7c8edfd47382b73 Mon Sep 17 00:00:00 2001 From: Olivier Fourdan ofour...@redhat.com