Re: [Linuxwacom-devel] [PATCH v2 2/3] Add support for Cintiq Pro 24/32

On Mon, Dec 18, 2017 at 04:53:59PM -0800, Jason Gerecke wrote: > Signed-off-by: Jason Gerecke > Reviewed-by: Peter Hutterer > --- > Changes from v1: > * Add resolution information to WacomModelDesc table as suggested by > Ping. Ping also

Re: [Linuxwacom-devel] [PATCH] Implement "pan" scrolling functionality

Oops, forgot to pass "-2" to git-format-patch. This patch depends on the "Pass current WacomDeviceState through to sendAction" patch which has just been sent separately. Jason --- Now instead of four in the eights place / you’ve got three, ‘Cause you added one / (That is to say, eight) to the

[Linuxwacom-devel] [PATCH 2/2] tools: Prevent use of invalid (negative) fd

If something goes wrong when a tool attempts to open a device, we print an error but then continue on as though nothing happended and provide the fd to both the ioctl() and close() functions. This commit ensures we don't actually try to use the fd. Coverity-id: 208168 Fixes: 3546d8ab1b ("tools:

[Linuxwacom-devel] [PATCH 1/2] Add Coverity integration to .travis.yml

Adds the ability to run a Coverity scan from Travis. Since there are a limited number of times per week that Coverity can be used, we only run it when Travis has the DO_COVERITY environment variable set to "YES". This can either be set manually through the Travis' interface, but will also be set

[Linuxwacom-devel] [PATCH] Pass current WacomDeviceState through to sendAction

This commit refactors the signature of the sendAction function to take a WacomDeviceState pointer. This change makes it easier to implement the following pan/scroll patch. Signed-off-by: Jason Gerecke --- src/wcmCommon.c | 42 +-

[Linuxwacom-devel] [PATCH] Implement "pan" scrolling functionality

When enabled through `xsetwacom set button pan`, this causes the driver to appear to "drag" scrollable window contents by emitting appropriate scroll events as the pen is dragged around. Signed-off-by: Jason Gerecke --- include/Xwacom.h | 1 +

[Linuxwacom-devel] [PATCH input-wacom 1/3] Add support for Cintiq Pro 24/32

Signed-off-by: Jason Gerecke --- 2.6.30/wacom_wac.c | 22 ++ 2.6.36/wacom_wac.c | 24 2.6.38/wacom_wac.c | 28 3.7/wacom_wac.c| 28 4 files changed, 102

[Linuxwacom-devel] [PATCH input-wacom 3/3] Backport support for the touch on/off switch

Several devices include a touch on/off switch, such as the Cintiq Pro 13/16/24/32, the 2nd-gen Intuos Pro, and even some Intuos devices. This commit extends the work done earlier to kernels older than 3.17. Ref: 235cf65108 ("backport: HID: wacom: support touch on/off softkey") Ref: 8681f6e506

[Linuxwacom-devel] [PATCH input-wacom 0/6] Misc. fixes

Just a collection of several miscellaneous fixes that Ping had acumulated while working on some other stuff. Jason Gerecke (6): Correct off-by-one error in DTH-1152 pressure range Fix size of WACOM_PKGLEN_DTH1152 Fix over-read of touch width and height values for MobileStudio Pro Rely on

[Linuxwacom-devel] [PATCH input-wacom 1/6] Correct off-by-one error in DTH-1152 pressure range

Fixes: 7d79680f21 ("backport: add support for DTH-1152 on 2.6.30, 2.6.36, 2.6.38, and 3.7") Signed-off-by: Ping Cheng Signed-off-by: Jason Gerecke --- 2.6.30/wacom_wac.c | 2 +- 2.6.36/wacom_wac.c | 2 +- 2.6.38/wacom_wac.c | 2 +- 3.7/wacom_wac.c

[Linuxwacom-devel] [PATCH v2 3/3] Add support for Cintiq 27QHDT

Signed-off-by: Jason Gerecke Reviewed-by: Peter Hutterer --- Changes from v1: * Added resolution information to WacomModelDesc table as requsted by Ping src/wcmUSB.c| 2 ++ src/wcmValidateDevice.c | 2 ++ 2 files changed, 4

[Linuxwacom-devel] [PATCH v2 1/3] conf: Add preprobe fdi config to workaround EV_SW issues in HAL

The HAL daemon used by RHEL6/CentOS6 does not play nicely with input devices that advertise unsupported EV_SW events. Devices with such an event will fail in the middle of the probe process, preventing the X server from being able to hotplug the device. The SW_MUTE_DEVICE event used by the Cintiq

[Linuxwacom-devel] [PATCH v2 2/3] Add support for Cintiq Pro 24/32

Signed-off-by: Jason Gerecke Reviewed-by: Peter Hutterer --- Changes from v1: * Add resolution information to WacomModelDesc table as suggested by Ping. Ping also noticed the touch resolution doesn't look sane (for this, or any other

[Linuxwacom-devel] [PATCH input-wacom 2/3] Backport support for most keys found on Cintiq Pro 13/16/24/32

Adding support for the KEY_CONTROLPANEL, KEY_ONSCREEN_KEYBOARD, and KEY_BUTTONCONFIG keys is fairly straightforward. Continue the backport started in 286d542658 all the way back to 2.6.30. Signed-off-by: Jason Gerecke --- 2.6.30/wacom_wac.c | 46

[Linuxwacom-devel] [PATCH input-wacom 6/6] Remove BTN_TOOL_RUBBER and BTN_TOOL_STYLUS2 from DTH1152 capabilities

Fixes: 7d79680f21 ("backport: add support for DTH-1152 on 2.6.30, 2.6.36, 2.6.38, and 3.7") Signed-off-by: Ping Cheng Signed-off-by: Jason Gerecke --- 2.6.30/wacom_wac.c | 8 +--- 2.6.36/wacom_wac.c | 8 +--- 2.6.38/wacom_wac.c | 8

[Linuxwacom-devel] [PATCH input-wacom 3/6] Fix over-read of touch width and height values for MobileStudio Pro

The touch width and height values are only one byte each on the MobileStudio Pro. This matches the same format as the DTH-1152, so merge the two cases together. Fixes: cd79aac597 ("backport: MobileStudio Pro to 3.7, 2.6.38, 2.6.36, 2.6.30") Signed-off-by: Ping Cheng

[Linuxwacom-devel] [PATCH input-wacom 4/6] Rely on 'wacom_setup_numbered_buttons' in 2.6.30 tree

The 'wacom_setup_input_capabilities' function was backported in commit ee0d2bd259 but apparently not all cases of explicitly-set button events were removed. This finishes the cleanup. Fixes: ee0d2bd259 ("backport: HID: wacom: Set button bits based on a new numbered_buttons") Signed-off-by: Ping

[Linuxwacom-devel] [PATCH input-wacom 5/6] Declare correct pen events for PENPARTNER devices

Backport the PTU and PENPARTNER cases of wacom_setup_input_capabilities from later trees back to 2.6.30 and 2.6.30. This fixes a bug which was fixed in the 2.6.38 tree by commit 23d098043e. It also gets the trees closer in sync with each other. Fixes: b62fb3f6cc ("Initial revision")

[Linuxwacom-devel] [PATCH input-wacom 2/6] Fix size of WACOM_PKGLEN_DTH1152

The plain report format for the DTH-1152 is only 12 bytes in length, not 17. Fixes: 7d79680f21 ("backport: add support for DTH-1152 on 2.6.30, 2.6.36, 2.6.38, and 3.7") Signed-off-by: Ping Cheng Signed-off-by: Jason Gerecke --- 2.6.30/wacom_wac.h

Re: [Linuxwacom-devel] [PATCH v2 1/3] conf: Add preprobe fdi config to workaround EV_SW issues in HAL

On Mon, Dec 18, 2017 at 04:53:58PM -0800, Jason Gerecke wrote: > The HAL daemon used by RHEL6/CentOS6 does not play nicely with input > devices that advertise unsupported EV_SW events. Devices with such > an event will fail in the middle of the probe process, preventing > the X server from being

Re: [Linuxwacom-devel] [PATCH] Pass current WacomDeviceState through to sendAction

On Mon, Dec 18, 2017 at 11:53:09AM -0800, Jason Gerecke wrote: > This commit refactors the signature of the sendAction function to take a > WacomDeviceState pointer. This change makes it easier to implement the > following pan/scroll patch. > > Signed-off-by: Jason Gerecke

Re: [Linuxwacom-devel] [PATCH 2/2] tools: Prevent use of invalid (negative) fd

On Mon, Dec 18, 2017 at 12:23:04PM -0800, Jason Gerecke wrote: > If something goes wrong when a tool attempts to open a device, we print > an error but then continue on as though nothing happended and provide > the fd to both the ioctl() and close() functions. This commit ensures > we don't

Re: [Linuxwacom-devel] [PATCH] Implement "pan" scrolling functionality

On Mon, Dec 18, 2017 at 11:46:21AM -0800, Jason Gerecke wrote: > When enabled through `xsetwacom set button pan`, this causes the > driver > to appear to "drag" scrollable window contents by emitting appropriate scroll > events as the pen is dragged around. > > Signed-off-by: Jason Gerecke