Re: [Lldb-commits] [PATCH] Submission request for the PlatformKalimba plugin

2014-07-16 Thread Matthew Gardiner
Todd/Abid, I just wanted to say thank you very much to you guys for getting this in for me. Having this Platform definition (and some earlier llvm/lldb triple+core changes) will really ease my pain with getting lldb to debug kalimbas. Kalimba is quite a complex architecture as it is, and I hav

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-07-16 Thread Kuba Brecka
Update addressing review comments. http://reviews.llvm.org/D4527 Files: include/sanitizer/asan_interface.h lib/asan/asan_debugging.cc lib/asan/asan_globals.cc lib/asan/asan_interface_internal.h lib/asan/asan_report.cc lib/asan/asan_report.h test/asan/TestCases/debug_locate.cc test

[Lldb-commits] [PATCH] Make lldb -P work on Windows

2014-07-16 Thread Zachary Turner
Hi tfiala, This fixes a few issues related to running the test suite on Windows. Most notably, it makes lldb -P return the expected python path so this can be used by the test script. http://reviews.llvm.org/D4548 Files: source/Host/common/Host.cpp source/Host/windows/Host.cpp test/dote

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-07-16 Thread Duncan P. N. Exon Smith
> On 2014-Jul-16, at 14:54, Kuba Brecka wrote: > > > Comment at: lib/asan/asan_report.cc:35 > @@ +34,3 @@ > +struct ReportData { > + bool already_happened = 0; > + uptr pc = 0; > > Alexey Samsonov wrote: >> I believe this wouldn't compile on Windows :-/ > I do

[Lldb-commits] [lldb] r213199 - Modify the EFI KDP debugging to not use any dynamic loader since it does manual dynamic loading itself via python modules.

2014-07-16 Thread Greg Clayton
Author: gclayton Date: Wed Jul 16 16:16:27 2014 New Revision: 213199 URL: http://llvm.org/viewvc/llvm-project?rev=213199&view=rev Log: Modify the EFI KDP debugging to not use any dynamic loader since it does manual dynamic loading itself via python modules. Also track down the required binary by

[Lldb-commits] [lldb] r213196 - ^C wasn't interrupting an expression during a long evaluation or deadlock.

2014-07-16 Thread Greg Clayton
Author: gclayton Date: Wed Jul 16 16:05:41 2014 New Revision: 213196 URL: http://llvm.org/viewvc/llvm-project?rev=213196&view=rev Log: ^C wasn't interrupting an expression during a long evaluation or deadlock. The problem was that we have an IOHandler thread that services the IOHandler stack. Th

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-07-16 Thread Kuba Brecka
Comment at: lib/asan/asan_report.cc:947 @@ +946,3 @@ + + ScopedInErrorReport in_report; + Kostya Serebryany wrote: > why did you move this here? Because ScopedInErrorReport's constructor does things where I'd like the report data to already be available. Namely,

[Lldb-commits] [lldb] r213194 - Fix some warnings in the Windows build.

2014-07-16 Thread Zachary Turner
Author: zturner Date: Wed Jul 16 15:28:24 2014 New Revision: 213194 URL: http://llvm.org/viewvc/llvm-project?rev=213194&view=rev Log: Fix some warnings in the Windows build. Modified: lldb/trunk/source/API/SBTarget.cpp lldb/trunk/source/Commands/CommandObjectThread.cpp lldb/trunk/sour

Re: [Lldb-commits] [PATCH] [compiler-rt] ASan debugging API for report info extraction and locating addresses

2014-07-16 Thread Kuba Brecka
Updated the patch to address review comments. Sent a separate refactor patch, http://reviews.llvm.org/D4545, this patch depends on it. http://reviews.llvm.org/D4527 Files: include/sanitizer/asan_interface.h lib/asan/asan_debugging.cc lib/asan/asan_globals.cc lib/asan/asan_interface_inter

Re: [Lldb-commits] [PATCH] Add Host::GetMaxThreadNameLength(), modify private state thread name

2014-07-16 Thread Todd Fiala
This went up here: svn commit Sendinginclude/lldb/Host/Host.h Sendingsource/Host/common/Host.cpp Sendingsource/Target/Process.cpp Transmitting file data ... Committed revision 213183. On Wed, Jul 16, 2014 at 10:09 AM, Todd Fiala wrote: > Please find attached an adjuste

[Lldb-commits] [lldb] r213183 - Add Host::MAX_THREAD_NAME_LENGTH constant.

2014-07-16 Thread Todd Fiala
Author: tfiala Date: Wed Jul 16 14:03:16 2014 New Revision: 213183 URL: http://llvm.org/viewvc/llvm-project?rev=213183&view=rev Log: Add Host::MAX_THREAD_NAME_LENGTH constant. This value gets set to a max uint32_t value when there is no known limit; otherwise, it is set to a value appropriate fo

[Lldb-commits] [lldb] r213181 - Fix build broken as a result of r213171.

2014-07-16 Thread Zachary Turner
Author: zturner Date: Wed Jul 16 13:53:18 2014 New Revision: 213181 URL: http://llvm.org/viewvc/llvm-project?rev=213181&view=rev Log: Fix build broken as a result of r213171. r213171 renames the 'clangRewriteCore' library to 'clangRewrite'. This change simply updates the makefiles to reference th

Re: [Lldb-commits] [PATCH] Add Host::GetMaxThreadNameLength(), modify private state thread name

2014-07-16 Thread Todd Fiala
Please find attached an adjusted patch. It uses a const static member variable initialized properly in place of a function call. Tested: Linux Ubuntu 14.04 x86_64, clang-3.5-built lldb, all tests pass. MacOSX 10.9.4, Xcode 6.0 Beta 3-built lldb, all tests pass. On Sat, Jul 12, 2014 at 3:21 PM,

[Lldb-commits] [lldb] r213166 - gdb-remote test noise suppression on MacOSX.

2014-07-16 Thread Todd Fiala
Author: tfiala Date: Wed Jul 16 11:15:42 2014 New Revision: 213166 URL: http://llvm.org/viewvc/llvm-project?rev=213166&view=rev Log: gdb-remote test noise suppression on MacOSX. This change adds a member to the base test case for gdb-remote that indicates whether a stub makes two X stop notificat

[Lldb-commits] [lldb] r213158 - Add kalimba as a platform.

2014-07-16 Thread Todd Fiala
Author: tfiala Date: Wed Jul 16 10:03:10 2014 New Revision: 213158 URL: http://llvm.org/viewvc/llvm-project?rev=213158&view=rev Log: Add kalimba as a platform. This change comprises of additions and some minor changes in order that "kalimba" is listed as a supported platform and that debugging an

Re: [Lldb-commits] [PATCH] Submission request for the PlatformKalimba plugin

2014-07-16 Thread Matthew Gardiner
Abid, Hafiz wrote: Sorry I meant source/CMakeLists.txt. -Original Message- From: lldb-commits-boun...@cs.uiuc.edu [mailto:lldb-commits- boun...@cs.uiuc.edu] On Behalf Of Abid, Hafiz Sent: 16 July 2014 13:34 To: Matthew Gardiner; lldb-commits@cs.uiuc.edu Subject: Re: [Lldb-commits] [PATC

Re: [Lldb-commits] [PATCH] Submission request for the PlatformKalimba plugin

2014-07-16 Thread Abid, Hafiz
Sorry I meant source/CMakeLists.txt. > -Original Message- > From: lldb-commits-boun...@cs.uiuc.edu [mailto:lldb-commits- > boun...@cs.uiuc.edu] On Behalf Of Abid, Hafiz > Sent: 16 July 2014 13:34 > To: Matthew Gardiner; lldb-commits@cs.uiuc.edu > Subject: Re: [Lldb-commits] [PATCH] Submiss

Re: [Lldb-commits] [PATCH] Submission request for the PlatformKalimba plugin

2014-07-16 Thread Abid, Hafiz
Hi Matthew, You also need to add lldbPluginPlatformKalimba to source/CMakefileList.txt. Otherwise cmake build will fail. After doing that your patch build OK for me on Linux with cmake. I have not tried autotools build though. I will commit your patch later if there are no other comments. Thank

[Lldb-commits] [PATCH] Submission request for the PlatformKalimba plugin

2014-07-16 Thread Matthew Gardiner
Could somebody please submit this attached patch for me? It comprises of additions and some minor changes in order that "kalimba" is listed as a supported platform and that debugging any kalimbas results in PlatformKalimba being associated with the target. They are as follows: * The PlatformKa