Re: [Lldb-commits] [PATCH] Make llgs build on Android. No functionality change.

2014-09-27 Thread Todd Fiala
svn commit Sendinginclude/lldb/Core/IOHandler.h Sendinginclude/lldb/Host/linux/Config.h Sendingsource/Core/IOHandler.cpp Sendingsource/Host/common/Host.cpp Sendingsource/Host/common/Socket.cpp Sendingsource/Host/linux/Host.cpp Sendingsource/Ho

[Lldb-commits] [lldb] r218568 - Enable llgs to build against experimental Android AOSP lldb/llvm/clang/compiler-rt repos.

2014-09-27 Thread Todd Fiala
Author: tfiala Date: Sat Sep 27 11:54:22 2014 New Revision: 218568 URL: http://llvm.org/viewvc/llvm-project?rev=218568&view=rev Log: Enable llgs to build against experimental Android AOSP lldb/llvm/clang/compiler-rt repos. See http://reviews.llvm.org/D5495 for more details. These are changes th

Re: [Lldb-commits] [PATCH] Make llgs build on Android. No functionality change.

2014-09-27 Thread Todd Fiala
LGTM. Much cleaner than first pass. Thanks, Tong, and thanks others for the constructive feedback! http://reviews.llvm.org/D5495 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Make llgs build on Android. No functionality change.

2014-09-27 Thread Todd Fiala
Hey Tong, So I was looking through the LLVM/Clang code at their LIBEDIT support (which I vaguely remember going in or being tweaked in the last half year or so). There is a HAVE_LIBEDIT flag that is defined if libedit is present. While it makes sense for us to be able to disable lldb's libedi

Re: [Lldb-commits] [PATCH] Make llgs build on Android. No functionality change.

2014-09-27 Thread Todd Fiala
Hey Tong, What are all the flags you assume are set when building this on the Android side? In addition to building it with stock normal flags on Linux, I want to use the same flag set. Looks like the define flag set includes at least: LLDB_DISABLE_LIBEDIT LLDB_DISABLE_PYTHON (and of course fr