On Darwin, if `LLDB_ENABLE_PYTHON_SCRIPTS_SWIG_API_GENERATION` is enabled, OS
detection was failing. This is fixed in scripts/utilsOsType.py:80.
Fixing that didn't help; scripts/buildSwigWrapperClasses.py was not finding
SWIG on Darwin. Instead of offloading finding SWIG in path to python, I
Author: jmolenda
Date: Mon Nov 17 05:43:37 2014
New Revision: 222127
URL: http://llvm.org/viewvc/llvm-project?rev=222127view=rev
Log:
Add a little sketch of a program that can extract unwind
information from the compact unwind section used on darwin
for exception handling, and dump that
Comment at: scripts/utilsOsType.py:74-81
@@ -73,10 +73,9 @@
strOS = sys.platform
if strOS == win32:
- eOSType = EnumOsType.Windows;
+ eOSType = EnumOsType.Windows
elif (strOS == linux) or (strOS == linux2):
-
Author: emaste
Date: Mon Nov 17 09:27:09 2014
New Revision: 222134
URL: http://llvm.org/viewvc/llvm-project?rev=222134view=rev
Log:
Add decorator for intermittently failing test on FreeBSD
This test has intermittently failed on FreeBSD for quite some time when
run as part of the full test suite.
Author: emaste
Date: Mon Nov 17 09:37:59 2014
New Revision: 222135
URL: http://llvm.org/viewvc/llvm-project?rev=222135view=rev
Log:
Whitespace cleanup and remove non-canonical headers
Modified:
lldb/trunk/scripts/utilsOsType.py
Modified: lldb/trunk/scripts/utilsOsType.py
URL:
Author: emaste
Date: Mon Nov 17 09:40:18 2014
New Revision: 222136
URL: http://llvm.org/viewvc/llvm-project?rev=222136view=rev
Log:
Fix Darwin and FreeBSD OS type detection
Obtained in part from http://reviews.llvm.org/D6290
Modified:
lldb/trunk/scripts/utilsOsType.py
Modified:
Overall seems like a good idea - one thing I don't understand is marked above.
This could be useful for FreeBSD as well, as the swig 2.0 package installs swig
as `swig2` (or similar), and so `swig` is not found in the `PATH`.
Comment at: scripts/CMakeLists.txt:12
@@ -12,1 +11,3
Author: zturner
Date: Mon Nov 17 11:46:43 2014
New Revision: 222148
URL: http://llvm.org/viewvc/llvm-project?rev=222148view=rev
Log:
[ProcessWindows] Create a TargetThreadWindows class.
This creates a TargetThreadWindows class and updates the thread
list of the Process with the main thread.
Comment at: scripts/CMakeLists.txt:12
@@ -12,1 +11,3 @@
+ DEPENDS ${SWIG_INPUTS}
+ COMMAND ${PYTHON_EXECUTABLE}
${CMAKE_CURRENT_SOURCE_DIR}/buildSwigWrapperClasses.py
--srcRoot=${LLDB_SOURCE_DIR} --targetDir=${CMAKE_CURRENT_BINARY_DIR}
I would just leave it out until we have an actual need for it. No reason
to add complexity (however small) that nobody needs.
http://reviews.llvm.org/D6290
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Comment at: scripts/CMakeLists.txt:12
@@ -12,1 +11,3 @@
+ DEPENDS ${SWIG_INPUTS}
+ COMMAND ${PYTHON_EXECUTABLE}
${CMAKE_CURRENT_SOURCE_DIR}/buildSwigWrapperClasses.py
--srcRoot=${LLDB_SOURCE_DIR} --targetDir=${CMAKE_CURRENT_BINARY_DIR}
Author: zturner
Date: Mon Nov 17 12:38:22 2014
New Revision: 222154
URL: http://llvm.org/viewvc/llvm-project?rev=222154view=rev
Log:
Fix buildSwigWrapperClasses.py after recent break.
A re-ordering of some enum values exposed a lingering bug where an
invalid key was indexing a dictionary.
On 17 November 2014 13:38, Zachary Turner ztur...@google.com wrote:
Author: zturner
Date: Mon Nov 17 12:38:22 2014
New Revision: 222154
URL: http://llvm.org/viewvc/llvm-project?rev=222154view=rev
Log:
Fix buildSwigWrapperClasses.py after recent break.
A re-ordering of some enum values
Author: gclayton
Date: Mon Nov 17 12:32:17 2014
New Revision: 222153
URL: http://llvm.org/viewvc/llvm-project?rev=222153view=rev
Log:
Fix some issue with running the test suite remotely on iOS.
- Added a new --apple-sdk flag that can be specified on Darwin only so the
correct cross compilers
Author: gclayton
Date: Mon Nov 17 12:40:27 2014
New Revision: 222156
URL: http://llvm.org/viewvc/llvm-project?rev=222156view=rev
Log:
Fixes for remote test suite execution of the lldb/test/lang directory.
Fixes include:
- Add a new lldbtest.TestBase function named
Author: kate
Date: Mon Nov 17 13:06:59 2014
New Revision: 222163
URL: http://llvm.org/viewvc/llvm-project?rev=222163view=rev
Log:
Complete rewrite of interactive editing support for single- and multi-line
input.
Improvements include:
* Use of libedit's wide character support, which is imperfect
Author: gclayton
Date: Mon Nov 17 13:39:20 2014
New Revision: 222167
URL: http://llvm.org/viewvc/llvm-project?rev=222167view=rev
Log:
Fixed more fallout from running the test suite remotely on iOS devices.
Fixed include:
- Change Platform::ResolveExecutable(...) to take a ModuleSpec instead of a
On 17 November 2014 14:07, Kate Stone katherine.st...@apple.com wrote:
Author: kate
Date: Mon Nov 17 13:06:59 2014
New Revision: 222163
URL: http://llvm.org/viewvc/llvm-project?rev=222163view=rev
Log:
Complete rewrite of interactive editing support for single- and multi-line
input.
FYI,
For future would you provide full context, i.e. diff -U99 if manually
uploading diffs?
This looks OK to me, but as I think we lack an appropriate interface in FreeBSD
right now I can't test, so hope one of the Linux or Darwin developers can
comment.
http://reviews.llvm.org/D6240
Some of my FreeBSD colleagues recommended trigger the failure by trying to
attach to a process that already has a debugger attached, as that's the common
cause of the failure we're handling here anyway.
Perhaps attach_denied/main.c can fork(), PT_ATTACH to the child, and then
return the
Author: zturner
Date: Mon Nov 17 15:31:18 2014
New Revision: 222177
URL: http://llvm.org/viewvc/llvm-project?rev=222177view=rev
Log:
Disable Editline on Windows.
Editline does not work correctly on Windows. This goes back at
least to r208369, and as a result r210105 was submitted to disable
Author: zturner
Date: Mon Nov 17 15:31:30 2014
New Revision: 222178
URL: http://llvm.org/viewvc/llvm-project?rev=222178view=rev
Log:
Move the thread logic around to fit better into LLDB's process model.
Previously we were directly updating the thread list and stopping
and restarting the process
Author: ovyalov
Date: Mon Nov 17 16:16:42 2014
New Revision: 222182
URL: http://llvm.org/viewvc/llvm-project?rev=222182view=rev
Log:
Fix broken Linux build after signature change of ResolveExecutable.
Modified:
lldb/trunk/source/Plugins/Platform/Linux/PlatformLinux.cpp
I see what the issue is. Next time can you add lldb-commits as a
subscriber? I'm not on this review, and neither is the public list.
On Mon Nov 17 2014 at 2:30:32 PM Kate Stone katherine_st...@apple.com
wrote:
The review was tracked as D5835 http://reviews.llvm.org/D5835.
Kate Stone
Will do! I sent out email with the link when the review started, but we can
certainly include lldb-commits for future reviews.
Kate Stone k8st...@apple.com mailto:k8st...@apple.com
Xcode Runtime Analysis Tools
On Nov 17, 2014, at 2:37 PM, Zachary Turner ztur...@google.com wrote:
I see
The review was tracked as D5835 http://reviews.llvm.org/D5835.
Kate Stone k8st...@apple.com mailto:k8st...@apple.com
Xcode Runtime Analysis Tools
On Nov 17, 2014, at 2:27 PM, Zachary Turner ztur...@google.com wrote:
Can you link me to the Phabricator issue? I vaguely recall commenting on
Author: ovyalov
Date: Mon Nov 17 16:42:28 2014
New Revision: 222184
URL: http://llvm.org/viewvc/llvm-project?rev=222184view=rev
Log:
Fix broken NativeProcessLinux.cpp after signature change of ResolveExecutable.
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp
That seems like a perfectly reasonable solution for now. There was indeed a
review sent out for this change, and there was quite a bit of community
involvement in making sure everything was in fine shape for Linux as well as
some speculative support for Windows editline implementations that
Author: echristo
Date: Mon Nov 17 16:55:13 2014
New Revision: 222186
URL: http://llvm.org/viewvc/llvm-project?rev=222186view=rev
Log:
Fix override/virtual warnings.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwin.h
Modified:
Author: enrico
Date: Mon Nov 17 17:06:20 2014
New Revision: 222189
URL: http://llvm.org/viewvc/llvm-project?rev=222189view=rev
Log:
Add APIs on SBFunction and SBCompileUnit to inquire about the language type
that the function/compile unit is defined in
Modified:
I'm sure I'm missing something obvious, but I don't understand what this
warning you are fixing is supposed to be telling you about. The inheritance
hierarchy is:
PlatformDarwin--PlatformPOSIX--Platform
Platform.h defines:
virtual Error
ResolveExecutable (const FileSpec
Author: enrico
Date: Mon Nov 17 17:14:11 2014
New Revision: 222190
URL: http://llvm.org/viewvc/llvm-project?rev=222190view=rev
Log:
Fix a problem where the StringPrinter could be mistaking an empty string for a
read error, and reporting spurious 'unable to read data' messages.
rdar://19007243
It's fine as virtual, but you're overriding a method and not marking it as
override. You don't need to write both down (you could, but it's a nop) as
override only works on virtual functions.
-eric
On Mon Nov 17 2014 at 3:07:27 PM jing...@apple.com wrote:
I'm sure I'm missing something
As I understand it, mixing override virtual is a recipe for confusion... We
currently use virtual, and not override. At some point we can talk about
switching over to using override everywhere, but I don't think we are at that
point.
So in this case your patch is incorrect, and the virtual
Author: gclayton
Date: Mon Nov 17 18:43:17 2014
New Revision: 07
URL: http://llvm.org/viewvc/llvm-project?rev=07view=rev
Log:
Have CommandObjectCommandsAddRegex inherit from IOHandlerDelegateMultiline so
it will not immediately terminate after the first regular expression in
command
Author: gclayton
Date: Mon Nov 17 18:39:31 2014
New Revision: 06
URL: http://llvm.org/viewvc/llvm-project?rev=06view=rev
Log:
Fixed a broken test suite test after recent editline merges.
The problem is that editline currently is trying to be smart when we paste
things into a terminal
override implies virtual and is a strict superset of virtual, so there's
nothing inherently wrong with mixing them. The advantage of override is
that it will cause the compiler to error if, for example, you delete a
virtual method from a base class (or change the signature), but forget to
make a
Override seems kind of gross to me. I can't use it on base class functions.
If I just use override I get
override.cpp:3:22: error: only virtual member functions can be marked 'override'
int DoSomething () override;
and if I put both I get:
override.cpp:3:15: error: 'DoSomething' marked
On Nov 17, 2014, at 5:54 PM, Zachary Turner ztur...@google.com wrote:
It's true you have to remember whether you're in the base class, but as you
deduced, that's pretty much the point. FWIW I switched all of ProcessWindows
over to using it just a day ago, because I found some dead code
Author: jmolenda
Date: Mon Nov 17 20:27:42 2014
New Revision: 14
URL: http://llvm.org/viewvc/llvm-project?rev=14view=rev
Log:
Read the LSDA and Personality Routine function address out of the
eh_frame data. These two pieces of information are used in the
process of exception handler
This patch fixes the behavior of -Q to match the --help:
Tells the debugger suppress output from commands provided in the -s, -S,
-O and -o commands.
Without this patch, the -Q option does the reverse of its intent, so that
specifying a command file with option -s would *not* echo any
On Mon Nov 17 2014 at 6:31:34 PM Zachary Turner ztur...@google.com wrote:
+lldb-dev
I'm actually ok just migrating towards override slowly (i.e. when you
touch a class that overrides some methods, add the override keyword), but
if people think it should be all or nothing (and if nobody else
On Mon, Nov 17, 2014 at 8:43 PM, Eric Christopher echri...@gmail.com
wrote:
On Mon Nov 17 2014 at 6:31:34 PM Zachary Turner ztur...@google.com
wrote:
+lldb-dev
I'm actually ok just migrating towards override slowly (i.e. when you
touch a class that overrides some methods, add the
Author: jmolenda
Date: Mon Nov 17 22:57:28 2014
New Revision: 21
URL: http://llvm.org/viewvc/llvm-project?rev=21view=rev
Log:
Make the mutex ivar in Unwind recursive so we don't have a thread
deadlocking when we have the base Unwind class and the HistoryUnwind
subclass both trying to
Author: jmolenda
Date: Mon Nov 17 23:43:11 2014
New Revision: 25
URL: http://llvm.org/viewvc/llvm-project?rev=25view=rev
Log:
Add documentation for the SBTarget::ReadInstructions and
SBTarget::GetInstructions APIs so it's a little clearer to
understand which should be used.
Author: jmolenda
Date: Mon Nov 17 23:57:42 2014
New Revision: 26
URL: http://llvm.org/viewvc/llvm-project?rev=26view=rev
Log:
Fix up the code in the FuncUnwinders class that
retrieves the personality routine addr and the
LSDA addr. Don't bother checking with the
non-call site unwind plan
46 matches
Mail list logo
