Re: [Lldb-commits] [PATCH] Unit tests to cover StringExtractor in advance of minor new functionality minor refactor

2014-12-01 Thread Greg Clayton
Looks good. http://reviews.llvm.org/D6344 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix several test failures on Linux/FreeBSD caused by compiler configuration and invalid environment

2014-12-01 Thread Greg Clayton
Note the duplicated code in both the TestSharedLib.py and TestSharedLibStrippedSymbols.py test files. This work should all be done in the registerSharedLibrariesWithTarget() function. You can pass an array of full shared library paths to the self.registerSharedLibrariesWithTarget(...) function

Re: [Lldb-commits] [PATCH] Fix several test failures on Linux/FreeBSD caused by compiler configuration and invalid environment

2014-12-01 Thread Greg Clayton
The remote install file spec only needs to be set for remote targets and you must use the lldb.remote_platform.GetWorkingDirectory() as the directory (since it represents the remote install location) instead of working_dir which is on the current host. To fix this you need to change: # We

Re: [Lldb-commits] [PATCH] Fix several test failures on Linux/FreeBSD caused by compiler configuration and invalid environment

2014-12-01 Thread Greg Clayton
Try this again with correct formatting: The remote install file spec only needs to be set for remote targets and you must use the lldb.remote_platform.GetWorkingDirectory() as the directory (since it represents the remote install location) instead of working_dir which is on the current host.

[Lldb-commits] [lldb] r223080 - StringExtractor unit tests

2014-12-01 Thread Vince Harron
Author: vharron Date: Mon Dec 1 16:10:15 2014 New Revision: 223080 URL: http://llvm.org/viewvc/llvm-project?rev=223080view=rev Log: StringExtractor unit tests Unit tests to cover StringExtractor in advance of minor new functionality minor refactor Added:

[Lldb-commits] [lldb] r223081 - Added StringExtractor::DecodeHexU8 GetHexBytesAvail

2014-12-01 Thread Vince Harron
Author: vharron Date: Mon Dec 1 16:19:33 2014 New Revision: 223081 URL: http://llvm.org/viewvc/llvm-project?rev=223081view=rev Log: Added StringExtractor::DecodeHexU8 GetHexBytesAvail DecodeHexU8 returns a decoded hex character pair, returns -1 if a valid hex pair is not available.

Re: [Lldb-commits] [lldb] r222163 - Complete rewrite of interactive editing support for single- and multi-line input.

2014-12-01 Thread Kate Stone
I appreciate the initiative in getting this fixed during the holiday break. Thanks! The editline commit pulled several entwined changes together to simplify integration. I’ve alerted Greg Clayton to the issue and fix so he can review for any alternative approaches that will keep the code

[Lldb-commits] [lldb] r223083 - lldb can deadlock when launched with an non-existing executable:

2014-12-01 Thread Greg Clayton
Author: gclayton Date: Mon Dec 1 16:41:27 2014 New Revision: 223083 URL: http://llvm.org/viewvc/llvm-project?rev=223083view=rev Log: lldb can deadlock when launched with an non-existing executable: % lldb /bin/nonono (lldb) target create /bin/nonono error: unable to find executable for

Re: [Lldb-commits] [PATCH] Fix several test failures on Linux/FreeBSD caused by compiler configuration and invalid environment

2014-12-01 Thread Greg Clayton
Looks good. http://reviews.llvm.org/D6392 ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] 5 minute timeout for tests

2014-12-01 Thread Zachary Turner
Note: At some point lldb-commits got lost from the Reply list. I'm putting it back just so that other interested parties aren't kept out of the loop. -- I'm kind of against this unless we know why the tests are failing, and maybe even then. Is this really a common enough thing that we need to

[Lldb-commits] [lldb] r223084 - The register keyword is deprecated in C++11, so clang complains strongly about swig generating register declarations. Abuse the preprocessor to define the keyword away

2014-12-01 Thread Enrico Granata
Author: enrico Date: Mon Dec 1 16:51:03 2014 New Revision: 223084 URL: http://llvm.org/viewvc/llvm-project?rev=223084view=rev Log: The register keyword is deprecated in C++11, so clang complains strongly about swig generating register declarations. Abuse the preprocessor to define the keyword

[Lldb-commits] [lldb] r223088 - Link test executables with LLD on Windows.

2014-12-01 Thread Zachary Turner
Author: zturner Date: Mon Dec 1 17:13:41 2014 New Revision: 223088 URL: http://llvm.org/viewvc/llvm-project?rev=223088view=rev Log: Link test executables with LLD on Windows. Clang generates DWARF debug info with section names longer than 8 characters. This is only supported by an extension to

[Lldb-commits] [lldb] r223087 - Only normalize FileSpec paths *after* resolving them.

2014-12-01 Thread Zachary Turner
Author: zturner Date: Mon Dec 1 17:13:32 2014 New Revision: 223087 URL: http://llvm.org/viewvc/llvm-project?rev=223087view=rev Log: Only normalize FileSpec paths *after* resolving them. Normalizing paths before resolving them can cause the path to become denormalized after resolution.

[Lldb-commits] [lldb] r223091 - Fix several test failures on Linux/FreeBSD caused by compiler configuration and invalid environment - make lldbtest.registerSharedLibrariesWithTarget to support multipl

2014-12-01 Thread Oleksiy Vyalov
Author: ovyalov Date: Mon Dec 1 17:21:18 2014 New Revision: 223091 URL: http://llvm.org/viewvc/llvm-project?rev=223091view=rev Log: Fix several test failures on Linux/FreeBSD caused by compiler configuration and invalid environment - make lldbtest.registerSharedLibrariesWithTarget to support

Re: [Lldb-commits] [PATCH] 5 minute timeout for tests

2014-12-01 Thread Zachary Turner
(You may still want to verify that there's no objections from other stakeholders whose platforms aren't supported by the timeout command though.) On Mon Dec 01 2014 at 4:16:04 PM Zachary Turner ztur...@google.com wrote: On Mon Dec 01 2014 at 4:05:25 PM Chaoren Lin chaor...@google.com wrote:

Re: [Lldb-commits] [PATCH] 5 minute timeout for tests

2014-12-01 Thread Zachary Turner
On Mon Dec 01 2014 at 4:05:25 PM Chaoren Lin chaor...@google.com wrote: timeout 5m %s %s/dotest.py %s -p %s %s will kill python after 5 minutes, but will it also kill any inferiors, and descendants of those? And what if you have A B C, and B dies, then you kill A's tree? As far as I can