Re: [Lldb-commits] [PATCH] Fix break-insert command on Windows.

On Linux, eclipse send the normal path like 37-break-insert -f /home/abidh/work/test.c:28 I agree with that check about ePathSyntaxWindows. We dont want to put penalty on other platforms. But looking at Normalize function, it seems that std::replace only gets called when we have syntax ==

Re: [Lldb-commits] [PATCH] Patch for LLDB demangler for demangling upon actual language

Changes requested in this review were taken into account in reworked patch - see http://reviews.llvm.org/D7409. REPOSITORY rL LLVM http://reviews.llvm.org/D7302 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___

Re: [Lldb-commits] [PATCH] Fix break-insert command on Windows.

I see. I don't have code in front of me, but can you check Args::SetCommandString? I thought it had code to convert \\ into \ On Wed, Feb 4, 2015 at 8:20 AM Hafiz Abid Qadeer abidh@gmail.com wrote: zturner, Command line case was just to show the problem. Real issue is that eclipse sends

Re: [Lldb-commits] [PATCH] Patch for LLDB demangler for demangling upon actual language

REPOSITORY rL LLVM http://reviews.llvm.org/D7302 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Patch for LLDB demangler for demangling upon actual language

In http://reviews.llvm.org/D7302#116129, @clayborg wrote: To make my comments clearer: 1 - Can't we tell the language by looking at the Mangled prefix? _Z = C++, $ = C++? 2 - Where do we need to know the language? I the JIT? If so we might need a new MangledWithLanguage class and use it

Re: [Lldb-commits] [PATCH] Add/update tests for lldb-mi

In http://reviews.llvm.org/D7410#118414, @abidh wrote: Some observations: 1. I think you should have posted the pieces that dont depend on other patches. In this way, they can be reviewed and committed without waiting on others. It doesn't depend on other patches. I meant that some tests

Re: [Lldb-commits] [PATCH] [lldb] Build lldb-mi with cmake on Linux only

Hi emaste Since this is fixed ages ago, could you close(or abandon) this for me? Really appreciate it. http://reviews.llvm.org/D3910 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] Fix break-insert command on Windows.

I think the proposed change with std::unique looks fine. But can you add a test alongside the patch? http://reviews.llvm.org/D7379 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] Fix cmake build by linking LLVMSupport

I think commit 226039 has fix this compilation error when BUILD_SHARED_LIBS=on. We can close it now. Comment at: tools/lldb-platform/CMakeLists.txt:9-14 @@ -8,3 +8,8 @@ +llvm_config(lldb-platform support) +if (LLVM_COMMON_DEPENDS) + add_dependencies(lldb-platform

Re: [Lldb-commits] [PATCH] Fix break-insert command on Windows.

Hmm. What does eclipse do on other platforms? Does it use // or /? I'm wondering if the logic should be behind an if (m_syntax == PathSyntaxWindows). Then just scan the string and remove double backslashes before normalizing On Wed, Feb 4, 2015 at 8:52 AM Hafiz Abid Qadeer abidh@gmail.com

Re: [Lldb-commits] [PATCH] Add/update tests for lldb-mi

Some observations: 1. I think you should have posted the pieces that dont depend on other patches. In this way, they can be reviewed and committed without waiting on others. 2. The start and end address of 0 is still there in data disassemble command. Probably we can use a function address as

Re: [Lldb-commits] [PATCH] Add/update tests for lldb-mi

REPOSITORY rL LLVM http://reviews.llvm.org/D7410 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] Avoid leaking log file descriptors into the inferior process.

Hi vharron, clayborg, This commit adds a new open flag File::eOpenOptionCloseOnExec (i.e., O_CLOEXEC), and adds it to the list of flags when opening log files (#ifndef windows). A regression test is included. http://reviews.llvm.org/D7412 Files: include/lldb/Host/File.h

Re: [Lldb-commits] [PATCH] Fix break-insert command on Windows.

That function may be relevent for command line. Lldb-mi calls SBTarget::BreakpointCreateByLocation (and similar) functions to set the breakpoint and Args::SetCommandString is never called. http://reviews.llvm.org/D7379 EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] Fix break-insert command on Windows.

zturner, Sure. I can add test. Just test 'b' command with full path? http://reviews.llvm.org/D7379 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] suppress compiler warning (mostly -Wsign-compare)

rebase to trunk http://reviews.llvm.org/D6271 Files: tools/debugserver/source/RNBRemote.cpp tools/debugserver/source/RNBRemote.h EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: tools/debugserver/source/RNBRemote.cpp

Re: [Lldb-commits] [PATCH] Avoid leaking log file descriptors into the inferior process.

Comment at: test/functionalities/avoids-fd-leak/TestFdLeak.py:19 @@ +18,3 @@ + +@expectedFailureWindows(The check for descriptor leakage needs to be implemented differently) +def test_fd_leak_log (self): I think the test should be marked as skipped

Re: [Lldb-commits] [PATCH] Add -exec-arguments command

So remove everything I listed and add m_lldbLaunchOptions to your CMICmnLLDBDebugSessionInfo object and populate it with all of the -exec calls, then use it to launch Comment at: include/lldb/API/SBArgs.h:1-83 @@ +1,83 @@ +//===-- SBArgs.h

Re: [Lldb-commits] [PATCH] Avoid leaking log file descriptors into the inferior process.

lgtm http://reviews.llvm.org/D7412 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Extend SBPlatform with capability to launch/terminate a process remotely. Integrate this change into test framework in order to spawn processes on a remote target.

lgtm http://reviews.llvm.org/D7263 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix warning about the use of mktemp and make platform agnostic by adding and using PipeBase::CreateWithUniqueName.

In http://reviews.llvm.org/D7348#118521, @zturner wrote: Hi Robert, by any chance did you actually try compiling this on Windows? The reason I ask is that it just occurred to me that this will now require linking in rpcrt4.lib, which I don't think happens by default. So this will cause

Re: [Lldb-commits] [PATCH] Extend SBPlatform with capability to launch/terminate a process remotely. Integrate this change into test framework in order to spawn processes on a remote target.

Changes inlined into code as comments. Comment at: include/lldb/API/SBPlatform.h:14-15 @@ -13,1 +13,4 @@ #include lldb/API/SBDefines.h +#include lldb/API/SBLaunchInfo.h +#include lldb/API/SBTarget.h + We shouldn't need these in the header file. Only a reference

Re: [Lldb-commits] [PATCH] Remove autogenerated makefiles after running tests

Please just check the Makefile files in, don't remove them. Why? Because when this test fails, I want to be able to go to each directory and type make and then be able to debug it. If there are no makefiles, you can only run it by running the inline test. This is why the Makefiles were left

Re: [Lldb-commits] [PATCH] Fix TestThreadSpecificBreakpoint with LLGS

LGTM but ovyalov must review. http://reviews.llvm.org/D7374 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add/update tests for lldb-mi

Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D7410 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r228171 - Fix broken windows build due to use of O_CLOEXEC.

Author: zturner Date: Wed Feb 4 13:11:48 2015 New Revision: 228171 URL: http://llvm.org/viewvc/llvm-project?rev=228171view=rev Log: Fix broken windows build due to use of O_CLOEXEC. Modified: lldb/trunk/source/Target/ProcessLaunchInfo.cpp Modified:

Re: [Lldb-commits] [PATCH] support for 'process launch -i' on remote targets

This is a hard one to do automatically. What if you have an input file already on the remote side you wanted to used without one being uploaded for you? If we do this by default we don't have the option of using one that is already on the remote host. I would prefer to not automate this and fix

[Lldb-commits] [lldb] r228210 - Remove changes I accidentally checked in with my previous commit.

Author: gclayton Date: Wed Feb 4 16:02:49 2015 New Revision: 228210 URL: http://llvm.org/viewvc/llvm-project?rev=228210view=rev Log: Remove changes I accidentally checked in with my previous commit. Modified: lldb/trunk/lldb.xcodeproj/xcshareddata/xcschemes/lldb-tool.xcscheme Modified:

Re: [Lldb-commits] [PATCH] suppress compiler warning (mostly -Wsign-compare)

Those new warnings from UnwindAssembly-x86.cpp are my fault. I'll fix them later today. http://reviews.llvm.org/D6271 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list

[Lldb-commits] [lldb] r228217 - Get test/types tests passing on remote targets

Author: vharron Date: Wed Feb 4 16:25:34 2015 New Revision: 228217 URL: http://llvm.org/viewvc/llvm-project?rev=228217view=rev Log: Get test/types tests passing on remote targets redirecting output to a path that will work well on host or target. copying file from output location to location on

[Lldb-commits] [PATCH] Add/update tests for lldb-mi

Hi abidh, zturner, clayborg, This patch includes following changes: * Fix comments and code style * Add new tests for many commands * Improve existing tests * Merge MiProgramArgsTestCase and MiExecTestCase * Improve runCmd of MiTestCaseBase: add exactly option * Improve test example (make it more

Re: [Lldb-commits] [PATCH] Add/update tests for lldb-mi

REPOSITORY rL LLVM http://reviews.llvm.org/D7410 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Add/update tests for lldb-mi

REPOSITORY rL LLVM http://reviews.llvm.org/D7410 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r228230 - Extend SBPlatform with capability to launch/terminate a process remotely. Integrate this change into test framework in order to spawn processes on a remote target.

Author: ovyalov Date: Wed Feb 4 17:19:15 2015 New Revision: 228230 URL: http://llvm.org/viewvc/llvm-project?rev=228230view=rev Log: Extend SBPlatform with capability to launch/terminate a process remotely. Integrate this change into test framework in order to spawn processes on a remote

Re: [Lldb-commits] [PATCH] Fix a missing *stopped notification in LLDB-MI after process launch -s in case of remote-macosx

REPOSITORY rL LLVM http://reviews.llvm.org/D7273 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r228261 - Don't wait for the dynamic loader to set a module as a dynamic link editor, figure it out through the ObjectFile.

Author: gclayton Date: Wed Feb 4 20:01:34 2015 New Revision: 228261 URL: http://llvm.org/viewvc/llvm-project?rev=228261view=rev Log: Don't wait for the dynamic loader to set a module as a dynamic link editor, figure it out through the ObjectFile. Background: dyld binaries often have extra

[Lldb-commits] [lldb] r228264 - Keep the user data for compile units up to date since we often create lldb_private::CompileUnit objects without creating the DWARFCompileUnit objects when we do DWARF i

Author: gclayton Date: Wed Feb 4 20:10:29 2015 New Revision: 228264 URL: http://llvm.org/viewvc/llvm-project?rev=228264view=rev Log: Keep the user data for compile units up to date since we often create lldb_private::CompileUnit objects without creating the DWARFCompileUnit objects when we do

[Lldb-commits] [lldb] r228278 - Implement initial Altivec support

Author: jhibbits Date: Thu Feb 5 01:12:01 2015 New Revision: 228278 URL: http://llvm.org/viewvc/llvm-project?rev=228278view=rev Log: Implement initial Altivec support Summary: This adds the register plumbing, as well as register reading in FreeBSD core dumps. Further work on the POSIX/FreeBSD

Re: [Lldb-commits] [PATCH] Add PowerPC FPR access to the process monitor

REPOSITORY rL LLVM http://reviews.llvm.org/D7040 Files: lldb/trunk/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_powerpc.cpp lldb/trunk/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.h EMAIL PREFERENCES

[Lldb-commits] [lldb] r228277 - Add PowerPC FPR access to the process monitor

Author: jhibbits Date: Thu Feb 5 01:10:11 2015 New Revision: 228277 URL: http://llvm.org/viewvc/llvm-project?rev=228277view=rev Log: Add PowerPC FPR access to the process monitor Summary: This adds reading and writing to the POSIX PowerPC ProcessMonitor. Reviewers: emaste Reviewed By: emaste

Re: [Lldb-commits] [PATCH] Implement initial Altivec support

REPOSITORY rL LLVM http://reviews.llvm.org/D7039 Files: lldb/trunk/source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp lldb/trunk/source/Plugins/ABI/SysV-ppc64/ABISysV_ppc64.cpp lldb/trunk/source/Plugins/Process/POSIX/RegisterContextPOSIXProcessMonitor_powerpc.cpp

[Lldb-commits] [lldb] r228134 - Have llgs tests output their traces into session dir

Author: labath Date: Wed Feb 4 04:48:29 2015 New Revision: 228134 URL: http://llvm.org/viewvc/llvm-project?rev=228134view=rev Log: Have llgs tests output their traces into session dir Summary: This reduces the bloat in the source tree and makes the tests more consistent. Reviewers: vharron,

Re: [Lldb-commits] [PATCH] Have llgs tests output their traces into session dir

REPOSITORY rL LLVM http://reviews.llvm.org/D7373 Files: lldb/trunk/test/tools/lldb-gdbserver/gdbremote_testcase.py Index: lldb/trunk/test/tools/lldb-gdbserver/gdbremote_testcase.py === ---

Re: [Lldb-commits] [PATCH] Add -exec-arguments command

Greg, I know that it takes a long your time but we didn't decide what need to do with this patch. If you tell me that process launch shouldn't work as I have described above then I can remove SBTarget::SetRunArguments, but I think it should. Sorry that I didn't provide complete information in

Re: [Lldb-commits] [PATCH] Fix a race condition in lldb-mi.

commit: http://llvm.org/viewvc/llvm-project?view=revisionrevision=228128 http://reviews.llvm.org/D7371 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] os.remove shouldn't fail, if file doesn't exist

ismailp, it was committed? http://reviews.llvm.org/D6362 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix break-insert command on Windows.

Hi Greg, Thanks for the review. I think I found the real problem now. When FileSpec::Normalize is given this path with \\ in it, it ends up changing it to //. But there are still 2 / in it. Before: F:\\work\\demos\\main.c After: F://work//demos//main.c This then fails comparison in

[Lldb-commits] [lldb] r228128 - Fix a race condition in lldb-mi.

Author: abidh Date: Wed Feb 4 03:59:23 2015 New Revision: 228128 URL: http://llvm.org/viewvc/llvm-project?rev=228128view=rev Log: Fix a race condition in lldb-mi. lldb-mi has 3 threads. 1. One that waits for user intput. 2. Another waits for 1st thread to get input command. 3. Waits for events

[Lldb-commits] [lldb] r228224 - Unbreak the cmake build by adding some new files

Author: rnk Date: Wed Feb 4 16:46:17 2015 New Revision: 228224 URL: http://llvm.org/viewvc/llvm-project?rev=228224view=rev Log: Unbreak the cmake build by adding some new files Modified: lldb/trunk/source/Core/CMakeLists.txt lldb/trunk/source/Interpreter/CMakeLists.txt Modified:

Re: [Lldb-commits] [PATCH] Add/update tests for lldb-mi

Fix remarks: - Improve MiEvaluateTestCase (add more test cases, remove -interpreter-exec) - Improve -data-disassemble test (replace 0x0 to real address) Can anyone commit it for me? http://reviews.llvm.org/D7410 Files: test/tools/lldb-mi/TestMiBreakpoint.py

Re: [Lldb-commits] [PATCH] Add/update tests for lldb-mi

REPOSITORY rL LLVM http://reviews.llvm.org/D7410 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits