Author: zturner
Date: Wed Feb 11 12:21:28 2015
New Revision: 228859
URL: http://llvm.org/viewvc/llvm-project?rev=228859view=rev
Log:
Make PipeWindows::CreateWithUniqueName() use GUIDs on Windows.
Patch by Adrian McCarthy
Differential Revision: http://reviews.llvm.org/D7509
Modified:
Changes requested inline.
Comment at: source/API/SBFileSpec.cpp:92-98
@@ -91,8 +91,9 @@
int
SBFileSpec::ResolvePath (const char *src_path, char *dst_path, size_t dst_len)
{
llvm::SmallString64 result(src_path);
lldb_private::FileSpec::Resolve (result);
size_t
Author: gclayton
Date: Wed Feb 11 13:16:38 2015
New Revision: 228867
URL: http://llvm.org/viewvc/llvm-project?rev=228867view=rev
Log:
Fixed SBModule::GetUUIDString() to not use a static character buffer.
Rules for returning const char * from functions in the public lldb::SB* API
are that you
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7545
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Looks good. I believe doing remote debugging all of the time is the best way to
go and what we should encourage people to use it.
We might also, in a separate patch, ask the platform for the GDB remote binary.
The default implementation would return lldb-gdbserver:
virtual Error
Enable dwarf test on non-mac platforms
http://reviews.llvm.org/D7550
Files:
scripts/Python/finish-swig-Python-LLDB.sh
scripts/Python/finishSwigPythonLLDB.py
test/functionalities/launch_with_glob/TestLaunchWithGlob.py
tools/CMakeLists.txt
tools/argdumper/CMakeLists.txt
EMAIL
On Feb 11, 2015, at 2:24 PM, Ilia K ki.s...@gmail.com wrote:
In http://reviews.llvm.org/D6965#121476, @clayborg wrote:
It would be nice to have lldb_private::Target have its own ProcessLaunchInfo
as a member variable and change all storage of settings (target.run-args,
target.arg0 etc)
In http://reviews.llvm.org/D7550#122016, @zturner wrote:
I was objecting to both things actually:
1. Disabled in the CMake build that Ilia ported
2. Test disabled on non mac.
We should be enabling tests in all platforms by default, and if it breaks
someone should be fixing the tests.
In http://reviews.llvm.org/D6965#121474, @clayborg wrote:
You could verify that you can set the args with settings set and then run
with your empty SBLaunchInfo and verify that you got the right args?
It doesn't work (test
MiInterpreterExecTestCase.test_lldbmi_settings_set_target_run_args
Hi zturner,
Bug 22410
http://reviews.llvm.org/D7572
Files:
include/lldb/Host/windows/windows.h
source/Plugins/Process/Windows/x86/RegisterContextWindows_x86.cpp
source/Plugins/Process/Windows/x86/RegisterContextWindows_x86.h
Index: include/lldb/Host/windows/windows.h
Comment at: include/lldb/Host/windows/windows.h:22-23
@@ -21,4 +21,2 @@
#undef CreateProcess
-#undef LoadImage
-#undef GetUserName
#undef far
What's this part for?
Comment at:
Keep lldb-platform.cpp and lldb-gdbserver.cpp separate but link and call into
them from lldb-server.cpp. Also merges changes from ToT.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7545
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
I've kept the two in separate cpp files with a new cpp file for lldb-server
which calls the main on one or the other.
REPOSITORY
rL LLVM
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp:493
@@ -492,3 +492,3 @@
// FIXME This looks an awful
Author: gclayton
Date: Wed Feb 11 18:34:25 2015
New Revision: 228892
URL: http://llvm.org/viewvc/llvm-project?rev=228892view=rev
Log:
Make a more complete fix for always supplying an execution context when getting
byte sizes from types.
There was a test in the test suite that was triggering the
It is part of the linker stage so each rebuild should produce an unique UUID.
Note, the MacOS X linker actually makes the UUID by checksumming the binary -
minus some obvious bits the linker knows to contain timestamps - so if you
rebuild the same sources with the same compiler compiler
It is part of the linker stage so each rebuild should produce an unique UUID.
Note, the MacOS X linker actually makes the UUID by checksumming the binary -
minus some obvious bits the linker knows to contain timestamps - so if you
rebuild the same sources with the same compiler compiler
Hi emaste,
Coverity warns that unsigned = 0 is always true, and k_first_gpr_powerpc
happens to be 0. Quiet Coverity by changing that comparison instead to a
static_assert(), in case things change in the future.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7576
Files:
I like your suggestion of showing the comment contents as the operand instead
of the raw address (or in addition to the raw address) -- but there are lots of
things that can end up in the comments (and llvm can add additional things like
hints about what an instruction does) so it might not
I didn't explain the disassembly-format in my proposal - it already works like
you're describing. The current lldb format is
${current-pc-arrow}${addr-file-or-load}{
${function.name-without-args}${function.concrete-only-addr-offset-no-padding}}:
A user can put this in their ~/.lldbinit file
@abidh,
Take a look again please.
http://reviews.llvm.org/D7553
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Look good to me. It would be good to fix the similar problem in other places
too. One example is SBFileSpec::ResolvePath.
http://reviews.llvm.org/D7553
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits
Ok.
http://reviews.llvm.org/D7553
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: ki.stfu
Date: Wed Feb 11 05:24:20 2015
New Revision: 228824
URL: http://llvm.org/viewvc/llvm-project?rev=228824view=rev
Log:
Add extra check that target was stopped before the *stopped is sent.
This patch fixes r228417. It's required because eStateCrushed case wasn't
investigated.
Hi abidh, zturner, clayborg,
Before this fix the FileSpec::GetPath() returned string which might be without
'\0' at the end.
It could have happened if the size of buffer for path was less than actual path.
Test case:
```
FileSpec test(/path/to/file, false);
char buf[]=!!;
test.GetPath(buf,
Fix strncpy in all files of the source folder
http://reviews.llvm.org/D7553
Files:
source/API/SBFileSpec.cpp
source/API/SBModule.cpp
source/Host/common/FileSpec.cpp
source/Host/common/SocketAddress.cpp
source/Host/macosx/HostInfoMacOSX.mm
source/Host/posix/HostInfoPosix.cpp
Author: jmolenda
Date: Thu Feb 12 00:14:23 2015
New Revision: 228910
URL: http://llvm.org/viewvc/llvm-project?rev=228910view=rev
Log:
Search through all memory regions of the core file for
both a user process dyld and for a kernel binary -- we
will decide which to prefer after one or both have
Personally I prefer always seeing the full function name, even if it's
messy. As an aside, have you considered embedding the function name
directly as the operand to the jump instruction, as opposed to as a
comment? For example, instead of this:
0x107915443 +51: callq 0x107d87bb0
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7576
Files:
lldb/trunk/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp
Index:
lldb/trunk/source/Plugins/Process/Utility/RegisterContextPOSIX_powerpc.cpp
===
---
Author: jhibbits
Date: Wed Feb 11 23:31:46 2015
New Revision: 228909
URL: http://llvm.org/viewvc/llvm-project?rev=228909view=rev
Log:
Cast EOF to get a proper comparison.
On PowerPC, and maybe some other architectures, 'char' is unsigned. Comparing
an unsigned char with a signed int (-1) is
Author: jhibbits
Date: Wed Feb 11 23:31:31 2015
New Revision: 228908
URL: http://llvm.org/viewvc/llvm-project?rev=228908view=rev
Log:
Quiet Coverity
Summary: Coverity warns that unsigned = 0 is always true, and
k_first_gpr_powerpc happens to be 0. Quiet Coverity by changing that
comparison
In r219544 (2014-10-10) I changed the default disassembly format to more
closely resemble gdb's disassembly format. After living on this format for a
few months, there are obvious shortcomings with C++ and Objective-C programs
and I want to try a new approach.
Originally lldb's disassembly
31 matches
Mail list logo
