Hi,
I am travelling and will not be able to review your patch this week. If
there are problems in tests on Linux, please disable them on Linux before
committing. I will fix/enable them when I am back in office.
Thanks,
Abid
On Mon, Mar 2, 2015 at 3:22 PM, Ilia K ki.s...@gmail.com wrote:
Skip
Hi,
I am travelling and will not be able to review your patch this week. If
there are problems in tests on Linux, please disable them on Linux before
committing. I will fix/enable them when I am back in office.
Thanks,
Abid
http://reviews.llvm.org/D8004
EMAIL PREFERENCES
Comment at: test/settings/quoting/TestQuoting.py:74
@@ -71,1 +73,3 @@
+dst_file_spec = lldb.SBFileSpec('stdout.txt', False)
+platform.Get(src_file_spec, dst_file_spec);
with open('stdout.txt', 'r') as f:
chaoren wrote:
ovyalov wrote:
Hi abidh, clayborg,
The Module::GetSymbolVendor mistakenly doesn't update m_symfile_spec when a new
SymbolVendor is created. It causes that Module::GetSymbolFileFileSpec returns
an invalid FileSpec data.
This patch fixes that error and, in addition, simplifies
These tests pass on OS X.
http://reviews.llvm.org/D7991
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Please update the Makefile for the tests where you replaced pthreads with
std::threads to use ENABLE_STD_THREADS instead on ENABLE_THREADS
http://reviews.llvm.org/D7991
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
In http://reviews.llvm.org/D7987#132264, @vharron wrote:
I tried this out and didn't see any improvement with the patch on Linux.
This patch fixes tge following tests:
1. MiExecInterpreterTestCase.test_lldbmi_thread_step_in
2. MiExecTestCase.test_lldbmi_exec_step
3.
Author: ki.stfu
Date: Mon Mar 2 04:58:02 2015
New Revision: 230944
URL: http://llvm.org/viewvc/llvm-project?rev=230944view=rev
Log:
Rename CMIDriver::LocalDebugSessionStartupInjectCommands to
CMIDriver::LocalDebugSessionStartupExecuteCommands after r230003
Modified:
Hi abidh, clayborg,
# Allow to pass an executable file via lldb-mi arguments
# Add tests
# Fix (gdb) prompt in CMIDriver::LocalDebugSessionStartupExecuteCommands
All tests pass on OS X.
http://reviews.llvm.org/D8001
Files:
test/tools/lldb-mi/startup_options/
little improvements; remove unnecessary changes
http://reviews.llvm.org/D7987
Files:
test/tools/lldb-mi/TestMiInterpreterExec.py
test/tools/lldb-mi/control/TestMiExec.py
test/tools/lldb-mi/signal/TestMiSignal.py
test/tools/lldb-mi/stack/TestMiStack.py
EMAIL PREFERENCES
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7937
Files:
lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp
Index: lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp
===
---
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7987
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: flackr
Date: Mon Mar 2 09:14:50 2015
New Revision: 230963
URL: http://llvm.org/viewvc/llvm-project?rev=230963view=rev
Log:
Reduce the number of components initialized by lldb-server to reduce static
binary size.
Separate out the necessary component initialization for lldb-server such
Hi abidh, clayborg,
Improve MiStackTestCase tests.
All tests pass on OS X.
http://reviews.llvm.org/D8004
Files:
test/tools/lldb-mi/stack/TestMiStack.py
Index: test/tools/lldb-mi/stack/TestMiStack.py
===
---
Skip test_lldbmi_stack_info_frame unless Darwin
http://reviews.llvm.org/D8004
Files:
test/tools/lldb-mi/stack/TestMiStack.py
Index: test/tools/lldb-mi/stack/TestMiStack.py
===
--- test/tools/lldb-mi/stack/TestMiStack.py
+++
Looks good then, thanks for making sure.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7963
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Looks good.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7977
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Looks good.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7970
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
m_symfile_spec is in Module _only_ for the case where you told us where the
symbol file was manually so that we could create the symbol file lazily only
when we needed to. You might have /tmp/a.out as the file and
/users/me/symbols/a.out as the symbol file and when you create the symbol file
Author: chaoren
Date: Mon Mar 2 13:12:18 2015
New Revision: 230993
URL: http://llvm.org/viewvc/llvm-project?rev=230993view=rev
Log:
Applying D7950 to four near copies of the file.
Summary:
Using std::thread/random instead of pthread/rand.
Two of them also suffered from the synchronization
20 matches
Mail list logo