Re: [Lldb-commits] [PATCH] Improve MiStackTestCase tests

2015-03-02 Thread Hafiz Abid Qadeer
Hi, I am travelling and will not be able to review your patch this week. If there are problems in tests on Linux, please disable them on Linux before committing. I will fix/enable them when I am back in office. Thanks, Abid On Mon, Mar 2, 2015 at 3:22 PM, Ilia K ki.s...@gmail.com wrote: Skip

Re: [Lldb-commits] [PATCH] Improve MiStackTestCase tests

2015-03-02 Thread Hafiz Abid Qadeer
Hi, I am travelling and will not be able to review your patch this week. If there are problems in tests on Linux, please disable them on Linux before committing. I will fix/enable them when I am back in office. Thanks, Abid http://reviews.llvm.org/D8004 EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] Fix TestQuoting on remote targets.

2015-03-02 Thread Oleksiy Vyalov
Comment at: test/settings/quoting/TestQuoting.py:74 @@ -71,1 +73,3 @@ +dst_file_spec = lldb.SBFileSpec('stdout.txt', False) +platform.Get(src_file_spec, dst_file_spec); with open('stdout.txt', 'r') as f: chaoren wrote: ovyalov wrote:

[Lldb-commits] [PATCH] Fix Module::GetSymbolFileFileSpec and simplify CommandObjectTargetModulesList::PrintModule

2015-03-02 Thread Ilia K
Hi abidh, clayborg, The Module::GetSymbolVendor mistakenly doesn't update m_symfile_spec when a new SymbolVendor is created. It causes that Module::GetSymbolFileFileSpec returns an invalid FileSpec data. This patch fixes that error and, in addition, simplifies

Re: [Lldb-commits] [PATCH] Applying D7950 to four near copies of the file.

2015-03-02 Thread Ilia K
These tests pass on OS X. http://reviews.llvm.org/D7991 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Applying D7950 to four near copies of the file.

2015-03-02 Thread Tamas Berghammer
Please update the Makefile for the tests where you replaced pthreads with std::threads to use ENABLE_STD_THREADS instead on ENABLE_THREADS http://reviews.llvm.org/D7991 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: [Lldb-commits] [PATCH] Fix and enable some tests on Linux (MI)

2015-03-02 Thread Ilia K
In http://reviews.llvm.org/D7987#132264, @vharron wrote: I tried this out and didn't see any improvement with the patch on Linux. This patch fixes tge following tests: 1. MiExecInterpreterTestCase.test_lldbmi_thread_step_in 2. MiExecTestCase.test_lldbmi_exec_step 3.

[Lldb-commits] [lldb] r230944 - Rename CMIDriver::LocalDebugSessionStartupInjectCommands to CMIDriver::LocalDebugSessionStartupExecuteCommands after r230003

2015-03-02 Thread Ilia K
Author: ki.stfu Date: Mon Mar 2 04:58:02 2015 New Revision: 230944 URL: http://llvm.org/viewvc/llvm-project?rev=230944view=rev Log: Rename CMIDriver::LocalDebugSessionStartupInjectCommands to CMIDriver::LocalDebugSessionStartupExecuteCommands after r230003 Modified:

[Lldb-commits] [PATCH] Allow to pass an executable file via lldb-mi arguments (MI)

2015-03-02 Thread Ilia K
Hi abidh, clayborg, # Allow to pass an executable file via lldb-mi arguments # Add tests # Fix (gdb) prompt in CMIDriver::LocalDebugSessionStartupExecuteCommands All tests pass on OS X. http://reviews.llvm.org/D8001 Files: test/tools/lldb-mi/startup_options/

Re: [Lldb-commits] [PATCH] Fix and enable some tests on Linux (MI)

2015-03-02 Thread Ilia K
little improvements; remove unnecessary changes http://reviews.llvm.org/D7987 Files: test/tools/lldb-mi/TestMiInterpreterExec.py test/tools/lldb-mi/control/TestMiExec.py test/tools/lldb-mi/signal/TestMiSignal.py test/tools/lldb-mi/stack/TestMiStack.py EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] Make it possible to stop the operation thread in NativeProcessLinux

2015-03-02 Thread Tamas Berghammer
REPOSITORY rL LLVM http://reviews.llvm.org/D7937 Files: lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp Index: lldb/trunk/source/Plugins/Process/Linux/NativeProcessLinux.cpp === ---

Re: [Lldb-commits] [PATCH] Fix and enable some tests on Linux (MI)

2015-03-02 Thread Ilia K
REPOSITORY rL LLVM http://reviews.llvm.org/D7987 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r230963 - Reduce the number of components initialized by lldb-server to reduce static binary size.

2015-03-02 Thread Robert Flack
Author: flackr Date: Mon Mar 2 09:14:50 2015 New Revision: 230963 URL: http://llvm.org/viewvc/llvm-project?rev=230963view=rev Log: Reduce the number of components initialized by lldb-server to reduce static binary size. Separate out the necessary component initialization for lldb-server such

[Lldb-commits] [PATCH] Improve MiStackTestCase tests

2015-03-02 Thread Ilia K
Hi abidh, clayborg, Improve MiStackTestCase tests. All tests pass on OS X. http://reviews.llvm.org/D8004 Files: test/tools/lldb-mi/stack/TestMiStack.py Index: test/tools/lldb-mi/stack/TestMiStack.py === ---

Re: [Lldb-commits] [PATCH] Improve MiStackTestCase tests

2015-03-02 Thread Ilia K
Skip test_lldbmi_stack_info_frame unless Darwin http://reviews.llvm.org/D8004 Files: test/tools/lldb-mi/stack/TestMiStack.py Index: test/tools/lldb-mi/stack/TestMiStack.py === --- test/tools/lldb-mi/stack/TestMiStack.py +++

Re: [Lldb-commits] [PATCH] Casting pid to ::pid_t when invoking syscall.

2015-03-02 Thread Greg Clayton
Looks good then, thanks for making sure. REPOSITORY rL LLVM http://reviews.llvm.org/D7963 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Fix attaching to 32 bit inferior with 64 bit llgs.

2015-03-02 Thread Greg Clayton
Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D7977 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Advertise 32 bit support for PlatformRemoteGDBServer on 64 bit systems.

2015-03-02 Thread Greg Clayton
Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D7970 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Fix Module::GetSymbolFileFileSpec and simplify CommandObjectTargetModulesList::PrintModule

2015-03-02 Thread Greg Clayton
m_symfile_spec is in Module _only_ for the case where you told us where the symbol file was manually so that we could create the symbol file lazily only when we needed to. You might have /tmp/a.out as the file and /users/me/symbols/a.out as the symbol file and when you create the symbol file

[Lldb-commits] [lldb] r230993 - Applying D7950 to four near copies of the file.

2015-03-02 Thread Chaoren Lin
Author: chaoren Date: Mon Mar 2 13:12:18 2015 New Revision: 230993 URL: http://llvm.org/viewvc/llvm-project?rev=230993view=rev Log: Applying D7950 to four near copies of the file. Summary: Using std::thread/random instead of pthread/rand. Two of them also suffered from the synchronization