Author: ki.stfu
Date: Thu Mar 26 05:28:15 2015
New Revision: 233266
URL: http://llvm.org/viewvc/llvm-project?rev=233266view=rev
Log:
Fix StopHookForMultipleThreadsTestCase tests after r233098
Modified:
Hello,
This broke the 2 tests:
1: test_stop_hook_multiple_threads_with_dsym
(TestStopHookMultipleThreads.StopHookForMultipleThreadsTestCase)
Test that lldb stop-hook works for multiple threads. ... ERROR
2: test_stop_hook_multiple_threads_with_dwarf
Author: ki.stfu
Date: Thu Mar 26 03:16:18 2015
New Revision: 233260
URL: http://llvm.org/viewvc/llvm-project?rev=233260view=rev
Log:
Use std::vector::const_iterator and std::vector::cbegin/cend in
CMICmnLLDBDebuggerHandleEvents::ChkForStateChanges (MI)
Modified:
Author: ki.stfu
Date: Thu Mar 26 04:43:23 2015
New Revision: 233265
URL: http://llvm.org/viewvc/llvm-project?rev=233265view=rev
Log:
Use std::vector::iterator in CMICmnLLDBDebuggerHandleEvents::ChkForStateChanges
to fix build on Linux after r233260 (MI)
Modified:
Ah yes, do leave the switch statement in then...
http://reviews.llvm.org/D8298
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Looks good.
http://reviews.llvm.org/D8623
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Author: zturner
Date: Thu Mar 26 11:43:25 2015
New Revision: 233284
URL: http://llvm.org/viewvc/llvm-project?rev=233284view=rev
Log:
Tear down tests in reverse order from setting them up.
Tests derive from TestBase, which derives from Base. In the
test setUp() methods, we always call
Author: sas
Date: Thu Mar 26 12:47:34 2015
New Revision: 233298
URL: http://llvm.org/viewvc/llvm-project?rev=233298view=rev
Log:
Add an assertion for frame[0] being valid in CommandObjectThread.cpp.
Summary:
This should always be true but sometimes is not, during platform bring
up. As
On 26 March 2015 at 11:55, Ed Maste ema...@freebsd.org wrote:
Author: emaste
Date: Thu Mar 26 10:55:16 2015
New Revision: 233281
URL: http://llvm.org/viewvc/llvm-project?rev=233281view=rev
Log:
Add FreeBSD/arm64 files to xcode build
It seems I missed something here (the new files are not
Just a drive by comment: You mention causing several test failure. Does your
patch fix them? If yes, then are they currently skipped or marked xfail? If yes
again, you should probably enable them in this patch.
At the very least, it will be helpful if you can give an example of a failing
test.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8611
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Todd originally put that in, but only in the async case. It is just some dopey
little delay in the hope of avoiding a race. The synchronous case is going to
the trouble of waiting for a real stop to happen and get reported, that's going
to take longer than this little delay.
Of course, it
- Use lldb.DBG.GetSelectedPlatform().GetTriple() to get target platform triple
whether running local or remote tests.
- Change skipIfPlatform checks to also check remote platform.
- Consider both macosx and darwin as MacOSX - see Triple::isMacOSX for
equivalent check.
REPOSITORY
rL LLVM
Todd originally put that in, but only in the async case. It is just some dopey
little delay in the hope of avoiding a race. The synchronous case is going to
the trouble of waiting for a real stop to happen and get reported, that's going
to take longer than this little delay.
Of course, it
Jim, thoughts?
http://reviews.llvm.org/D8562
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Shouldn't we return an unsigned char type even if the name says char? See
inlined comment.
Comment at: source/Symbol/ClangASTContext.cpp:1023
@@ +1022,3 @@
+if (QualTypeMatchesBitSize (bit_size, ast,
ast-CharTy))
+return
In http://reviews.llvm.org/D8636#147410, @sivachandra wrote:
Just a drive by comment: You mention causing several test failure. Does
your patch fix them? If yes, then are they currently skipped or marked xfail?
If yes again, you should probably enable them in this patch.
At the very least,
We are running into the case where we setup a default clang::ASTContext for
every shared library. We could argue that as soon as you create the
clang::ClangAST that you must then search for a char type by name and see if
it is unsigned and if so, modify the clang::ASTContext. But we currently
Author: zturner
Date: Thu Mar 26 13:54:21 2015
New Revision: 233306
URL: http://llvm.org/viewvc/llvm-project?rev=233306view=rev
Log:
Fix test failures caused by order of initialization.
tear down hooks run as part of Base.tearDown(). Some of these
hooks rely on accessing the debugger instance.
I'm seeing less failures, but I'm still seeing some with this patch:
connect to debug monitor on port 14060 failed, attempt #18 of 20
connect to debug monitor on port 12030 failed, attempt #19 of 20
connect to debug monitor on port 15778 failed, attempt #20 of 20
FAIL: LLDB
Author: zturner
Date: Thu Mar 26 13:59:56 2015
New Revision: 233308
URL: http://llvm.org/viewvc/llvm-project?rev=233308view=rev
Log:
Fix the remaining two test failures caused by re-ordering of teardown.
Previously we were using teardown hooks in these two instances to
shutdown processes.
So we really don't want this fix. If there are tests that are expecting char
to show up, those tests should be fixed to deal unsigned chars. We really want
any variable that is actually unsigned to be represented as unsigned in the
clang::ASTContext objects we create for each shared library
Is fixes the test but I'm getting these stack traces prints. What do they
mean? (I'm in calibration now)
vharron@tifa:~/ll/svn/llvm/tools/lldb/test$ ./dotest.py -m --executable
$HOME/ll/svn/build/host/bin/lldb -s $HOME/ll/svn/build/host/lldb-test-traces -A
x86_64 -C clang-3.5 -u CFLAGS -u
Comment at: test/lldbtest.py:553
@@ +552,3 @@
+# if bugnumber is not-callable(incluing None), that means decorator
function is called with optional arguments
+# return decorator in this case, so it will be used to decorating original
method
+if callable(bugnumber):
Author: ki.stfu
Date: Thu Mar 26 08:39:25 2015
New Revision: 233272
URL: http://llvm.org/viewvc/llvm-project?rev=233272view=rev
Log:
Destroy the attached process in tearDown() to fix ProcessAttachTestCase tests
on OS X
This patch fixes the following:
```
1:
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8611
Files:
lldb/trunk/test/dotest.py
lldb/trunk/test/lldbtest.py
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: lldb/trunk/test/dotest.py
===
Makes sense.
LGTM.
http://reviews.llvm.org/D8634
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Setting the value based on the triple is a fine solution.
http://reviews.llvm.org/D8636
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
I don't understand how calling ReportRegisterState when the takedown had
already been done could cause the error you report - though without more
details about what you are doing it's hard to say for sure.
After all, within ShouldStop the m_thread in the ThreadPlan must still be
valid, and all
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8562
Files:
lldb/trunk/source/Target/Target.cpp
Index: lldb/trunk/source/Target/Target.cpp
===
--- lldb/trunk/source/Target/Target.cpp
+++ lldb/trunk/source/Target/Target.cpp
@@
lgtm
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8611
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
unit test?
On Thu, Mar 26, 2015 at 11:50 AM, Tamas Berghammer tbergham...@google.com
wrote:
Based on it I still believe if the dwarf file contains a basic type with
name char and it is a DW_ATE_unsigned_char then CharTy will be
initialized to Char_U and everything will work fine and the user
LGTM
http://reviews.llvm.org/D8595
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
The step log should show you if any code got run between the stop to evaluate
ShouldStop and when you go to get the register context here. I would be
surprised if this is happening, however. If any thread plans need to run code
to do some task, they just push another ThreadPlanCallFunction,
all ReportRegisterState does is pretty print its register context
If I invalidate the registers (specifically up to 67) after reading them
then the problem goes away. If I understand correctly, the registers should
be invalidated after every new process_stop_id right? I find it strange
that the
Author: ki.stfu
Date: Thu Mar 26 02:08:47 2015
New Revision: 233255
URL: http://llvm.org/viewvc/llvm-project?rev=233255view=rev
Log:
Fix -gdb-exit to detach if was attached or destroy otherwise (MI)
Summary:
This patch fixes -gdb-exit for locally target. It includes the following
changes:
# Fix
Fix a comment
http://reviews.llvm.org/D8298
Files:
source/Target/Process.cpp
tools/lldb-mi/MICmdCmdMiscellanous.cpp
Index: source/Target/Process.cpp
===
--- source/Target/Process.cpp
+++ source/Target/Process.cpp
@@ -822,32
Author: ki.stfu
Date: Thu Mar 26 02:11:31 2015
New Revision: 233256
URL: http://llvm.org/viewvc/llvm-project?rev=233256view=rev
Log:
Fix =thread-exited message (MI)
Summary:
This patch includes:
# Fix invalid thread id in =thread-exited message
# Remove invalid threads from cache
All tests pass
Author: ki.stfu
Date: Thu Mar 26 02:40:40 2015
New Revision: 233258
URL: http://llvm.org/viewvc/llvm-project?rev=233258view=rev
Log:
Fix Process::Finalize to do Process::Destroy if needed after r233255
Modified:
lldb/trunk/source/Target/Process.cpp
Modified:
Hello @clayborg,
I added the switch() back in Process::Finalize() in r233258, because it caused
an error:
$ bin/lldb
(lldb) target create ~/p/hello
Current executable set to '~/p/hello' (x86_64).
(lldb) r
Assertion failed: (!bad_weak_ptr), function shared_ptr, file
On Mar 25, 2015, at 6:06 PM, Zachary Turner ztur...@google.com wrote:
Ironically even though I've been staring at this problem for 2 days I think I
actually figured this out shortly after my last email. TestBase.tearDown()
already deletes all the targets but it was calling Base.tearDown
LGTM
http://reviews.llvm.org/D8634
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7835
Files:
lldb/trunk/source/Plugins/Process/Utility/CMakeLists.txt
lldb/trunk/source/Plugins/Process/Utility/RegisterContextFreeBSD_arm64.cpp
lldb/trunk/source/Plugins/Process/Utility/RegisterContextFreeBSD_arm64.h
Author: emaste
Date: Thu Mar 26 09:20:00 2015
New Revision: 233273
URL: http://llvm.org/viewvc/llvm-project?rev=233273view=rev
Log:
Handle FreeBSD/arm64 core files
This is derived from FreeBSD/mips64 and Darwin and Linux arm64 support.
Differential Revision: http://reviews.llvm.org/D7835
Author: ki.stfu
Date: Thu Mar 26 10:43:46 2015
New Revision: 233279
URL: http://llvm.org/viewvc/llvm-project?rev=233279view=rev
Log:
Fix RegisterCommandsTestCase and HelloWorldTestCase tests which hang on OS X
after TestBase.tearDown()
Modified:
Author: emaste
Date: Thu Mar 26 10:55:16 2015
New Revision: 233281
URL: http://llvm.org/viewvc/llvm-project?rev=233281view=rev
Log:
Add FreeBSD/arm64 files to xcode build
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
46 matches
Mail list logo
