[Lldb-commits] [PATCH] Fix [vdso] handling on Android (x86 and aarch64)

2015-06-29 Thread Tamas Berghammer
Hi labath, clayborg, Fix [vdso] handling on Android (x86 and aarch64) * Add in-memory object file handling to the core dynamic loader * Fix in memory object file handling in ObjectFileELF (previously only part of the file was loaded before parsing) * Fix load address setting in ObjectFileELF

Re: [Lldb-commits] [PATCH] Add setting for breakpoint PC adjustment from remote stubs which don't back PC up.

2015-06-29 Thread Ewan Crawford
Prioritizing the python target definition seems a cleaner solution. REPOSITORY rL LLVM http://reviews.llvm.org/D10775 Files: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Re: [Lldb-commits] [PATCH] [linux] Use cmake to detect support process_vm_readv (bug #23918)

2015-06-29 Thread Eugene Zelenko
Should be OK now. REPOSITORY rL LLVM http://reviews.llvm.org/D10727 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] [LLDB][MIPS] Getting correct flags for MIPS

2015-06-29 Thread Ed Maste
REPOSITORY rL LLVM Comment at: source/Target/Platform.cpp:1512 @@ +1511,3 @@ + || arch.GetTriple ().getArch () == llvm::Triple::mipsel) + map_anon = 0x800; + labath wrote: Wouldn't this be better in PlatformLinux? What are the odds of this

Re: [Lldb-commits] [PATCH] [LLDB][MIPS] Getting correct flags for MIPS

2015-06-29 Thread Pavel Labath
REPOSITORY rL LLVM Comment at: source/Target/Platform.cpp:1512 @@ +1511,3 @@ + || arch.GetTriple ().getArch () == llvm::Triple::mipsel) + map_anon = 0x800; + Wouldn't this be better in PlatformLinux? What are the odds of this constant being

[Lldb-commits] [lldb] r240946 - dosep.py: Add ability to set default test timout based on target

2015-06-29 Thread Pavel Labath
Author: labath Date: Mon Jun 29 09:16:51 2015 New Revision: 240946 URL: http://llvm.org/viewvc/llvm-project?rev=240946view=rev Log: dosep.py: Add ability to set default test timout based on target Summary: Current default is 10 minutes, which causes the test suite to run very long in case of

Re: [Lldb-commits] [PATCH] [LLDB][MIPS] Getting correct flags for MIPS

2015-06-29 Thread Nitesh Jain
REPOSITORY rL LLVM http://reviews.llvm.org/D10685 Files: include/lldb/Target/Platform.h source/Plugins/Platform/Linux/PlatformLinux.cpp source/Plugins/Platform/Linux/PlatformLinux.h source/Plugins/Process/Utility/InferiorCallPOSIX.cpp source/Target/Platform.cpp Index:

Re: [Lldb-commits] [PATCH] Add -lpthread to LLDB shared lib link line unconditionally

2015-06-29 Thread Pavel Labath
Sure, commit the makefile changes any time you like. Sorry for the delay. I was not sure if I want this change or not, and I was hoping someone else will have a say. BTW, is the cmake change even necessary now? I just noticed that the root CMakeLists.txt has if (NOT LLDB_DISABLE_PYTHON)

Re: [Lldb-commits] [PATCH] [LLDB][MIPS] Getting correct flags for MIPS

2015-06-29 Thread Nitesh Jain
REPOSITORY rL LLVM http://reviews.llvm.org/D10685 Files: include/lldb/Target/Platform.h source/Plugins/Platform/Linux/PlatformLinux.cpp source/Plugins/Platform/Linux/PlatformLinux.h source/Plugins/Process/Utility/InferiorCallPOSIX.cpp source/Target/Platform.cpp Index:

Re: [Lldb-commits] [lldb] r240606 - Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk

2015-06-29 Thread Ed Maste
On 24 June 2015 at 19:13, Enrico Granata egran...@apple.com wrote: Author: enrico Date: Wed Jun 24 18:13:23 2015 New Revision: 240606 URL: http://llvm.org/viewvc/llvm-project?rev=240606view=rev Log: Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin

[Lldb-commits] [lldb] r240958 - Correct failure decorator in test_fd_leak_multitarget

2015-06-29 Thread Ed Maste
Author: emaste Date: Mon Jun 29 10:26:45 2015 New Revision: 240958 URL: http://llvm.org/viewvc/llvm-project?rev=240958view=rev Log: Correct failure decorator in test_fd_leak_multitarget The random module in Python 2.7.8 and later leaks /dev/[u]random into children. The test is expected to fail,

[Lldb-commits] [lldb] r240964 - Mark test_sb_api_listener_event_process_state as flakey

2015-06-29 Thread Tamas Berghammer
Author: tberghammer Date: Mon Jun 29 11:28:37 2015 New Revision: 240964 URL: http://llvm.org/viewvc/llvm-project?rev=240964view=rev Log: Mark test_sb_api_listener_event_process_state as flakey Modified: lldb/trunk/test/api/multithreaded/TestMultithreaded.py Modified:

Re: [Lldb-commits] [PATCH] [NativeProcessLinux] Refactor PtraceWrapper

2015-06-29 Thread Chaoren Lin
Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:145 @@ -146,1 +144,3 @@ +static Error +PtraceWrapper(int req, lldb::pid_t pid, void *addr, void *data, size_t data_size, long *result = nullptr); It seems like every argument besides

Re: [Lldb-commits] [PATCH] Replace `rm -rf` with more portable implementation.

2015-06-29 Thread Greg Clayton
See inlined comments for needed changes. REPOSITORY rL LLVM Comment at: lldb/trunk/source/Host/posix/FileSystem.cpp:85-103 @@ -83,7 +84,21 @@ { -StreamString command; -command.Printf(rm -rf \%s\, file_spec.GetCString()); -int

Re: [Lldb-commits] [PATCH] Replace `rm -rf` with more portable implementation.

2015-06-29 Thread Greg Clayton
Ah, I missed that this was committed. I will fix this. REPOSITORY rL LLVM http://reviews.llvm.org/D10787 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r240927 - [linux] Use cmake to detect support process_vm_readv (bug #23918)

2015-06-29 Thread Pavel Labath
Author: labath Date: Mon Jun 29 04:18:17 2015 New Revision: 240927 URL: http://llvm.org/viewvc/llvm-project?rev=240927view=rev Log: [linux] Use cmake to detect support process_vm_readv (bug #23918) Summary: Some old linux versions do not have process_vm_readv function defined. Even older

Re: [Lldb-commits] [PATCH] Expression evaluation, a new ThreadPlanCallFunctionNoJIT for executing a function call on target via register manipulation

2015-06-29 Thread Deepak Panickal
Adding Greg for review. REPOSITORY rL LLVM http://reviews.llvm.org/D9404 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Rewrite FileSpec::EnumerateDirectory to avoid code duplication.

2015-06-29 Thread Greg Clayton
Looks good. http://reviews.llvm.org/D10811 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Rewrite FileSpec::EnumerateDirectory to avoid code duplication.

2015-06-29 Thread Chaoren Lin
- Shouldn't try to be clever. http://reviews.llvm.org/D10811 Files: include/lldb/Host/FileSpec.h source/Host/common/FileSpec.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: include/lldb/Host/FileSpec.h

Re: [Lldb-commits] [lldb] r240606 - Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk

2015-06-29 Thread Ed Maste
On 29 June 2015 at 14:47, Enrico Granata egran...@apple.com wrote: I can see arguments for and against removing the default, but I think removing it will cause a new warning to appear if Clang adds other new kinds in the future. Yes. And I am slightly more worried about the silent failure

Re: [Lldb-commits] [lldb] r240927 - [linux] Use cmake to detect support process_vm_readv (bug #23918)

2015-06-29 Thread Vince Harron
Don't we already get behavior like this when we invoke a missing syscall? On Mon, Jun 29, 2015 at 2:18 AM, Pavel Labath lab...@google.com wrote: Author: labath Date: Mon Jun 29 04:18:17 2015 New Revision: 240927 URL: http://llvm.org/viewvc/llvm-project?rev=240927view=rev Log: [linux] Use

[Lldb-commits] [lldb] r240978 - Avoid a recursive function call that could run LLDB out of file descriptors in FileSystem::DeleteDirectory(...).

2015-06-29 Thread Greg Clayton
Author: gclayton Date: Mon Jun 29 13:29:00 2015 New Revision: 240978 URL: http://llvm.org/viewvc/llvm-project?rev=240978view=rev Log: Avoid a recursive function call that could run LLDB out of file descriptors in FileSystem::DeleteDirectory(...). Fixes include: - use FileSystem::Unlink()

Re: [Lldb-commits] [lldb] r240606 - Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk

2015-06-29 Thread Ed Maste
On 29 June 2015 at 14:21, Enrico Granata egran...@apple.com wrote: Are you trying to build with -Werror? We are not here, so warnings don’t cause our builds to fail - and in this case, I slightly prefer the default to stay I'm not building with -Werror, just looking at the warnings that come

Re: [Lldb-commits] [PATCH] [LLDB][MIPS] Getting correct flags for MIPS

2015-06-29 Thread Greg Clayton
Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D10685 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Add setting for breakpoint PC adjustment from remote stubs which don't back PC up.

2015-06-29 Thread Greg Clayton
Looks good. REPOSITORY rL LLVM http://reviews.llvm.org/D10775 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Replace `rm -rf` with more portable implementation.

2015-06-29 Thread Greg Clayton
Sorry I didn't see this email before I fixed it. REPOSITORY rL LLVM http://reviews.llvm.org/D10787 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Replace `rm -rf` with more portable implementation.

2015-06-29 Thread Greg Clayton
Sorry I didn't see this email before I fixed it. On Jun 29, 2015, at 10:42 AM, Chaoren Lin chaor...@google.com wrote: Please let me fix this. I need to redeem myself. REPOSITORY rL LLVM http://reviews.llvm.org/D10787 EMAIL PREFERENCES

Re: [Lldb-commits] [lldb] r240606 - Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk

2015-06-29 Thread Enrico Granata
On Jun 29, 2015, at 8:17 AM, Ed Maste ema...@freebsd.org wrote: On 24 June 2015 at 19:13, Enrico Granata egran...@apple.com wrote: Author: enrico Date: Wed Jun 24 18:13:23 2015 New Revision: 240606 URL: http://llvm.org/viewvc/llvm-project?rev=240606view=rev Log: Handle (or at least

Re: [Lldb-commits] [PATCH] Replace `rm -rf` with more portable implementation.

2015-06-29 Thread Greg Clayton
I implemented my suggestions with: % svn commit Sendinginclude/lldb/Host/FileSpec.h Sendingsource/Host/common/FileSpec.cpp Sendingsource/Host/posix/FileSystem.cpp Transmitting file data ... Committed revision 240978. REPOSITORY rL LLVM

Re: [Lldb-commits] [PATCH] Use both OS and Architecture to choose correct ABI

2015-06-29 Thread Greg Clayton
looks good. http://reviews.llvm.org/D10308 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Fix [vdso] handling on Android (x86 and aarch64)

2015-06-29 Thread Greg Clayton
Looks good. I am very happy to see memory loading of ELF files. http://reviews.llvm.org/D10800 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r240979 - Fix buildbot failures for:

2015-06-29 Thread Greg Clayton
Author: gclayton Date: Mon Jun 29 13:42:02 2015 New Revision: 240979 URL: http://llvm.org/viewvc/llvm-project?rev=240979view=rev Log: Fix buildbot failures for: http://lab.llvm.org:8011/builders/lldb-x86-win7-msvc/builds/6152 http://lab.llvm.org:8011/builders/lldb-x86-windows-msvc/builds/7422

[Lldb-commits] [PATCH] Rewrite FileSpec::EnumerateDirectory to avoid code duplication.

2015-06-29 Thread Chaoren Lin
Hi clayborg, http://reviews.llvm.org/D10811 Files: include/lldb/Host/FileSpec.h source/Host/common/FileSpec.cpp EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ Index: include/lldb/Host/FileSpec.h

Re: [Lldb-commits] [lldb] r240606 - Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk

2015-06-29 Thread Enrico Granata
On Jun 29, 2015, at 11:32 AM, Ed Maste ema...@freebsd.org wrote: On 29 June 2015 at 14:21, Enrico Granata egran...@apple.com wrote: Are you trying to build with -Werror? We are not here, so warnings don’t cause our builds to fail - and in this case, I slightly prefer the default to stay

[Lldb-commits] [lldb] r241006 - Add -lpthread to LLDB shared lib link line unconditionally

2015-06-29 Thread Keno Fischer
Author: kfischer Date: Mon Jun 29 16:52:45 2015 New Revision: 241006 URL: http://llvm.org/viewvc/llvm-project?rev=241006view=rev Log: Add -lpthread to LLDB shared lib link line unconditionally Usually -lpthread is included due to LLVM link options, but when LLVM threading is disabled, this does

Re: [Lldb-commits] [PATCH] Add -lpthread to LLDB shared lib link line unconditionally

2015-06-29 Thread Keno Fischer
Yup, seems like that would do it as well. Great, thanks! REPOSITORY rL LLVM http://reviews.llvm.org/D5431 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

[Lldb-commits] [lldb] r240988 - More packet reduction when debugging with GDB server.

2015-06-29 Thread Greg Clayton
Author: gclayton Date: Mon Jun 29 15:08:51 2015 New Revision: 240988 URL: http://llvm.org/viewvc/llvm-project?rev=240988view=rev Log: More packet reduction when debugging with GDB server. - Avoid sending the qfThreadInfo, qsThreadInfo packets if we have a stop reply packet with the threads

Re: [Lldb-commits] [PATCH] Add -lpthread to LLDB shared lib link line unconditionally

2015-06-29 Thread Phabricator
REPOSITORY rL LLVM http://reviews.llvm.org/D5431 Files: lldb/trunk/lib/Makefile lldb/trunk/tools/lldb-mi/Makefile lldb/trunk/tools/lldb-server/Makefile Index: lldb/trunk/tools/lldb-mi/Makefile === ---

Re: [Lldb-commits] [lldb] r240606 - Handle (or at least don't crash) trying to get the encoding for a bunch of new builtin types in clang trunk

2015-06-29 Thread Enrico Granata
On Jun 29, 2015, at 11:58 AM, Ed Maste ema...@freebsd.org wrote: On 29 June 2015 at 14:47, Enrico Granata egran...@apple.com wrote: I can see arguments for and against removing the default, but I think removing it will cause a new warning to appear if Clang adds other new kinds in the

Re: [Lldb-commits] [PATCH] Fix [vdso] handling on Android (x86 and aarch64)

2015-06-29 Thread Tamas Berghammer
In http://reviews.llvm.org/D10800#196543, @vharron wrote: If you've fixed vdso handling, shouldn't some i386 tests be marked as passing? It is fixing it only on Android. There is a different between how the linker works on Linux and on Android and we need to solve one more additional issue

Re: [Lldb-commits] [PATCH] Fix [vdso] handling on Android (x86 and aarch64)

2015-06-29 Thread Vince Harron
If you've fixed vdso handling, shouldn't some i386 tests be marked as passing? http://reviews.llvm.org/D10800 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Use both OS and Architecture to choose correct ABI

2015-06-29 Thread Abhishek
Followed up on Jason's comments - Added check for the presence of iOS http://reviews.llvm.org/D10308 Files: source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp Index: source/Plugins/ABI/MacOSX-i386/ABIMacOSX_i386.cpp === ---

Re: [Lldb-commits] [PATCH] [Python] Allow PyLong values in integer lists (when converting to C lists)

2015-06-29 Thread Greg Clayton
Looks good. Not sure if we also want to handle booleans? Should be easy to add support for bools. http://reviews.llvm.org/D10821 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list

[Lldb-commits] [PATCH] Ignore teardown failure if it's caused by removing missing file or directory

2015-06-29 Thread Ying Chen
Hi vharron, tberghammer, This is aiming to workaround this issue: When test is decorated with expectedFlakey* and has teardown hook attached, the teardown hook will be added and executed twice, the second execution will fail due to missing file. http://reviews.llvm.org/D10830 Files:

Re: [Lldb-commits] [PATCH] Fix [vdso] handling on Android (x86 and aarch64)

2015-06-29 Thread Vince Harron
You can use the gdb remote get auxv command I think to get libvdso load address. On Mon, Jun 29, 2015 at 3:28 PM, Tamas Berghammer tbergham...@google.com wrote: In http://reviews.llvm.org/D10800#196543, @vharron wrote: If you've fixed vdso handling, shouldn't some i386 tests be marked as

Re: [Lldb-commits] [PATCH] Fix [vdso] handling on Android (x86 and aarch64)

2015-06-29 Thread Vince Harron
You can use the gdb remote get auxv command I think to get libvdso load address. http://reviews.llvm.org/D10800 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Ignore teardown failure if it's caused by removing missing file or directory

2015-06-29 Thread Vince Harron
Maybe we should call teardown from expectedFlakey instead? http://reviews.llvm.org/D10830 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Ignore push/pop {sp} in emulation based unwinding

2015-06-29 Thread Jason Molenda
Looks good to me. http://reviews.llvm.org/D10806 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits