jingham added a subscriber: jingham.
jingham added a comment.
I'll let Greg weigh in on the actual details, but if as I understand the patch,
the m_die_to_index_map only stored CU dies, can you make the name of the ivar
indicate that fact?
http://reviews.llvm.org/D11390
Author: chaoren
Date: Tue Jul 21 12:50:16 2015
New Revision: 242813
URL: http://llvm.org/viewvc/llvm-project?rev=242813view=rev
Log:
Update TestLoadUnload to use base Makefile.
Summary:
The current Makefile scheme only allows one dylib to be specified in each make
invocation, so TestLoadUnload
chaoren updated this revision to Diff 30269.
chaoren added a comment.
Address review.
http://reviews.llvm.org/D11378
Files:
test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py
Index: test/tools/lldb-server/inferior-crash/TestGdbRemoteAbort.py
This revision was automatically updated to reflect the committed changes.
Closed by commit rL242813: Update TestLoadUnload to use base Makefile.
(authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D11367?vs=30271id=30272#toc
Repository:
rL LLVM
Author: chaoren
Date: Tue Jul 21 12:50:52 2015
New Revision: 242815
URL: http://llvm.org/viewvc/llvm-project?rev=242815view=rev
Log:
Xfail TestGdbRemoteAbort for Android API = 16.
Reviewers: sivachandra
Subscribers: tberghammer, danalbert, srhines, lldb-commits
Differential Revision:
Author: chaoren
Date: Tue Jul 21 12:50:49 2015
New Revision: 242814
URL: http://llvm.org/viewvc/llvm-project?rev=242814view=rev
Log:
Re-enable static Android build after build master restart.
Modified:
lldb/trunk/cmake/platforms/Android.cmake
Modified:
paulmaybee added inline comments.
Comment at: test/tools/lldb-mi/variable/main.cpp:63-65
@@ -63,3 +63,4 @@
const char16_t u16a[] = uhello;
const char32_t *u32p = Uhello;
const char32_t u32a[] = Uhello;
+
ki.stfu wrote:
please replace these
granata.enrico added a comment.
I am ok with this is Jason is
http://reviews.llvm.org/D11295
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
brucem added a comment.
Could you please add a test for the file: + ::func case?
Repository:
rL LLVM
http://reviews.llvm.org/D11396
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D11388
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D11386
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
dawn retitled this revision from Parse breakpoint expressions using the
language of the frame's CU. to Specify a language to use when parsing
breakpoint identifiers..
dawn updated the summary for this revision.
dawn updated this revision to Diff 30277.
dawn added a comment.
This revised patch
dawn added a comment.
In http://reviews.llvm.org/D9#209209, @clayborg wrote:
Looks good as long as the test suite is happy. I worry about MacOSX tests.
All tests passed locally. Will watch for build failures...
Repository:
rL LLVM
http://reviews.llvm.org/D9
Author: dperchik
Date: Tue Jul 21 17:05:07 2015
New Revision: 242844
URL: http://llvm.org/viewvc/llvm-project?rev=242844view=rev
Log:
Add support for specifying a language to use when parsing breakpoints.
Target and breakpoints options were added:
breakpoint set --language lang --name func
This revision was automatically updated to reflect the committed changes.
Closed by commit rL242844: Add support for specifying a language to use when
parsing breakpoints. (authored by dperchik).
Changed prior to commit:
http://reviews.llvm.org/D9?vs=30277id=30292#toc
Repository:
rL
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
No need for an extra map. A local C++ guru a while back told me about being
able to use a comparison function with two different types if you use
std::lower_bound() or
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good as long as the test suite is happy. I worry about MacOSX tests.
Repository:
rL LLVM
http://reviews.llvm.org/D9
___
clayborg commandeered this revision.
clayborg edited reviewers, added: tberghammer; removed: clayborg.
clayborg added a comment.
I actually checked my changes in with:
% svn commit
Sendingsource/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
Transmitting file data .
Committed revision
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Makes sense to me, please apply.
http://reviews.llvm.org/D11295
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
dawn added a subscriber: lldb-commits.
dawn updated this revision to Diff 30300.
dawn added a comment.
This revision fixes the case that we have 'file:ns::func' and enables a test
case.
Repository:
rL LLVM
http://reviews.llvm.org/D11396
Files:
test/tools/lldb-mi/breakpoint/TestMiBreak.py
Author: brucem
Date: Tue Jul 21 19:16:02 2015
New Revision: 242856
URL: http://llvm.org/viewvc/llvm-project?rev=242856view=rev
Log:
Fix typos.
Summary: Fix a bunch of typos.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D11386
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL242856: Fix typos. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D11386?vs=30244id=30301#toc
Repository:
rL LLVM
http://reviews.llvm.org/D11386
Files:
brucem updated this revision to Diff 30240.
brucem added a comment.
Minor update for formatting and to change (void) parameter lists.
http://reviews.llvm.org/D11052
Files:
tools/lldb-mi/MICmnMIResultRecord.cpp
tools/lldb-mi/MICmnMIResultRecord.h
Index: tools/lldb-mi/MICmnMIResultRecord.h
Author: labath
Date: Tue Jul 21 06:04:52 2015
New Revision: 242767
URL: http://llvm.org/viewvc/llvm-project?rev=242767view=rev
Log:
Revert Add Pipe::WriteWithTimeout method
I have observed an increased flakyness in the buildbots. I suspect something
was relying on the
fact that Pipe::Write had
Author: brucem
Date: Tue Jul 21 06:27:40 2015
New Revision: 242768
URL: http://llvm.org/viewvc/llvm-project?rev=242768view=rev
Log:
[lldb-mi] Remove unused portions of MIDataTypes.h.
Reviewers: abidh, ki.stfu
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D11385
This revision was automatically updated to reflect the committed changes.
Closed by commit rL242768: [lldb-mi] Remove unused portions of MIDataTypes.h.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D11385?vs=30241id=30242#toc
Repository:
rL LLVM
brucem created this revision.
brucem added a reviewer: clayborg.
brucem added a subscriber: lldb-commits.
Fix a bunch of typos.
http://reviews.llvm.org/D11386
Files:
examples/darwin/heap_find/heap/heap_find.cpp
include/lldb/Core/Connection.h
include/lldb/Core/Log.h
kubabrecka added a comment.
Nice improvement. Looks good to me, but please let Jason or Enrico review this
as well.
http://reviews.llvm.org/D11384
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
brucem created this revision.
brucem added reviewers: abidh, ki.stfu.
brucem added a subscriber: lldb-commits.
http://reviews.llvm.org/D11385
Files:
tools/lldb-mi/MIDataTypes.h
Index: tools/lldb-mi/MIDataTypes.h
===
---
Author: brucem
Date: Tue Jul 21 06:30:39 2015
New Revision: 242769
URL: http://llvm.org/viewvc/llvm-project?rev=242769view=rev
Log:
[lldb-mi] Simplify MICmnMIResultRecord implementation.
Summary:
* Remove extraneous members that were just storing temporary
values.
* ResultClass_e parameters
brucem created this revision.
brucem added reviewers: ki.stfu, abidh.
brucem added a subscriber: lldb-commits.
http://reviews.llvm.org/D11387
Files:
tools/lldb-mi/MICmnMIResultRecord.cpp
Index: tools/lldb-mi/MICmnMIResultRecord.cpp
brucem updated this revision to Diff 30235.
brucem added a comment.
This restores the (R) to some comments and handles the mapping of
the result class to a string in a better way that will generate
compiler warnings if a new result class is added.
The const qualifiers haven't been re-added after
Author: labath
Date: Tue Jul 21 04:37:43 2015
New Revision: 242765
URL: http://llvm.org/viewvc/llvm-project?rev=242765view=rev
Log:
Fix incorrect documentation directives and some parameters
Differential Revision: http://reviews.llvm.org/D11379
Patch by Eugene Zelenko.
Modified:
brucem updated this revision to Diff 30238.
brucem added a comment.
Updated per review comment.
http://reviews.llvm.org/D11052
Files:
tools/lldb-mi/MICmnMIResultRecord.cpp
tools/lldb-mi/MICmnMIResultRecord.h
Index: tools/lldb-mi/MICmnMIResultRecord.h
Author: brucem
Date: Tue Jul 21 03:07:27 2015
New Revision: 242762
URL: http://llvm.org/viewvc/llvm-project?rev=242762view=rev
Log:
[lldb-mi] size_t rather than MIuint for arg counts.
Summary: [lldb-mi] size_t rather than MIuint for arg counts.
Reviewers: abidh, ki.stfu
Subscribers:
This revision was automatically updated to reflect the committed changes.
brucem marked an inline comment as done.
Closed by commit rL242762: [lldb-mi] size_t rather than MIuint for arg counts.
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D11049?vs=29304id=30233#toc
Author: labath
Date: Tue Jul 21 08:20:32 2015
New Revision: 242783
URL: http://llvm.org/viewvc/llvm-project?rev=242783view=rev
Log:
[NativeProcessLinux] Integrate MainLoop
Summary:
This commit integrates MainLoop into NativeProcessLinux. By registering a
SIGCHLD handler with
the llgs main loop,
labath marked an inline comment as done.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:970
@@ +969,3 @@
+log-Printf(GDBRemoteCommunicationServerLLGS::%s Stopping
stdio forwarding as communication returned status %d (error:
Author: brucem
Date: Tue Jul 21 08:09:39 2015
New Revision: 242781
URL: http://llvm.org/viewvc/llvm-project?rev=242781view=rev
Log:
[lldb-mi] Correct file names in first line comments.
Modified:
lldb/trunk/tools/lldb-mi/MICmdArgContext.cpp
lldb/trunk/tools/lldb-mi/MICmdArgValBase.h
Author: brucem
Date: Tue Jul 21 07:39:58 2015
New Revision: 242778
URL: http://llvm.org/viewvc/llvm-project?rev=242778view=rev
Log:
[lldb-mi] Fix Windows build, missing assert.h include.
Reviewers: ki.stfu, abidh
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D11387
This revision was automatically updated to reflect the committed changes.
Closed by commit rL242778: [lldb-mi] Fix Windows build, missing assert.h
include. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D11387?vs=30245id=30248#toc
Repository:
rL LLVM
41 matches
Mail list logo
