Re: [Lldb-commits] [PATCH] D9716: Add 'size' field to module load event.

2015-07-29 Thread Chuck Ries
ChuckR abandoned this revision. Comment at: test/tools/lldb-mi/TestMiLibraryLoaded.py:32 @@ -33,1 +31,3 @@ + =library-loaded,id=\%s\,target-name=\%s\,host-name=\%s\,symbols-loaded=\0\,loaded_addr=\-\,size=\[0-9]+\ % (path, path, path) +])

Re: [Lldb-commits] [lldb] r235109 - Adds lldb support for querying the register mapping from gdbserver remote targets using qXfer:features:read packet. Only enabled if libxml2 enabled in build.

2015-04-16 Thread Chuck Ries
After this change I am seeing the cmake build broken on mac os. FAILED: /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLIBXML2_DEFINED -D_DEBUG -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter

Re: [Lldb-commits] [PATCH] Generate an event when a pending breakpoint binds

2015-04-08 Thread Chuck Ries
Thank you for the information. http://reviews.llvm.org/D8847 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Generate an event when a pending breakpoint binds

2015-04-08 Thread Chuck Ries
Do I need more sign off to get this checked in? http://reviews.llvm.org/D8847 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] Generate an event when a pending breakpoint binds

2015-04-08 Thread Chuck Ries
That would be perfect, thanks. http://reviews.llvm.org/D8847 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Generate an event when a pending breakpoint binds

2015-04-07 Thread Chuck Ries
What do you mean? It is printed: breakpoint-modified,bkpt={number=1,type=breakpoint,disp=keep,enabled=y,addr=0x00010f4d,func=main,file=main.cpp,fullname=/Users/chuckr/llama/llvm/tools/lldb/test/tools/lldb-mi/main.cpp,line=15,pending=[main.cpp:15],times=0,original-location=main.cpp:15}

[Lldb-commits] [PATCH] Generate an event when a pending breakpoint binds

2015-04-06 Thread Chuck Ries
Hi abidh, jingham, This checkin sends an MI event when a module is loaded that causes a pending breakpoint to bind to it's real address in the target. This allows breakpoints to be set before the process is launched, and the target address of the BP to be discovered when the module loads,

Re: [Lldb-commits] [PATCH] implement gdb-set output-radix

2015-04-06 Thread Chuck Ries
Can somebody check this in for me now that it has been approved? http://reviews.llvm.org/D8430 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu

Re: [Lldb-commits] [PATCH] implement gdb-set output-radix

2015-04-03 Thread Chuck Ries
moved test http://reviews.llvm.org/D8430 Files: test/tools/lldb-mi/TestMiGdbSetShow.py test/tools/lldb-mi/main.cpp tools/lldb-mi/MICmdCmdGdbSet.cpp tools/lldb-mi/MICmdCmdGdbSet.h tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.cpp tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.h EMAIL

Re: [Lldb-commits] [PATCH] implement gdb-set output-radix

2015-04-02 Thread Chuck Ries
added test http://reviews.llvm.org/D8430 Files: test/tools/lldb-mi/variable/TestMiVar.py tools/lldb-mi/MICmdCmdGdbSet.cpp tools/lldb-mi/MICmdCmdGdbSet.h tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.cpp tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.h EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] implement gdb-set output-radix

2015-04-02 Thread Chuck Ries
All lld-mi tests passing. http://reviews.llvm.org/D8430 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/ ___ lldb-commits mailing list lldb-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] implement gdb-set output-radix

2015-03-24 Thread Chuck Ries
Will do, sorry I haven't gotten this in yet. I have been busy with other things. -Original Message- From: Ilia K [mailto:ki.s...@gmail.com] Sent: Tuesday, March 24, 2015 2:12 AM To: Chuck Ries; abidh@gmail.com; ki.s...@gmail.com Cc: Paul Maybee; Gregg Miskelly; Steve Carroll (VISUAL

Re: [Lldb-commits] [PATCH] implement gdb-set output-radix

2015-03-19 Thread Chuck Ries
removed extraneous fix. Can somebody please check this in on my behalf? http://reviews.llvm.org/D8430 Files: tools/lldb-mi/MICmdCmdGdbSet.cpp tools/lldb-mi/MICmdCmdGdbSet.h tools/lldb-mi/MICmdCmdVar.cpp tools/lldb-mi/MICmnLLDBDebugSessionInfoVarObj.cpp EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] expose 64 bit addresses through MI

2015-03-18 Thread Chuck Ries
I am now using the PRIx64 macro in all locations. I checked and made sure that every type being used is either an MIUint64 or and lldb::addr_t, both of with are uint64s. I also noticed that IDS_CMD_ERR_LLDB_ERR_READ_MEM_BYTES was being initialized twice, and switched the second initialization

Re: [Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

2015-03-12 Thread Chuck Ries
Added comment on FileExecAndSymbols to see MIExtensions.txt. Fixed capitalization in comments. http://reviews.llvm.org/D8210 Files: tools/lldb-mi/MICmdCmdFile.cpp tools/lldb-mi/MICmdCmdFile.h tools/lldb-mi/MIExtensions.txt EMAIL PREFERENCES

Re: [Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

2015-03-12 Thread Chuck Ries
In http://reviews.llvm.org/D8210#140012, @abidh wrote: In http://reviews.llvm.org/D8210#139990, @ChuckR wrote: I am still new to this and I cannot commit directly. Should I submit a new patch with these minor changes, or will somebody with commit access make them and submit on my

Re: [Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

2015-03-12 Thread Chuck Ries
I am still new to this and I cannot commit directly. Should I submit a new patch with these minor changes, or will somebody with commit access make them and submit on my behalf? http://reviews.llvm.org/D8210 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/

Re: [Lldb-commits] [PATCH] expose 64 bit breakpoint addresses through MI

2015-03-11 Thread Chuck Ries
These are the files that have the string '%08' in them, should I fix all of them up as part of this patch? .//MICmdCmdBreak.cpp://

Re: [Lldb-commits] [PATCH] Add -p and -r options to lldb-mi command -file-exec-file-and-symbols to support iOS debugging on macOS

2015-03-11 Thread Chuck Ries
In http://reviews.llvm.org/D8210#138718, @ki.stfu wrote: In http://reviews.llvm.org/D8210#138716, @abidh wrote: In http://reviews.llvm.org/D8210#138699, @ki.stfu wrote: In http://reviews.llvm.org/D8210#138690, @abidh wrote: I personally don't like using -interpreter-exec when