sivachandra added a comment.
I am not really familiar with this area. OK from my side, but you might want
clayborg to take a look at this.
http://reviews.llvm.org/D11465
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
sivachandra updated this revision to Diff 30542.
sivachandra added a comment.
Expose the new option in the type summary add command via a -h option.
http://reviews.llvm.org/D11473
Files:
include/lldb/DataFormatters/TypeSummary.h
include/lldb/DataFormatters/ValueObjectPrinter.h
sivachandra added a comment.
I will add tests in case the general direction of this change is OK.
http://reviews.llvm.org/D11203
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
sivachandra created this revision.
sivachandra added reviewers: clayborg, granata.enrico.
sivachandra added a subscriber: lldb-commits.
Other changes around the main change include:
1. Add a method Cast to ValueObjectConstResult, ValueObjectConstResultImpl
and ValueObjectConstResultChild.
2.
Author: sivachandra
Date: Wed Jul 1 18:27:32 2015
New Revision: 241208
URL: http://llvm.org/viewvc/llvm-project?rev=241208view=rev
Log:
[Python] Allow PyLong values in integer lists (when converting to C lists)
Test Plan: dotest.py -p TestSBData
Reviewers: clayborg, granata.enrico
Reviewed
Allowing PyBool lists as well.
OK?
http://reviews.llvm.org/D10821
Files:
scripts/Python/python-typemaps.swig
test/python_api/sbdata/TestSBData.py
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index: scripts/Python/python-typemaps.swig
Enrico prompted me to do this experiment:
isinstance(True, long)
False
isinstance(False, long)
False
isinstance(False, int)
True
isinstance(True, int)
True
So, bools were allowed even before this patch! I have taken out the additional
PyBool check and reverted to the original
Hi granata.enrico,
http://reviews.llvm.org/D10783
Files:
test/python_api/formatters/TestFormattersSBAPI.py
test/python_api/formatters/jas_synth.py
test/python_api/formatters/main.cpp
test/python_api/formatters/synth.py
EMAIL PREFERENCES
On Wed, Jun 24, 2015 at 7:21 PM, Enrico Granata egran...@apple.com wrote:
I would like for your repro case to be added as a test case, so that we can
catch any future regressions in this area
If you have a few spare minutes and want to handle that, great; if not I’ll
gladly do it tomorrow
ping.
This was probably missed due to the discussion on the other two patches.
http://reviews.llvm.org/D10625
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
On Wed, Jun 24, 2015 at 10:46 AM, Enrico Granata granata.enr...@gmail.com
wrote:
I don't think this is the right change. A summary should be getting the most
qualified
possible value - compatible with user settings - because it makes sense to
use that extra
information in presenting
I have a case where in the ValueObject backing the SBValue (via the ValueImpl)
is itself a synthetic value. I hoped to get the non-synthetic version by
calling SBValue::GetNonSyntheticValue. Before the proposed change, it was only
returning the SBValue made from the backing ValueObject (which
The following is a small repro case I am using.
C++ source (class.cc):
1 class CCC
2 {
3 public:
4 int a, b, c;
5 };
6
7 int
8 main ()
9 {
10 CCC obj = { 111, 222, 333 };
11 return 0;
12 }
Python (ccc.py):
1 import lldb
2
3 def
For the record, I put a patch which solves the problem I describe here in a
different way: http://reviews.llvm.org/D10624
With my understanding of the code base, I am inclined to think that both
solutions should be present (though only one of them is sufficient to solve the
problem I am
Author: sivachandra
Date: Thu Jun 18 15:33:56 2015
New Revision: 240048
URL: http://llvm.org/viewvc/llvm-project?rev=240048view=rev
Log:
[TestLoadUnload] Build the main inferior exe with -pie.
Test Plan: dotest.py -p TestLoadUnload on Android API = 21
Reviewers: tberghammer
Subscribers:
I have enabled this test for only Android as I have verified it only for
Android.
http://reviews.llvm.org/D10469
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Address comments.
http://reviews.llvm.org/D10469
Files:
test/functionalities/load_unload/Makefile
test/functionalities/load_unload/TestLoadUnload.py
test/functionalities/load_unload/d.c
test/lldbtest.py
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
Index:
Rename skipIfUnlistedRemote to skipUnlessListedRemote.
http://reviews.llvm.org/D10469
Files:
test/functionalities/load_unload/Makefile
test/functionalities/load_unload/TestLoadUnload.py
test/functionalities/load_unload/d.c
test/lldbtest.py
EMAIL PREFERENCES
Author: sivachandra
Date: Fri Jun 5 14:54:49 2015
New Revision: 239183
URL: http://llvm.org/viewvc/llvm-project?rev=239183view=rev
Log:
[TestGdbRemoteAbort] Skip on API 16 Android devices
Summary:
This change also adds the infrastructure required to specify the API
levels for which tests should
Author: sivachandra
Date: Fri May 22 14:00:33 2015
New Revision: 238039
URL: http://llvm.org/viewvc/llvm-project?rev=238039view=rev
Log:
[TestRaise] Skip the SIGRTMIN test on Android.
Summary:
Running kill -l on nexus player (i386) device results in this:
1HUP Hangup
Author: sivachandra
Date: Mon May 11 13:49:59 2015
New Revision: 237010
URL: http://llvm.org/viewvc/llvm-project?rev=237010view=rev
Log:
[watch set tests] Use default test case executable names.
Summary: This change similar to r236783.
Reviewers: chaoren
Reviewed By: chaoren
Subscribers:
Author: sivachandra
Date: Thu May 7 19:43:28 2015
New Revision: 236800
URL: http://llvm.org/viewvc/llvm-project?rev=236800view=rev
Log:
[TestEvents] Add a 'connected' state to include remote debugging.
Test Plan: dotest.py -p TestEvents
Reviewers: vharron, chaoren
Reviewed By: chaoren
Author: sivachandra
Date: Mon Apr 27 18:56:23 2015
New Revision: 235947
URL: http://llvm.org/viewvc/llvm-project?rev=235947view=rev
Log:
[TestProcessAttach] Decorate with expectedFailureLinux
Summary: Link to PR: llvm.org/pr23360
Test Plan: dotest.py -p TestProcessAttach
Reviewers: sivachandra
Author: sivachandra
Date: Wed Apr 15 13:35:29 2015
New Revision: 235036
URL: http://llvm.org/viewvc/llvm-project?rev=235036view=rev
Log:
[TestRvalueReferences] Fix an expectation.
Summary:
If 'i' is an rvalue reference to an 'int', evaluating it with the
'expression' command will return an 'int'
On Tue, Apr 14, 2015 at 3:08 PM, Greg Clayton gclay...@apple.com wrote:
Author: gclayton
Date: Tue Apr 14 17:08:17 2015
New Revision: 234949
URL: http://llvm.org/viewvc/llvm-project?rev=234949view=rev
Log:
MacOSX needs a space between $(ARCHFLAG) and $(ARCH) otherwise we try to call
clang
to put them into concrete words.
Thanks,
Siva Chandra
On Thu, Apr 9, 2015 at 11:09 AM, Tamas Berghammer
tbergham...@google.com wrote:
+sivachandra
Siva is looking into this issue. The problem is that lldb looks for a
mangled name _ZN3fooC1Ei while the object file (compiled by clang) contains
On Thu, Apr 9, 2015 at 2:35 AM, Tamas Berghammer tbergham...@google.com wrote:
Can you check that this change fix TestCallStdStringFunction with g++ on
Linux x86_64? I think it is failing with this or with a closely related issue.
Yes. This fixes that test as well.
Author: sivachandra
Date: Thu Apr 9 14:51:56 2015
New Revision: 234527
URL: http://llvm.org/viewvc/llvm-project?rev=234527view=rev
Log:
[ItaniumABILanguageRuntime] Remove an unneccesary 'typename' keyword.
Summary: This will get the windows bots going.
Test Plan: Build LLDB on Windows.
On Thu, Apr 9, 2015 at 3:03 AM, Zachary Turner ztur...@google.com wrote:
By the way, seems this only fixes the case of std::string even though it
will continue to exist for any type with an unnamed template parameter..
Certainly std::string is the most important example, but I just want to
Will commit this to get LLDB building again.
http://reviews.llvm.org/D8933
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
On Tue, Apr 7, 2015 at 10:33 AM, Sean Callanan scalla...@apple.com wrote:
Siva,
two things:
the reason I prefer to have it return a vector is that we could have a
variety of problems, e.g. missing “const” in the debug info, and I don’t
want to have special-casing everywhere for each one.
Modify according to suggestions from spyffe.
http://reviews.llvm.org/D8846
Files:
include/lldb/Target/CPPLanguageRuntime.h
source/Expression/IRForTarget.cpp
source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
Author: sivachandra
Date: Mon Apr 6 16:52:10 2015
New Revision: 234243
URL: http://llvm.org/viewvc/llvm-project?rev=234243view=rev
Log:
Enable a test in TestSTL for GCC.
Summary:
Remove @skipIfGcc from a test in TestSTL as that test passes with GCC
now. Also, mark one of the dsym tests with
On Mon, Apr 6, 2015 at 3:32 PM, Sean Callanan scalla...@apple.com wrote:
I like this; we could have the CXXLanguageRuntime return a list of
“candidate” remangled names if you can’t find a given one, and then try
those.
The function would have the signature
size_t
Sorry for the follow up. Is it more meaningful this way:
class CPPLanguageRuntime
{
public:
...
virtual size_t GetAlternateManglings(const ConstString mangled,
std::vectorConstString alternates) = 0;
...
};
class ItaniumABILanguageRuntime : public
Author: sivachandra
Date: Wed Apr 1 19:02:46 2015
New Revision: 233868
URL: http://llvm.org/viewvc/llvm-project?rev=233868view=rev
Log:
Remove the unused m_ast_context member of ClangExpressionParser.
Test Plan: Build LLDB.
Reviewers: spyffe
Subscribers: lldb-commits
Differential Revision:
Author: sivachandra
Date: Fri Mar 27 11:00:51 2015
New Revision: 233382
URL: http://llvm.org/viewvc/llvm-project?rev=233382view=rev
Log:
[TestMiExec] Fix the test for GCC after r26.
Test Plan: dotest.py -C gcc p TestMiExec
Reviewers: vharron
Subscribers: lldb-commits
Differential
Just a drive by comment: You mention causing several test failure. Does your
patch fix them? If yes, then are they currently skipped or marked xfail? If yes
again, you should probably enable them in this patch.
At the very least, it will be helpful if you can give an example of a failing
test.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8621
Files:
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
Index: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
Author: sivachandra
Date: Tue Mar 24 13:32:27 2015
New Revision: 233098
URL: http://llvm.org/viewvc/llvm-project?rev=233098view=rev
Log:
[DWARF] If linkages names are missing, use decl context to get qualified names.
Summary:
This commit adds this alternate route only when parsing variable dies
LGTM. Thanks for doing this.
http://reviews.llvm.org/D8585
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Add a static method LanguageRuntime::LanguageIsCPlusPlus and use it.
http://reviews.llvm.org/D8569
Files:
include/lldb/Symbol/Variable.h
include/lldb/Target/LanguageRuntime.h
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
Author: sivachandra
Date: Tue Mar 24 15:27:38 2015
New Revision: 233108
URL: http://llvm.org/viewvc/llvm-project?rev=233108view=rev
Log:
[TestDataFormatterStdVector] s/-fstandalone-debug/-fno-limit-debug-info
Test Plan: dotest.py -C clang|gcc -p TestDataFormatterStdVector
Reviewers: vharron
Hi clayborg,
This commit adds this alternate route only when parsing variable dies
corresponding to global or static variables. The motivation for this is that GCC
does not emit linkage names for functions and variables declared/defined in
anonymous namespaces. Having this alternate route fixes
Author: sivachandra
Date: Wed Mar 18 18:02:28 2015
New Revision: 232687
URL: http://llvm.org/viewvc/llvm-project?rev=232687view=rev
Log:
Enable TestCallStdStringFunction for GCC.
Test Plan: dotest.py -C gcc -p TestCallStdStringFunction
Reviewers: vharron
Subscribers: lldb-commits
Differential
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8426
Files:
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
Index:
lldb/trunk/test/expression_command/call-function/TestCallStdStringFunction.py
===
---
Mention in the commit message that the removed c++ implementation
of the formatter was not being used.
http://reviews.llvm.org/D8390
Files:
examples/synthetic/gnu_libstdcpp.py
include/lldb/DataFormatters/CXXFormatterFunctions.h
source/DataFormatters/LibStdcpp.cpp
Author: sivachandra
Date: Tue Mar 17 16:43:01 2015
New Revision: 232552
URL: http://llvm.org/viewvc/llvm-project?rev=232552view=rev
Log:
Enable TestDataFormatterStdIterator with GCC.
Summary:
This test now passes for Clang and GCC. I do not know why it was
disabled for GCC with link to a bug
Setting the Python changes in perspective: Though it appears in the diff as if
I have added a formatter for std::vectornon-bool as well, I have only moved
it into an implementation class StdVectorSynthProvider.StdVectorImplementation.
What I have really added is the class
Author: sivachandra
Date: Mon Mar 16 14:01:33 2015
New Revision: 232399
URL: http://llvm.org/viewvc/llvm-project?rev=232399view=rev
Log:
Handle PyLong return values in LLDBSwigPython_CalculateNumChildren.
Summary:
Also, change its return type to size_t to match the return types of
its callers.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D8361
Files:
lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
Index:
lldb/trunk/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/map/TestDataFormatterStdMap.py
On Wed, Mar 4, 2015 at 2:59 PM, Enrico Granata egran...@apple.com wrote:
+#ifdef LLDB_CONFIGURATION_DEBUG
+#define lldbassert(x) assert(x)
+#else
+#define lldbassert(x) lldb_private::lldb_assert(x, #x, __FUNCTION__,
__FILE__, __LINE__)
+#endif
Why should we have this ifdef? As in, why
Hi flackr, ovyalov,
lldb-server needs an explicit 'g' or 'p' argument now. Since lldb-server
is started as a gdbserver in this test, 'g' should be passed to it
explicitly.
http://reviews.llvm.org/D7801
Files:
test/tools/lldb-gdbserver/commandline/TestStubSetSID.py
Index:
Per the current design, the globbing feature will not work for remote
debugging. Enrico has mentioned that he is working on the generalizing this
feature. Until then, I do not see any harm in putting this in. Will commit
shortly.
http://reviews.llvm.org/D7743
EMAIL PREFERENCES
Comment at: source/Core/Error.cpp:149
@@ -148,3 +148,3 @@
m_code = 0;
-m_type = eErrorTypeGeneric;
+m_type = eErrorTypeInvalid;
m_string.clear();
Drive by comment:
While I do not know if this OK or not, you should explain why this change is
This is probably an obvious commit. Will wait for a day, just in case.
http://reviews.llvm.org/D6907
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Hi emaste, clayborg,
GCC emits DW_TAG_subrange_type for static member arrays, but with no
attributes. This in turn results in wrong type/value of the array when
printing with 'target variable array var name'. This patch fixes this
so that the array value is printed in this format:
(element
Closing this as Shawn had already committted this for me.
http://reviews.llvm.org/D6199
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
Hi emaste,
After D6199 (http://reviews.llvm.org/D6199) landed, this test is
erroring out because of incompatible -std=libstdc++ when building on stock
Ubuntu.
http://reviews.llvm.org/D6218
Files:
test/functionalities/data-formatter/data-formatter-skip-summary/Makefile
Index:
Does the LGTM from the previous version still stand?
http://reviews.llvm.org/D6199
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
Hi enrico,
GCC apparently does not like template specializations with namespace
qualifiers such as this:
template
bool
namespace1::namespace2::funcName...()
{
...
}
GCC ToT also errors out with such namespace qualification of explicit
template specializations.
I have removed such a usage
61 matches
Mail list logo
